Page MenuHomePhabricator

Index and show Owners packages affected by Herald rules
ClosedPublic

Authored by epriestley on Apr 12 2019, 11:17 PM.
Tags
None
Referenced Files
F13305394: D20413.id48706.diff
Sat, Jun 8, 9:33 PM
F13300510: D20413.diff
Fri, Jun 7, 9:17 AM
F13294336: D20413.id48756.diff
Wed, Jun 5, 4:52 PM
F13293962: D20413.diff
Wed, Jun 5, 3:00 PM
F13293924: D20413.id.diff
Wed, Jun 5, 2:46 PM
F13283687: D20413.diff
Sun, Jun 2, 4:09 PM
F13246609: D20413.diff
Thu, May 23, 11:57 AM
F13245548: D20413.diff
Thu, May 23, 6:05 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20412. See PHI1147.

  • Index the targets of "Add Reviewer", "Add Blocking Reviewer", "Add Auditor", "Add Subscriber", and "Remove Subscriber" Herald rules. My major goal is to get Owners packages. This will also hit projects/users, but we just don't read those edges (for now, at least).
  • Add a "Related Herald Rules" panel to Owners Package pages.
  • Add a migration to reindex Herald rules for the recent build plan stuff and this, now that such a migration is easy to write.
Test Plan

Ran migration, verified all rules reindexed.

Screen Shot 2019-04-12 at 4.13.15 PM.png (988×1 px, 232 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable