Page MenuHomePhabricator

Index and show Owners packages affected by Herald rules
ClosedPublic

Authored by epriestley on Apr 12 2019, 11:17 PM.

Details

Summary

Depends on D20412. See PHI1147.

  • Index the targets of "Add Reviewer", "Add Blocking Reviewer", "Add Auditor", "Add Subscriber", and "Remove Subscriber" Herald rules. My major goal is to get Owners packages. This will also hit projects/users, but we just don't read those edges (for now, at least).
  • Add a "Related Herald Rules" panel to Owners Package pages.
  • Add a migration to reindex Herald rules for the recent build plan stuff and this, now that such a migration is easy to write.
Test Plan

Ran migration, verified all rules reindexed.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 12 2019, 11:17 PM
Owners added a subscriber: Restricted Owners Package.Apr 12 2019, 11:17 PM
epriestley requested review of this revision.Apr 12 2019, 11:19 PM
amckinley accepted this revision.Apr 17 2019, 5:44 PM
This revision is now accepted and ready to land.Apr 17 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.