Page MenuHomePhabricator

Modularize dashboard layout modes (one column, two columns, etc)
ClosedPublic

Authored by epriestley on Apr 12 2019, 3:43 PM.
Tags
None
Referenced Files
F17821813: D20406.id48695.diff
Sat, Jul 26, 3:13 AM
F17719497: D20406.diff
Fri, Jul 18, 4:04 AM
Unknown Object (File)
Jun 16 2025, 1:58 AM
Unknown Object (File)
Jun 14 2025, 10:26 AM
Unknown Object (File)
May 10 2025, 5:45 AM
Unknown Object (File)
May 9 2025, 2:23 PM
Unknown Object (File)
May 9 2025, 12:18 PM
Unknown Object (File)
May 8 2025, 2:03 AM
Subscribers
None

Details

Summary

Depends on D20405. Ref T13272. Currently, the PhabricatorDashboardLayoutConfig class uses a lot of switch() statements to define layout modes.

Although I'm not planning to add thousands of new layout modes, this (and upcoming changes) can be made substantially cleaner by using a standard modular approach.

(This doesn't fully remove PhabricatorDashboardLayoutConfig yet, but that will happen soon.)

Test Plan

Edited a dashboard, saw the same layout modes as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/dashboard/layoutconfig/PhabricatorDashboardOneThirdLayoutMode.php
14

What about the final 1%?

/s

This revision is now accepted and ready to land.Apr 12 2019, 7:38 PM
This revision was automatically updated to reflect the committed changes.