Page MenuHomePhabricator

Modularize dashboard layout modes (one column, two columns, etc)
ClosedPublic

Authored by epriestley on Apr 12 2019, 3:43 PM.
Tags
None
Referenced Files
F18786836: D20406.id48713.diff
Tue, Oct 14, 8:44 PM
F18747908: D20406.diff
Fri, Oct 3, 6:10 PM
F18747395: D20406.id48713.diff
Fri, Oct 3, 3:57 PM
F18747376: D20406.id48695.diff
Fri, Oct 3, 3:55 PM
F18739443: D20406.id.diff
Wed, Oct 1, 9:28 PM
F18653226: D20406.id48695.diff
Sep 21 2025, 11:44 AM
F18569754: D20406.id48713.diff
Sep 10 2025, 2:47 AM
F18569752: D20406.id48695.diff
Sep 10 2025, 2:47 AM
Subscribers
None

Details

Summary

Depends on D20405. Ref T13272. Currently, the PhabricatorDashboardLayoutConfig class uses a lot of switch() statements to define layout modes.

Although I'm not planning to add thousands of new layout modes, this (and upcoming changes) can be made substantially cleaner by using a standard modular approach.

(This doesn't fully remove PhabricatorDashboardLayoutConfig yet, but that will happen soon.)

Test Plan

Edited a dashboard, saw the same layout modes as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/dashboard/layoutconfig/PhabricatorDashboardOneThirdLayoutMode.php
14

What about the final 1%?

/s

This revision is now accepted and ready to land.Apr 12 2019, 7:38 PM
This revision was automatically updated to reflect the committed changes.