Page MenuHomePhabricator

Modularize dashboard layout modes (one column, two columns, etc)
ClosedPublic

Authored by epriestley on Apr 12 2019, 3:43 PM.
Tags
None
Referenced Files
F13299464: D20406.diff
Fri, Jun 7, 8:02 AM
F13282055: D20406.diff
Sun, Jun 2, 11:39 AM
F13264998: D20406.id48695.diff
Tue, May 28, 12:28 AM
F13264962: D20406.id48713.diff
Mon, May 27, 11:53 PM
F13264868: D20406.id.diff
Mon, May 27, 10:50 PM
F13256225: D20406.diff
Sat, May 25, 10:33 AM
F13211782: D20406.diff
Fri, May 17, 6:05 AM
F13195455: D20406.diff
May 12 2024, 10:24 PM
Subscribers
None

Details

Summary

Depends on D20405. Ref T13272. Currently, the PhabricatorDashboardLayoutConfig class uses a lot of switch() statements to define layout modes.

Although I'm not planning to add thousands of new layout modes, this (and upcoming changes) can be made substantially cleaner by using a standard modular approach.

(This doesn't fully remove PhabricatorDashboardLayoutConfig yet, but that will happen soon.)

Test Plan

Edited a dashboard, saw the same layout modes as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/dashboard/layoutconfig/PhabricatorDashboardOneThirdLayoutMode.php
14

What about the final 1%?

/s

This revision is now accepted and ready to land.Apr 12 2019, 7:38 PM
This revision was automatically updated to reflect the committed changes.