Page MenuHomePhabricator

Modularize dashboard layout modes (one column, two columns, etc)
ClosedPublic

Authored by epriestley on Apr 12 2019, 3:43 PM.
Tags
None
Referenced Files
F15584217: D20406.diff
Thu, May 8, 2:03 AM
F15579632: D20406.id48695.diff
Wed, May 7, 12:52 AM
F15502145: D20406.id48695.diff
Sun, Apr 13, 10:48 PM
F15480829: D20406.id.diff
Tue, Apr 8, 4:50 PM
F15474559: D20406.id.diff
Apr 6 2025, 9:49 AM
F15470895: D20406.diff
Apr 5 2025, 1:59 AM
F15469257: D20406.id48695.diff
Apr 4 2025, 11:04 AM
Unknown Object (File)
Mar 3 2025, 6:34 AM
Subscribers
None

Details

Summary

Depends on D20405. Ref T13272. Currently, the PhabricatorDashboardLayoutConfig class uses a lot of switch() statements to define layout modes.

Although I'm not planning to add thousands of new layout modes, this (and upcoming changes) can be made substantially cleaner by using a standard modular approach.

(This doesn't fully remove PhabricatorDashboardLayoutConfig yet, but that will happen soon.)

Test Plan

Edited a dashboard, saw the same layout modes as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/dashboard/layoutconfig/PhabricatorDashboardOneThirdLayoutMode.php
14

What about the final 1%?

/s

This revision is now accepted and ready to land.Apr 12 2019, 7:38 PM
This revision was automatically updated to reflect the committed changes.