Page MenuHomePhabricator

Modularize dashboard layout modes (one column, two columns, etc)
ClosedPublic

Authored by epriestley on Apr 12 2019, 3:43 PM.
Tags
None
Referenced Files
F13522954: D20406.diff
Fri, Jul 26, 7:42 AM
Unknown Object (File)
Wed, Jul 24, 12:08 AM
Unknown Object (File)
Tue, Jul 23, 5:00 PM
Unknown Object (File)
Mon, Jul 22, 3:03 PM
Unknown Object (File)
Mon, Jul 22, 4:20 AM
Unknown Object (File)
Wed, Jul 17, 9:09 AM
Unknown Object (File)
Fri, Jul 12, 10:39 PM
Unknown Object (File)
Fri, Jul 12, 3:07 PM
Subscribers
None

Details

Summary

Depends on D20405. Ref T13272. Currently, the PhabricatorDashboardLayoutConfig class uses a lot of switch() statements to define layout modes.

Although I'm not planning to add thousands of new layout modes, this (and upcoming changes) can be made substantially cleaner by using a standard modular approach.

(This doesn't fully remove PhabricatorDashboardLayoutConfig yet, but that will happen soon.)

Test Plan

Edited a dashboard, saw the same layout modes as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/dashboard/layoutconfig/PhabricatorDashboardOneThirdLayoutMode.php
14

What about the final 1%?

/s

This revision is now accepted and ready to land.Apr 12 2019, 7:38 PM
This revision was automatically updated to reflect the committed changes.