Page MenuHomePhabricator

Modularize dashboard layout modes (one column, two columns, etc)
ClosedPublic

Authored by epriestley on Fri, Apr 12, 3:43 PM.

Details

Summary

Depends on D20405. Ref T13272. Currently, the PhabricatorDashboardLayoutConfig class uses a lot of switch() statements to define layout modes.

Although I'm not planning to add thousands of new layout modes, this (and upcoming changes) can be made substantially cleaner by using a standard modular approach.

(This doesn't fully remove PhabricatorDashboardLayoutConfig yet, but that will happen soon.)

Test Plan

Edited a dashboard, saw the same layout modes as before.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Apr 12, 3:43 PM
epriestley requested review of this revision.Fri, Apr 12, 3:44 PM
amckinley accepted this revision.Fri, Apr 12, 7:38 PM
amckinley added inline comments.
src/applications/dashboard/layoutconfig/PhabricatorDashboardOneThirdLayoutMode.php
14

What about the final 1%?

/s

This revision is now accepted and ready to land.Fri, Apr 12, 7:38 PM
This revision was automatically updated to reflect the committed changes.