Page MenuHomePhabricator
Differential D12971

Remove call to "arcanist.projectinfo" from ArcanistWorkflow
ClosedPublic
Actions

Authored by joshuaspence on May 21 2015, 9:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 7:19 AM
Unknown Object (File)
Fri, Nov 22, 10:11 AM
Unknown Object (File)
Fri, Nov 22, 5:40 AM
Unknown Object (File)
Tue, Nov 19, 12:47 PM
Unknown Object (File)
Fri, Nov 15, 4:47 AM
Unknown Object (File)
Mon, Nov 11, 1:05 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:36 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7604: Remove "Arcanist Projects"
Commits
rARC59ef783f4a4b: Remove call to "arcanist.projectinfo" from ArcanistWorkflow
Summary

Ref T7604. Remove call to the arcanist.projectinfo Conduit endpoint from ArcanistWorkflow. Depends on D12992.

Test Plan

Ran arc which and verified that repository information was present.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6252
Build 6274: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31250.May 21 2015, 9:17 PM
joshuaspence retitled this revision from to Remove call to "arcanist.projectinfo" from ArcanistWorkflow.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a task: T7604: Remove "Arcanist Projects".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2015, 9:17 PM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence added a child revision: D12970: Mark "arcanist.projectinfo" as deprecated.May 21 2015, 9:18 PM
joshuaspence mentioned this in T7604: Remove "Arcanist Projects".May 21 2015, 9:28 PM
epriestley requested changes to this revision.May 24 2015, 1:20 PM
epriestley added a reviewer: epriestley.

Just pushing this back until it's ready for review.

src/workflow/ArcanistWorkflow.php
1530–1532

This is set in Diffusion, although we might need to change Conduit to make it accessible.

This revision now requires changes to proceed.May 24 2015, 1:20 PM
joshuaspence updated this revision to Diff 31324.May 25 2015, 9:01 AM
joshuaspence edited edge metadata.

Seems to work now

Herald added a subscriber: Korvin. · View Herald TranscriptMay 25 2015, 9:01 AM
joshuaspence updated this object.May 25 2015, 9:01 AM
joshuaspence edited edge metadata.
joshuaspence added a parent revision: D12992: Add encoding information to "repository.query".
joshuaspence removed a subscriber: Korvin.
joshuaspence marked an inline comment as done.May 25 2015, 11:02 AM
joshuaspence added inline comments.
src/workflow/ArcanistWorkflow.php
1530–1532

See D12992.

joshuaspence updated this object.May 25 2015, 11:44 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence updated this revision to Diff 31339.May 25 2015, 11:45 AM
joshuaspence marked an inline comment as done.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)

Tidying

joshuaspence updated this object.May 25 2015, 11:45 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence marked an inline comment as done.
joshuaspence added inline comments.
src/workflow/ArcanistWorkflow.php
1535

I despite this method name but kept it for backwards compatibility mostly.

epriestley accepted this revision.May 25 2015, 11:54 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 25 2015, 11:54 AM
epriestley mentioned this in D12945: Remove arcanist projects from working copy code.May 25 2015, 12:03 PM
Closed by commit rARC59ef783f4a4b: Remove call to "arcanist.projectinfo" from ArcanistWorkflow (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 25 2015, 12:06 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D13061: Always return an array from ArcanistWorkflow->loadProjectRepository().May 28 2015, 11:10 PM
epriestley mentioned this in rARCcdaa0e32e473: Always return an array from ArcanistWorkflow->loadProjectRepository().May 28 2015, 11:11 PM

Revision Contents
Changeset List

PathSize
src/
workflow/
88 lines

Diff 31339

View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility