Page MenuHomePhabricator

Change parameters for `diffusion.getlintmessages` call
ClosedPublic

Authored by joshuaspence on May 18 2015, 2:09 PM.
Tags
None
Referenced Files
F18050592: D12900.id31025.diff
Sun, Aug 3, 8:30 PM
F17924626: D12900.id31025.diff
Wed, Jul 30, 10:19 AM
F17871248: D12900.id.diff
Mon, Jul 28, 3:35 PM
F17868629: D12900.diff
Mon, Jul 28, 8:02 AM
F17851010: D12900.diff
Sun, Jul 27, 10:47 AM
F17711741: D12900.diff
Thu, Jul 17, 9:14 AM
F17668853: D12900.id31025.diff
Sat, Jul 12, 11:30 PM
Unknown Object (File)
Jul 3 2025, 10:36 AM
Subscribers

Details

Summary

Ref T7604. Change the parameter for diffusion.getlintmessages from arcanistProject to repositoryPHID.

Test Plan

Ran arc --conduit-uri='http://phabricator.local lint --only-new=1

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Change parameters for `diffusion.getlintmessages` call.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 2:09 PM

To further the case for not being exceptionally careful here, this didn't work before for like 98%+ of users.

Very few repositories have an arcanist project, and the old code just immediately returned array() if you didn't have one.

I mean, it "worked", it just didn't do anything useful.

This revision was automatically updated to reflect the committed changes.