Page MenuHomePhabricator
Differential D12900

Change parameters for `diffusion.getlintmessages` call
ClosedPublic
Actions

Authored by joshuaspence on May 18 2015, 2:09 PM.
Tags
None
Referenced Files
F18101406: D12900.id31027.diff
Sat, Aug 9, 1:02 PM
F18050592: D12900.id31025.diff
Sun, Aug 3, 8:30 PM
F17924626: D12900.id31025.diff
Wed, Jul 30, 10:19 AM
F17871248: D12900.id.diff
Jul 28 2025, 3:35 PM
F17868629: D12900.diff
Jul 28 2025, 8:02 AM
F17851010: D12900.diff
Jul 27 2025, 10:47 AM
F17711741: D12900.diff
Jul 17 2025, 9:14 AM
F17668853: D12900.id31025.diff
Jul 12 2025, 11:30 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7604: Remove "Arcanist Projects"
Commits
rARCd0d2cf903cf9: Change parameters for `diffusion.getlintmessages` call
Summary

Ref T7604. Change the parameter for diffusion.getlintmessages from arcanistProject to repositoryPHID.

Test Plan

Ran arc --conduit-uri='http://phabricator.local lint --only-new=1

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31025.May 18 2015, 2:09 PM
joshuaspence retitled this revision from to Change parameters for `diffusion.getlintmessages` call.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7604: Remove "Arcanist Projects".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2015, 2:09 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.May 18 2015, 2:09 PM
joshuaspence edited edge metadata.
joshuaspence added a parent revision: D12893: Change "lint save" to not use Arcanist Projects.
epriestley accepted this revision.May 18 2015, 2:09 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 2:09 PM
epriestley added a comment.May 18 2015, 2:10 PM

To further the case for not being exceptionally careful here, this didn't work before for like 98%+ of users.

joshuaspence added a comment.May 18 2015, 2:10 PM

What do you mean?

epriestley added a comment.May 18 2015, 2:12 PM

Very few repositories have an arcanist project, and the old code just immediately returned array() if you didn't have one.

I mean, it "worked", it just didn't do anything useful.

joshuaspence added a comment.May 18 2015, 2:13 PM

Gotcha.

Closed by commit rARCd0d2cf903cf9: Change parameters for `diffusion.getlintmessages` call (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 18 2015, 2:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
2 lines

Diff 31027

View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility