Fixes T7977.
- Move Indexed Languages and See Symbols From config to Repository
- Make symbol search skip projects
This also makes the default languages to Everything instead of Nothing.
Differential D12687
Search Symbols by Repository, not Project avivey on May 4 2015, 1:55 AM. Authored by Tags None Referenced Files
Subscribers
Details
Fixes T7977.
This also makes the default languages to Everything instead of Nothing.
Diff Detail
Event TimelineComment Actions I didn't really catch anything substantive either, this looks great to me.
Comment Actions @epriestley: @joshuaspence raised a good point - How about we eliminate the "indexed languages" completely? It looks like any value other than all is very unlikely (Just for people who hate extra dotted underlines?) Comment Actions Generally looks good. Some minor inlines.
Comment Actions Updates to migration schema I'm a little hesitant to make changes to the migration script, because it's finicky to test. I've made a good effort last round ("Diff 3"), but I forgot how I did it, so this round might actually be worse. I did test it again and it probably should be fine. Plus, this version is all about using db fields directly, which will only work if projects hadn't actually changed it's structures since whenever was the last time the install upgraded (It looks very old schema, so it might be true).
Comment Actions Couple of adjustments I caught poking at this locally:
I just removed the symbol code in the if ($request->isFormPost()) body.
|