Page MenuHomePhabricator

Remove call to "arcanist.projectinfo" from ArcanistWorkflow
ClosedPublic

Authored by joshuaspence on May 21 2015, 9:17 PM.
Tags
None
Referenced Files
F14022361: D12971.diff
Wed, Nov 6, 4:52 PM
F14005231: D12971.diff
Sun, Oct 27, 9:36 AM
F14004843: D12971.id31339.diff
Sun, Oct 27, 3:40 AM
F13990047: D12971.id31250.diff
Tue, Oct 22, 12:41 AM
F13978453: D12971.id31250.diff
Fri, Oct 18, 11:15 PM
F13959489: D12971.id31339.diff
Mon, Oct 14, 7:37 PM
Unknown Object (File)
Oct 8 2024, 2:26 PM
Unknown Object (File)
Oct 1 2024, 9:52 PM
Subscribers

Details

Summary

Ref T7604. Remove call to the arcanist.projectinfo Conduit endpoint from ArcanistWorkflow. Depends on D12992.

Test Plan

Ran arc which and verified that repository information was present.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Remove call to "arcanist.projectinfo" from ArcanistWorkflow.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Just pushing this back until it's ready for review.

src/workflow/ArcanistWorkflow.php
1530–1532

This is set in Diffusion, although we might need to change Conduit to make it accessible.

This revision now requires changes to proceed.May 24 2015, 1:20 PM
joshuaspence edited edge metadata.

Seems to work now

joshuaspence added inline comments.
src/workflow/ArcanistWorkflow.php
1530–1532

See D12992.

joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence marked an inline comment as done.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)

Tidying

joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence marked an inline comment as done.
joshuaspence added inline comments.
src/workflow/ArcanistWorkflow.php
1535–1536

I despite this method name but kept it for backwards compatibility mostly.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 25 2015, 11:54 AM
This revision was automatically updated to reflect the committed changes.