Page MenuHomePhabricator

Remove arcanist projects from differential
ClosedPublic

Authored by joshuaspence on May 18 2015, 1:03 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7604: Remove "Arcanist Projects"
Commits
Restricted Diffusion Commit
rP021223907dfd: Remove arcanist projects from differential
Summary

Ref T7604. Remove arcanist projects from differential. Depends on D12687 and D12893.

Test Plan

Submitted a diff. Patched the diff with arc patch.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence retitled this revision from to Remove arcanist projects from differential.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.May 18 2015, 1:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 1:43 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.

I'm guessing it is okay to remove the differential.getrevision and differential.getdiff endpoints? They were deprecated some time ago.

If they don't make this change harder (I think they don't), I'd very slightly prefer to leave them until T5873 / T7715. I think those are happening soon (next few months) and I'm currently looking at compressing as many breaking API changes into a small window of time as I can in connection with them (basically, make a single major revision to the API instead of breaking it a bunch of times over the next few months).

Particularly, if we remove them today, anything relying on them will need to switch to revision.query, and then be broken again by T7715. If we get rid of them both at once, clients can do a single update.

Don't query differential.getdiff or diferential.getrevision

This revision was automatically updated to reflect the committed changes.