Remove call to "arcanist.projectinfo" from `arc export`
ClosedPublic
Actions

Authored by joshuaspence on May 21 2015, 9:11 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7604: Remove "Arcanist Projects"

Commits

rARCbe9dd352be58: Remove call to "arcanist.projectinfo" from `arc export`

Summary

Ref T7604. Remove a call to arcanist.projectinfo from arc export. This Conduit call was only used to detect the repository encoding, which we should be able to do locally anyway.

I was considering removing the $projectName from ArcanistBundle as well, but I'm not convinved that this is a good idea. Specifically, doing so would make it difficult to issue the "This patch is for the 'X' project, but the working copy belongs to the 'Y' project" error. We could potentially use the repository callsign for this purposes, but this isn't portable across installs.

Test Plan

I'm not quite sure how to test this. I suspect that this functionality isn't widely used anyway.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31226.May 21 2015, 9:11 AM

joshuaspence retitled this revision from to Remove "arcanist projects" from bundles.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a task: T7604: Remove "Arcanist Projects".

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2015, 9:11 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Further progress

joshuaspence retitled this revision from Remove "arcanist projects" from bundles to Remove call to "arcanist.projectinfo" from `arc export`.May 21 2015, 9:54 AM

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a child revision: D12970: Mark "arcanist.projectinfo" as deprecated.May 21 2015, 9:18 PM

joshuaspence mentioned this in T7604: Remove "Arcanist Projects".May 21 2015, 9:28 PM

I think removing the name from the bundle is reasonable. I don't think the warning is particularly important, and it would be fine to drop it entirely.

Shy of that, we could check remote URIs:

This patch was generated in a repository with origin ssh://mycompany.com/libphutil.git, but you are applying it in a repository which does not use this remote. You might be trying to patch the wrong working copy. Continue anyway? [Y/n]

This revision is now accepted and ready to land.May 24 2015, 1:19 PM

I don't think it's the simple. I just attempted to do arc patch with a differential that had a dependent diff in an other repository. The behavior seems unexpected to me, it attempts to patch the revision from the other repository.

In D12962#135205, @joshuaspence wrote:

I don't think it's the simple. I just attempted to do arc patch with a differential that had a dependent diff in an other repository. The behavior seems unexpected to me, it attempts to patch the revision from the other repository.

I filed T8307.