Page MenuHomePhabricator
Differential D13012

Remove "arcanist project" fields
ClosedPublic
Actions

Authored by joshuaspence on May 25 2015, 9:22 PM.
Tags
None
Referenced Files
F13084007: D13012.diff
Wed, Apr 24, 10:46 PM
Unknown Object (File)
Fri, Apr 12, 10:23 PM
Unknown Object (File)
Mon, Apr 1, 11:01 AM
Unknown Object (File)
Sun, Mar 31, 12:45 AM
Unknown Object (File)
Mar 24 2024, 6:18 PM
Unknown Object (File)
Mar 24 2024, 1:45 AM
Unknown Object (File)
Mar 23 2024, 11:11 PM
Unknown Object (File)
Mar 23 2024, 3:10 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7604: Remove "Arcanist Projects"
Commits
Restricted Diffusion Commit
rP9c5d9e3f4716: Remove "arcanist project" fields
Summary

Ref T7604. Remove these "arcanist project" fields from the LiskDAO classes, but leave the data intact (there are no more read/writes to this data).

Test Plan
  • Grepped for calls to these methods.
  • Ran ./bin/storage adjust to check for schema issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31379.May 25 2015, 9:22 PM
joshuaspence retitled this revision from to Remove "arcanist project" fields.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7604: Remove "Arcanist Projects".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2015, 9:22 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a comment.May 25 2015, 9:23 PM

It looks like I broke this in D12898, but I'm not actually sure how to fix it:

TargetError
phabricator_releeph.releeph_project.arcanistProjectIDWrong Nullable Setting
epriestley added inline comments.May 25 2015, 9:55 PM
src/applications/releeph/storage/ReleephProject.php
38

Add 'arcanistProjectID' => 'id?' here, I believe

joshuaspence added inline comments.May 25 2015, 10:04 PM
src/applications/releeph/storage/ReleephProject.php
38

Hm, that didn't seem to help.

joshuaspence added inline comments.May 25 2015, 10:12 PM
src/applications/releeph/storage/ReleephProject.php
38

Ah I figured it out. Sending you a diff.

joshuaspence marked 3 inline comments as done.May 25 2015, 10:14 PM
joshuaspence added inline comments.
src/applications/releeph/storage/ReleephProject.php
38

See D13014.

joshuaspence updated this revision to Diff 31384.May 25 2015, 10:14 PM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Fix schema issue for releeph_project.arcanistProjectID

joshuaspence marked an inline comment as done.May 25 2015, 10:15 PM
joshuaspence added a child revision: D12899: Remove remaining arcanist project code.May 25 2015, 10:18 PM
joshuaspence edited the test plan for this revision. (Show Details)May 31 2015, 2:34 AM
joshuaspence updated this revision to Diff 31553.May 31 2015, 2:36 AM

Rebase

epriestley accepted this revision.May 31 2015, 2:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 31 2015, 2:38 PM
Closed by commit rP9c5d9e3f4716: Remove "arcanist project" fields (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 31 2015, 11:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
20 lines
releeph/
storage/
11 lines

Diff 31582

View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/releeph/storage/ReleephProject.php

Loading...
Phabricator · Built by Phacility