Fixes T7604. This is the big scary change which drops the "arcanist project" fields from the database permanently.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7604: Remove "Arcanist Projects"
- Commits
- Restricted Diffusion Commit
rP0036670329cc: Remove remaining arcanist project code
grepped for the following to ensure that I had found all remaining references:
- /arcanistProject/i
- /arcanist_project/i
- /projectName/i
- /project_name/i
- /project_id/i
WARNING: Wait at least one month before landing this.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I'm good with bringing about 90% of this upstream soon, but don't want to actually destroy the data for a while, so the 20150518.arcanistproject.sql migration and changes to DifferentialRevision.php and DifferentialDiff.php which would cause problems if these columns still exist should wait for a month or two.
We can either just hold this whole thing, or you can split the data/schema-destruction parts out of it and we can get rid of all the code now and the data later.
Comment Actions
Yeah, this diff was intended to be all of the actual destructive stuff that can wait until later... although possibly a few of these classes can be removed without actually destroying any data.