Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7604: Remove "Arcanist Projects"

Commits

rARC59ef783f4a4b: Remove call to "arcanist.projectinfo" from ArcanistWorkflow

Summary

Ref T7604. Remove call to the arcanist.projectinfo Conduit endpoint from ArcanistWorkflow. Depends on D12992.

Test Plan

Ran arc which and verified that repository information was present.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 6196
Build 6217: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31250.May 21 2015, 9:17 PM

joshuaspence retitled this revision from to Remove call to "arcanist.projectinfo" from ArcanistWorkflow.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a task: T7604: Remove "Arcanist Projects".

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2015, 9:17 PM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence added a child revision: D12970: Mark "arcanist.projectinfo" as deprecated.May 21 2015, 9:18 PM

joshuaspence mentioned this in T7604: Remove "Arcanist Projects".May 21 2015, 9:28 PM

Just pushing this back until it's ready for review.

src/workflow/ArcanistWorkflow.php
1523	This is set in Diffusion, although we might need to change Conduit to make it accessible.

This revision now requires changes to proceed.May 24 2015, 1:20 PM

Seems to work now

Herald added a subscriber: Korvin. · View Herald TranscriptMay 25 2015, 9:01 AM

joshuaspence updated this object.May 25 2015, 9:01 AM

joshuaspence edited edge metadata.

joshuaspence added a parent revision: D12992: Add encoding information to "repository.query".

joshuaspence removed a subscriber: Korvin.

joshuaspence marked an inline comment as done.May 25 2015, 11:02 AM

joshuaspence added inline comments.

src/workflow/ArcanistWorkflow.php
1523	See D12992.

joshuaspence updated this object.May 25 2015, 11:44 AM

joshuaspence edited the test plan for this revision. (Show Details)

Tidying

joshuaspence updated this object.May 25 2015, 11:45 AM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence marked an inline comment as done.

joshuaspence added inline comments.

src/workflow/ArcanistWorkflow.php
1526–1527	I despite this method name but kept it for backwards compatibility mostly.

epriestley accepted this revision.May 25 2015, 11:54 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 25 2015, 11:54 AM

epriestley mentioned this in D12945: Remove arcanist projects from working copy code.May 25 2015, 12:03 PM

Closed by commit rARC59ef783f4a4b: Remove call to "arcanist.projectinfo" from ArcanistWorkflow (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 25 2015, 12:06 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D13061: Always return an array from ArcanistWorkflow->loadProjectRepository().May 28 2015, 11:10 PM

epriestley mentioned this in rARCcdaa0e32e473: Always return an array from ArcanistWorkflow->loadProjectRepository().May 28 2015, 11:11 PM

Remove call to "arcanist.projectinfo" from ArcanistWorkflow
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31250

src/workflow/ArcanistWorkflow.php

Remove call to "arcanist.projectinfo" from ArcanistWorkflowClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31250

src/workflow/ArcanistWorkflow.php

Remove call to "arcanist.projectinfo" from ArcanistWorkflow
ClosedPublic
Actions

Revision Contents
Changeset List