HomePhabricator

Recent Activity
ActivePublic

Recent Activity

Yesterday

aeiser added a comment to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.

the (Show Details) would be a great first step for us - and cover our needs. Much like the logs for Herald Rules and other areas.

Wed, Jun 19, 10:58 PM · EditEngine
amckinley requested review of D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Wed, Jun 19, 10:21 PM
amckinley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Wed, Jun 19, 10:19 PM · EditEngine
epriestley changed the visibility for D3219: Add View, Edit and Join policies to PhabricatorProject.
Wed, Jun 19, 9:45 PM
epriestley committed rP37e26f1b4531: Improve rendering of "default value changed" custom form transactions to at… (authored by epriestley).
Improve rendering of "default value changed" custom form transactions to at…
Wed, Jun 19, 8:47 PM
epriestley closed D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information.
Wed, Jun 19, 8:47 PM
epriestley added a comment to T13318: Phacility developer setup documentation omits "local.*" hosts.

🐫 Does this button work ------>>^^^

Wed, Jun 19, 8:36 PM · Phacility
D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information is now accepted and ready to land.
Wed, Jun 19, 8:35 PM
epriestley requested review of D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information.
Wed, Jun 19, 8:29 PM
epriestley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information.
Wed, Jun 19, 8:27 PM · EditEngine
epriestley added a comment to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.

There are a few pieces here, since we have to thread the needle through many layers to get where we want to go.

Wed, Jun 19, 8:16 PM · EditEngine
epriestley created T13319: Transactions which modify EditEngine form default values don't include details about the old and new values.
Wed, Jun 19, 7:54 PM · EditEngine
epriestley committed rPcaaa1394ef15: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y. (authored by epriestley).
Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.
Wed, Jun 19, 7:51 PM
epriestley closed D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 7:51 PM
epriestley closed T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility) as Resolved by committing rPcaaa1394ef15: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y..
Wed, Jun 19, 7:51 PM · Mail, Phacility
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

If JIRA links are mostly/all in the form ?page=com.jira.jira.plugin.extension.gateway-to-realms-of-wonder&exec=rm -rf / that might also mean that "links which don't really link to the task" are common and that "task + params" is more like "portal to arbitrary plugin behavior", although I'm not having much luck digging up more information about this by Googling.

Wed, Jun 19, 7:48 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

(Also, now that I've read PHI1312, I mind this^^ implementation less since that was the actual support request anyway).

Wed, Jun 19, 7:46 PM
D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address is now accepted and ready to land.
Wed, Jun 19, 7:27 PM
D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper) is now accepted and ready to land.

Do you think ( XXX-123 Order More Copier Paper ) is still a reasonable rendering if the parameter is something like ?download=123 and that means "Download Attached File 123" and clicking the link doesn't take you to XXX-123 at all?

Wed, Jun 19, 7:21 PM
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

Also, practically, I can't actually figure out how to get either modern JIRA or Asana to generate any URI with any parameters or fragments at all. Neither appears to support linking directly to a comment.

Wed, Jun 19, 7:17 PM
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

I guess my assumption is that ?a=b may, in the general case, completely change the meaning of the link. Although I think this has mostly been purged from the web now, an example was #! fragments before the widespread use of the history API, where https://example.com/a/#!b actually meant "Page B", not "Page A", and labeling the link "Page A" would be misleading.

Wed, Jun 19, 7:09 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

If it's the same thing, that seems possibly confusing (two different links have the same visual rendering).

Wed, Jun 19, 7:03 PM
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

It's meaningfully more work, but the bigger thing stopping me is that I'm not sure what the best display behavior is.

Wed, Jun 19, 6:53 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

This is just short-circuiting the whole external object lookup process, right? Is it significantly more work to just fix the lookup process to preserve these fragments?

Wed, Jun 19, 6:40 PM
epriestley added inline comments to D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 6:22 PM
epriestley added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

See also T13317.

Wed, Jun 19, 6:20 PM · Wikimedia, Policy
epriestley requested review of D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 6:17 PM
epriestley added a revision to T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility): D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address.
Wed, Jun 19, 6:15 PM · Mail, Phacility
epriestley requested review of D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Wed, Jun 19, 5:48 PM
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Wed, Jun 19, 5:46 PM · Remarkup, Diffusion

Panel Used By

DashboardRestricted Dashboard
DashboardHome (Logged-out)
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard
DashboardRestricted Dashboard

Event Timeline

epriestley renamed this panel from to Recent Activity.May 16 2014, 2:55 AM
epriestley edited a custom field.
epriestley edited a custom field.
chad edited a custom field.May 23 2014, 10:40 PM
epriestley changed the visibility from "All Users" to "Public (No Login Required)".Jun 23 2014, 11:39 PM
mbishopim3 edited an edge.
Ken24 edited an edge.Jun 2 2015, 1:37 PM
anda edited an edge.Jun 12 2015, 5:53 AM
dtf edited an edge.Jul 6 2015, 8:17 PM
jayfar edited an edge.
luuk2305 edited an edge.
VTG38 edited an edge.May 3 2016, 1:49 PM