Page MenuHomePhabricator

Move workboard "View as Query" workflow to a separate controller
ClosedPublic

Authored by epriestley on Jul 2 2019, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:49 PM
Unknown Object (File)
Wed, Apr 24, 5:12 PM
Unknown Object (File)
Tue, Apr 16, 4:50 AM
Unknown Object (File)
Thu, Apr 11, 4:23 AM
Unknown Object (File)
Thu, Apr 11, 4:23 AM
Unknown Object (File)
Thu, Apr 11, 4:23 AM
Unknown Object (File)
Wed, Apr 10, 6:27 PM
Unknown Object (File)
Sat, Mar 30, 8:19 AM
Subscribers
None

Details

Summary

Depends on D20632. Ref T4900. As with other workflows on the board controller, this one is currently in the giant main "do everything" method. Move it to a separate controller.

This makes one material improvement: previously, we built the full board and did layout on all the cards before building the query. However, we do not actually need to do this: we don't need the cards. Instead, just do layout without handing over any card PHIDs. This is slightly faster, particularly on large boards.

Test Plan
  • Clicked "View as Query" on a board, got a query page for the column.
  • Applied a custom filter, then clicked "View as Query" on a board. Got a query page merging the two filters.
  • Applied a custom filter, then clicked "Veiw as Query" on a board, in a subproject column. Got a query page merging the two filters, respecting the project-ness of the column.

Diff Detail

Repository
rP Phabricator
Branch
refresh6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23087
Build 31696: Run Core Tests
Build 31695: arc lint + arc unit