Page MenuHomePhabricator

Give the workboard "default" workflows more modern state handling
ClosedPublic

Authored by epriestley on Jun 29 2019, 10:34 PM.
Tags
None
Referenced Files
F12855759: D20629.diff
Fri, Mar 29, 9:18 AM
Unknown Object (File)
Thu, Mar 14, 5:21 PM
Unknown Object (File)
Feb 6 2024, 10:38 PM
Unknown Object (File)
Feb 3 2024, 10:46 PM
Unknown Object (File)
Jan 18 2024, 7:06 AM
Unknown Object (File)
Dec 31 2023, 12:57 PM
Unknown Object (File)
Dec 28 2023, 9:31 AM
Unknown Object (File)
Dec 25 2023, 11:14 AM
Subscribers
None

Details

Summary

Depends on D20628. Ref T4900. Currently, the "Save Current Order/Filter As Default" flows on workboards duplicate some state construction, and require parameters to be passed to them explicitly.

Now that state management is separate, they can reuse a bit more code and be made to look more like other similar controllers.

Test Plan
  • Changed the default order of a workboard.
  • Changed the default filter of a workboard.
  • Changed the order of a board to something non-default, then changed the filter, then saved the new filter as the default. Saw the modified order preserved and the modified filter removed, so I ended up in the right ("most correct") place: on the board, with my custom order in a URI parameter, and no filter URI parameter so I could see my new default filter behavior. This is an edge case that's not terribly important to get right, but we do get it right.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable