Paths

Table of Contentst

Differential D20458

Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
ClosedPublic
Actions

Authored by epriestley on Apr 22 2019, 7:06 PM.

Details

Reviewers

Maniphest Tasks

T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time

Commits

rP7e8dc0742bdc: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"

Summary

Depends on D20457. Ref T13276. Kill all remaining callers to this method and delete it.

Test Plan

Grepped for loadIDsByCommitPHIDs.
Viewed blame again to make sure I didn't break it.
Viewed "History" view for commits with revisions.
Viewed "Graph" view for commits with revisions.
Viewed "Merged Commits" table for commits with revisions.
Viewed "Compare" table for commits with revisions.
Viewed "Repository" main page history table for commits with revisions.
Grepped for linkRevision.

Diff Detail

Repository

rP Phabricator

Branch

audit2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22707
Build 31125: Run Core Tests
Build 31124: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 22 2019, 7:06 PM

Harbormaster completed remote builds in B22684: Diff 48812.Apr 22 2019, 7:08 PM

epriestley requested review of this revision.Apr 22 2019, 7:08 PM

epriestley added a child revision: D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.Apr 22 2019, 7:34 PM

amckinley accepted this revision.Apr 23 2019, 5:14 PM

This revision is now accepted and ready to land.Apr 23 2019, 5:14 PM

amckinley added inline comments.Apr 23 2019, 5:18 PM

src/applications/diffusion/query/DiffusionCommitRevisionQuery.php
9	`assert_instances_of`?

Typechecking.

Harbormaster completed remote builds in B22707: Diff 48832.Apr 24 2019, 12:48 PM

Closed by commit rP7e8dc0742bdc: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()" (authored by epriestley). · Explain WhyApr 24 2019, 12:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

differential/

storage/

DifferentialRevision.php

12 lines

diffusion/

controller/

DiffusionBlameController.php

45 lines

DiffusionBrowseController.php

6 lines

DiffusionCommitController.php

2 lines

DiffusionCompareController.php

6 lines

DiffusionGraphController.php

1 line

DiffusionHistoryController.php

1 line

DiffusionRepositoryController.php

8 lines

query/

DiffusionCommitRevisionQuery.php

49 lines

view/

DiffusionHistoryListView.php

11 lines

DiffusionHistoryTableView.php

18 lines

DiffusionHistoryView.php

45 lines

DiffusionView.php

13 lines

Diff 48832

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/storage/DifferentialRevision.php

View Options

src/applications/diffusion/controller/DiffusionBlameController.php

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/controller/DiffusionCompareController.php

View Options

src/applications/diffusion/controller/DiffusionGraphController.php

View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

View Options

src/applications/diffusion/query/DiffusionCommitRevisionQuery.php

View Options

src/applications/diffusion/view/DiffusionHistoryListView.php

View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

View Options

src/applications/diffusion/view/DiffusionHistoryView.php

View Options

src/applications/diffusion/view/DiffusionView.php

Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48832

src/__phutil_library_map__.php

src/applications/differential/storage/DifferentialRevision.php

src/applications/diffusion/controller/DiffusionBlameController.php

src/applications/diffusion/controller/DiffusionBrowseController.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/controller/DiffusionCompareController.php

src/applications/diffusion/controller/DiffusionGraphController.php

src/applications/diffusion/controller/DiffusionHistoryController.php

src/applications/diffusion/controller/DiffusionRepositoryController.php

src/applications/diffusion/query/DiffusionCommitRevisionQuery.php

src/applications/diffusion/view/DiffusionHistoryListView.php

src/applications/diffusion/view/DiffusionHistoryTableView.php

src/applications/diffusion/view/DiffusionHistoryView.php

src/applications/diffusion/view/DiffusionView.php

Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
ClosedPublic
Actions

Revision Contents
Changeset List