Paths

Table of Contentst

Differential D20411

Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 8:06 PM.

Tags

None

Referenced Files

	F14114833: D20411.diff
	Thu, Nov 28, 9:25 AM

	Unknown Object (File)
	Tue, Nov 26, 3:50 PM

	Unknown Object (File)
	Tue, Nov 26, 7:16 AM

	Unknown Object (File)
	Tue, Nov 26, 6:23 AM

	Unknown Object (File)
	Tue, Nov 26, 6:23 AM

	Unknown Object (File)
	Mon, Nov 25, 6:34 AM

	Unknown Object (File)
	Sun, Nov 24, 4:52 AM

	Unknown Object (File)
	Thu, Nov 21, 1:38 PM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPf13709b13b68: Update search indexes for Dashboards and Panels to Ferret, plus various minor…

Summary

Depends on D20410. Ref T13272. Dashboards/Panels currently use older "ngram" indexing, which is a less-powerful precursor to Ferret. Throw away the ngram index and provide a Ferret index instead. Also:

Remove the NUX state, which links to the wrong place now and doesn't seem terribly important.
Add project tags to the search result list.
Make the "No Tags" tag a little less conspicious.

Test Plan

Indexed dashboards and panels.
Searched for dashboards and panels via SearchEngine using Ferret "query" field.
Searched for panels via "Add Existing Panel" datasource typeahead.
Searched for dashboards via "Add Menu Item > Dashboard" on a ProfileMenu via typeahead.
Viewed dashboard NUX state (no special state, but no more bad link to "/create/").
Viewed dashboard list, saw project tags.
Viewed dashboards with no project tags ("No Tags" is now displayed but less visible).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 12 2019, 8:06 PM

Owners added a subscriber: Restricted Owners Package.Apr 12 2019, 8:06 PM

Harbormaster completed remote builds in B22573: Diff 48703.Apr 12 2019, 8:08 PM

epriestley requested review of this revision.Apr 12 2019, 8:08 PM

This (and other changes in this series) require a reindex, but I'm planning to probably let migrations run a bin/search index --type ... via the Worker queue so this happens automatically a little later on, since all the stuff we need to reindex (panels, herald rules, dashboards, portals) should only take a minute or two to reindex.

epriestley added a child revision: D20412: Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs).Apr 12 2019, 9:27 PM

amckinley accepted this revision.Apr 12 2019, 9:56 PM

This revision is now accepted and ready to land.Apr 12 2019, 9:56 PM

Closed by commit rPf13709b13b68: Update search indexes for Dashboards and Panels to Ferret, plus various minor… (authored by epriestley). · Explain WhyApr 14 2019, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

sql/

autopatches/

20190412.dashboard.03.dashngrams.sql

1 line

20190412.dashboard.04.panelngrams.sql

1 line

20190412.dashboard.05.dferret.doc.sql

9 lines

20190412.dashboard.06.dferret.field.sql

8 lines

20190412.dashboard.07.dferret.ngrams.sql

5 lines

20190412.dashboard.08.dferret.cngrams.sql

7 lines

20190412.dashboard.09.pferret.doc.sql

9 lines

20190412.dashboard.10.pferret.field.sql

8 lines

20190412.dashboard.11.pferret.ngrams.sql

5 lines

20190412.dashboard.12.pferret.cngrams.sql

7 lines

src/

__phutil_library_map__.php

applications/

dashboard/

engine/

PhabricatorDashboardFerretEngine.php

18 lines

PhabricatorDashboardFulltextEngine.php

23 lines

PhabricatorDashboardPanelFerretEngine.php

18 lines

PhabricatorDashboardPanelFulltextEngine.php

23 lines

query/

PhabricatorDashboardPanelQuery.php

6 lines

PhabricatorDashboardPanelSearchEngine.php

8 lines

PhabricatorDashboardQuery.php

14 lines

PhabricatorDashboardSearchEngine.php

53 lines

storage/

PhabricatorDashboard.php

22 lines

PhabricatorDashboardNgrams.php

PhabricatorDashboardPanel.php

22 lines

PhabricatorDashboardPanelNgrams.php

typeahead/

PhabricatorDashboardDatasource.php

6 lines

PhabricatorDashboardPanelDatasource.php

6 lines

phid/

view/

PHUIHandleTagListView.php

2 lines

view/

phui/

PHUITagView.php

1 line

webroot/

rsrc/

css/

phui/

phui-tag-view.css

6 lines

Diff 48718

resources/celerity/map.php

Loading...

resources/sql/autopatches/20190412.dashboard.03.dashngrams.sql

Loading...

resources/sql/autopatches/20190412.dashboard.04.panelngrams.sql

Loading...

resources/sql/autopatches/20190412.dashboard.05.dferret.doc.sql

Loading...

resources/sql/autopatches/20190412.dashboard.06.dferret.field.sql

Loading...

resources/sql/autopatches/20190412.dashboard.07.dferret.ngrams.sql

Loading...

resources/sql/autopatches/20190412.dashboard.08.dferret.cngrams.sql

Loading...

resources/sql/autopatches/20190412.dashboard.09.pferret.doc.sql

Loading...

resources/sql/autopatches/20190412.dashboard.10.pferret.field.sql

Loading...

resources/sql/autopatches/20190412.dashboard.11.pferret.ngrams.sql

Loading...

resources/sql/autopatches/20190412.dashboard.12.pferret.cngrams.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardFerretEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardFulltextEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardPanelFerretEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardPanelFulltextEngine.php

Loading...

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

Loading...

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...

src/applications/dashboard/query/PhabricatorDashboardQuery.php

Loading...

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardNgrams.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardPanelNgrams.php

Loading...

src/applications/dashboard/typeahead/PhabricatorDashboardDatasource.php

Loading...

src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php

Loading...

src/applications/phid/view/PHUIHandleTagListView.php

Loading...

src/view/phui/PHUITagView.php

Loading...

webroot/rsrc/css/phui/phui-tag-view.css

Loading...