Page MenuHomePhabricator

Update "add panel" and "remove panel" Dashboard flows to the new panel storage format

Authored by epriestley on Apr 12 2019, 6:29 PM.
Referenced Files
F13461001: D20408.diff
Mon, Jul 15, 11:56 AM
F13400095: D20408.diff
Thu, Jul 4, 10:52 AM
F13385289: D20408.id48697.diff
Sun, Jun 30, 11:05 PM
F13380521: D20408.id48697.diff
Sat, Jun 29, 2:57 PM
F13379188: D20408.diff
Sat, Jun 29, 5:44 AM
F13365226: D20408.id48715.diff
Wed, Jun 26, 1:42 PM
F13357040: D20408.diff
Mon, Jun 24, 10:37 PM
F13348069: D20408.id48715.diff
Sat, Jun 22, 4:47 PM



Depends on D20407. Ref T13272. This updates the "add panel" (which has two flavors: "add existing" and "create new") and "remove panel" flows to work with the new duplicate-friendly storage format.

  • We now modify panels by "panelKey", not by panel PHID, so one dashboard may have multiple copies of the same panel and we can still figure out what's going on.
  • We now work with "contextPHID", not "dashboardID", to make some flows with tab panels (or other nested panels in the future) easier.

The only major remaining flow is the Javascript "move panels around with drag-and-drop" flow.

Test Plan
  • Added panels to a dashboard with "Create New Panel".
  • Added panels to a dashboard with "Add Existing Panel".
  • Removed panels from a dashboard.
  • Added and removed duplicate panels, got a correctly-functioning dashboard that didn't care about duplicates.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable