Depends on D20005. I love icons.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- mfa5
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21626 Build 29484: Run Core Tests Build 29483: arc lint + arc unit
Event Timeline
| src/applications/settings/panel/PhabricatorTokensSettingsPanel.php | ||
|---|---|---|
| 13–15 | This is the only one I'm a little on the fence about, but I guess you're trying to make these unique and you don't want to re-use fa-key? Maybe fa-clock would work better? This is 100% USDA-certified bike shedding, but I feel like fa-hourglass connotes a thing that the user is waiting on to finish so they can get back to work, not a thing that is already good to go. | |
Comment Actions
Yeah, v1 of this had nine copies of fa-key and that didn't feel great. I'll fish around for something else, maybe fa-ticket.