Page MenuHomePhabricator

Add icons to Settings
ClosedPublic

Authored by epriestley on Jan 21 2019, 6:32 PM.

Details

Summary

Depends on D20005. I love icons.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 21 2019, 6:32 PM
epriestley requested review of this revision.Jan 21 2019, 6:34 PM
amckinley accepted this revision.Jan 21 2019, 6:41 PM
amckinley added inline comments.
src/applications/settings/panel/PhabricatorTokensSettingsPanel.php
13–15

This is the only one I'm a little on the fence about, but I guess you're trying to make these unique and you don't want to re-use fa-key? Maybe fa-clock would work better? This is 100% USDA-certified bike shedding, but I feel like fa-hourglass connotes a thing that the user is waiting on to finish so they can get back to work, not a thing that is already good to go.

This revision is now accepted and ready to land.Jan 21 2019, 6:41 PM

Yeah, v1 of this had nine copies of fa-key and that didn't feel great. I'll fish around for something else, maybe fa-ticket.

This revision was automatically updated to reflect the committed changes.