Paths

Table of Contentst

Differential D20006

Add icons to Settings
ClosedPublic
Actions

Authored by epriestley on Jan 21 2019, 6:32 PM.

Tags

None

Referenced Files

	F18849648: D20006.id47807.diff
	Thu, Oct 30, 11:09 AM

	F18844480: D20006.diff
	Wed, Oct 29, 5:44 AM

	F18835465: D20006.id.diff
	Sun, Oct 26, 3:58 PM

	F18830789: D20006.diff
	Sat, Oct 25, 8:48 AM

	F18830333: D20006.id.diff
	Sat, Oct 25, 6:18 AM

	F18808977: D20006.id47770.diff
	Sun, Oct 19, 10:11 AM

	F18784619: D20006.id47764.diff
	Mon, Oct 13, 1:37 PM

	F18630591: D20006.id47807.diff
	Sep 16 2025, 12:07 PM

Subscribers

None

Details

Reviewers

Commits

rPd6d93dd65822: Add icons to Settings

Summary

Depends on D20005. I love icons.

Test Plan

Screen Shot 2019-01-21 at 10.31.38 AM.png (1×1 px, 291 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 21 2019, 6:32 PM

Harbormaster completed remote builds in B21620: Diff 47764.Jan 21 2019, 6:34 PM

epriestley requested review of this revision.Jan 21 2019, 6:34 PM

amckinley accepted this revision.Jan 21 2019, 6:41 PM

amckinley added inline comments.

src/applications/settings/panel/PhabricatorTokensSettingsPanel.php
13–15	This is the only one I'm a little on the fence about, but I guess you're trying to make these unique and you don't want to re-use `fa-key`? Maybe `fa-clock` would work better? This is 100% USDA-certified bike shedding, but I feel like `fa-hourglass` connotes a thing that the user is waiting on to finish so they can get back to work, not a thing that is already good to go.

This revision is now accepted and ready to land.Jan 21 2019, 6:41 PM

Yeah, v1 of this had nine copies of fa-key and that didn't feel great. I'll fish around for something else, maybe fa-ticket.

Swap hourglass icon for ticket icon.

Harbormaster completed remote builds in B21626: Diff 47770.Jan 21 2019, 8:14 PM

Closed by commit rPd6d93dd65822: Add icons to Settings (authored by epriestley). · Explain WhyJan 23 2019, 9:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

settings/

PhabricatorConduitTokensSettingsPanel.php

4 lines

diffusion/

panel/

DiffusionSetPasswordSettingsPanel.php

4 lines

oauthserver/

panel/

PhabricatorOAuthServerAuthorizationsSettingsPanel.php

4 lines

settings/

controller/

PhabricatorSettingsMainController.php

6 lines

panel/

PhabricatorActivitySettingsPanel.php

4 lines

PhabricatorConpherencePreferencesSettingsPanel.php

4 lines

PhabricatorContactNumbersSettingsPanel.php

4 lines

PhabricatorDateTimeSettingsPanel.php

4 lines

PhabricatorDeveloperPreferencesSettingsPanel.php

4 lines

PhabricatorDiffPreferencesSettingsPanel.php

4 lines

PhabricatorDisplayPreferencesSettingsPanel.php

4 lines

PhabricatorEmailAddressesSettingsPanel.php

4 lines

PhabricatorEmailDeliverySettingsPanel.php

4 lines

PhabricatorEmailFormatSettingsPanel.php

15 lines

PhabricatorEmailPreferencesSettingsPanel.php

4 lines

PhabricatorExternalAccountsSettingsPanel.php

4 lines

PhabricatorLanguageSettingsPanel.php

4 lines

PhabricatorMultiFactorSettingsPanel.php

4 lines

PhabricatorNotificationsSettingsPanel.php

4 lines

PhabricatorPasswordSettingsPanel.php

4 lines

PhabricatorSSHKeysSettingsPanel.php

4 lines

PhabricatorSessionsSettingsPanel.php

4 lines

PhabricatorSettingsPanel.php

10 lines

PhabricatorTokensSettingsPanel.php

4 lines

Diff 47807

src/applications/conduit/settings/PhabricatorConduitTokensSettingsPanel.php

Loading...

src/applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php

Loading...

src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php

Loading...

src/applications/settings/controller/PhabricatorSettingsMainController.php

Loading...

src/applications/settings/panel/PhabricatorActivitySettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorContactNumbersSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorDeveloperPreferencesSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorDiffPreferencesSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorEmailDeliverySettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorEmailFormatSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorEmailPreferencesSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorLanguageSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorSettingsPanel.php

Loading...

src/applications/settings/panel/PhabricatorTokensSettingsPanel.php

Loading...