Page MenuHomePhabricator

Add a rate limit for enroll attempts when adding new MFA configurations
ClosedPublic

Authored by epriestley on Wed, Jan 23, 3:29 PM.

Details

Summary

Depends on D20018. Ref T13222. When you add a new MFA configuration, you can technically (?) guess your way through it with brute force. It's not clear why this would ever really be useful (if an attacker can get here and wants to add TOTP, they can just add TOTP!) but it's probably bad, so don't let users do it.

This limit is fairly generous because I don't think this actually part of any real attack, at least today with factors we're considering.

Test Plan
  • Added TOTP, guessed wrong a ton of times, got rate limited.
  • Added TOTP, guessed right, got a TOTP factor configuration added to my account.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jan 23, 3:29 PM
epriestley requested review of this revision.Wed, Jan 23, 3:31 PM
amckinley accepted this revision.Wed, Jan 23, 6:57 PM
This revision is now accepted and ready to land.Wed, Jan 23, 6:57 PM
This revision was automatically updated to reflect the committed changes.