Page MenuHomePhabricator

Expand "Settings" UI to full-width
ClosedPublic

Authored by epriestley on Jan 21 2019, 6:03 PM.

Details

Summary

Depends on D19988. See D19826 for the last UI expansion. I don't have an especially strong product rationale for un-fixed-width'ing Settings since it doesn't suffer from the "mystery meat actions" issues that other fixed-width UIs do, but I like the full-width UI better and the other other fixed-width UIs all (?) have some actual rationale (e.g., large tables, multiple actions on subpanels), so "consistency" is an argument here.

Also rename "account" to "language" since both settings are language-related.

This moves away from the direction in D18436.

Test Plan

Clicked each Settings panel, saw sensible rendering at full-width.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 21 2019, 6:03 PM
epriestley requested review of this revision.Jan 21 2019, 6:05 PM
amckinley accepted this revision.Jan 21 2019, 6:16 PM
This revision is now accepted and ready to land.Jan 21 2019, 6:16 PM
This revision was automatically updated to reflect the committed changes.