Page MenuHomePhabricator

Expand "Settings" UI to full-width
ClosedPublic

Authored by epriestley on Jan 21 2019, 6:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:34 PM
Unknown Object (File)
Tue, Dec 10, 4:39 AM
Unknown Object (File)
Sun, Dec 8, 5:20 AM
Unknown Object (File)
Fri, Dec 6, 12:27 PM
Unknown Object (File)
Mon, Dec 2, 3:55 PM
Unknown Object (File)
Thu, Nov 28, 1:26 PM
Unknown Object (File)
Sat, Nov 23, 5:22 PM
Unknown Object (File)
Sat, Nov 23, 4:44 AM
Subscribers
None

Details

Summary

Depends on D19988. See D19826 for the last UI expansion. I don't have an especially strong product rationale for un-fixed-width'ing Settings since it doesn't suffer from the "mystery meat actions" issues that other fixed-width UIs do, but I like the full-width UI better and the other other fixed-width UIs all (?) have some actual rationale (e.g., large tables, multiple actions on subpanels), so "consistency" is an argument here.

Also rename "account" to "language" since both settings are language-related.

This moves away from the direction in D18436.

Test Plan

Clicked each Settings panel, saw sensible rendering at full-width.

Screen Shot 2019-01-21 at 9.50.49 AM.png (1×1 px, 270 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable