HomePhabricator

Expand "Settings" UI to full-width

Description

Expand "Settings" UI to full-width

Summary:
Depends on D19988. See D19826 for the last UI expansion. I don't have an especially strong product rationale for un-fixed-width'ing Settings since it doesn't suffer from the "mystery meat actions" issues that other fixed-width UIs do, but I like the full-width UI better and the other other fixed-width UIs all (?) have some actual rationale (e.g., large tables, multiple actions on subpanels), so "consistency" is an argument here.

Also rename "account" to "language" since both settings are language-related.

This moves away from the direction in D18436.

Test Plan:
Clicked each Settings panel, saw sensible rendering at full-width.

Screen Shot 2019-01-21 at 9.50.49 AM.png (1×1 px, 270 KB)

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20005

Details

Provenance
epriestleyAuthored on Jan 21 2019, 5:50 PM
epriestleyPushed on Jan 23 2019, 9:40 PM
Reviewer
amckinley
Differential Revision
D20005: Expand "Settings" UI to full-width
Parents
rPf0c6ee48233a: Add "Contact Numbers" so we can send users SMS mesages
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21659
Build 29541: Run Core Tests