Give "MetaMTAMail" a "message type" and support SMS
ClosedPublic
Actions

Authored by epriestley on Jan 21 2019, 11:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T920: Provide SMS Support

Commits

rPaf71c51f0a0b: Give "MetaMTAMail" a "message type" and support SMS

Summary

Depends on D20011. Ref T920. This change lets a "MetaMTAMail" storage object represent various different types of messages, and makes "all" the bin/mail stuff "totally work" with messages of non-email types.

In practice, a lot of the related tooling needs some polish/refinement, but the basics work.

Test Plan

Used echo beep boop | bin/mail send-test --to epriestley --type sms to send myself SMS.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 21 2019, 11:12 PM

Harbormaster completed remote builds in B21632: Diff 47776.Jan 21 2019, 11:14 PM

epriestley requested review of this revision.Jan 21 2019, 11:14 PM

epriestley added a child revision: D20013: Make the "Test" adapter support both SMS and email.Jan 21 2019, 11:17 PM

amckinley accepted this revision.Jan 22 2019, 12:08 AM

amckinley added inline comments.

src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53	Shouldn't this be impossible? I haven't checked to see if we automatically make the first number added a primary or not, though.

This revision is now accepted and ready to land.Jan 22 2019, 12:08 AM

epriestley added inline comments.Jan 22 2019, 12:11 AM

src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53	This one is possible: just don't add any contact numbers to your account. (Technically, this should become part of whether or not the actor is "deliverable" in a future change, but this is just getting a baseline working.) The one below is "impossible" but enterprising users can go `uPdAtE TaBlE sET ...`.