Page MenuHomePhabricator

Give "MetaMTAMail" a "message type" and support SMS
ClosedPublic

Authored by epriestley on Mon, Jan 21, 11:12 PM.

Details

Summary

Depends on D20011. Ref T920. This change lets a "MetaMTAMail" storage object represent various different types of messages, and makes "all" the bin/mail stuff "totally work" with messages of non-email types.

In practice, a lot of the related tooling needs some polish/refinement, but the basics work.

Test Plan

Used echo beep boop | bin/mail send-test --to epriestley --type sms to send myself SMS.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Jan 21, 11:12 PM
epriestley requested review of this revision.Mon, Jan 21, 11:14 PM
amckinley accepted this revision.Tue, Jan 22, 12:08 AM
amckinley added inline comments.
src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53

Shouldn't this be impossible? I haven't checked to see if we automatically make the first number added a primary or not, though.

This revision is now accepted and ready to land.Tue, Jan 22, 12:08 AM
epriestley added inline comments.Tue, Jan 22, 12:11 AM
src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53

This one is possible: just don't add any contact numbers to your account.

(Technically, this should become part of whether or not the actor is "deliverable" in a future change, but this is just getting a baseline working.)

The one below is "impossible" but enterprising users can go uPdAtE TaBlE sET ....

This revision was automatically updated to reflect the committed changes.