Page MenuHomePhabricator

Give "MetaMTAMail" a "message type" and support SMS
ClosedPublic

Authored by epriestley on Jan 21 2019, 11:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 4, 4:22 AM
Unknown Object (File)
Fri, Jul 29, 2:17 PM
Unknown Object (File)
Thu, Jul 21, 10:07 PM
Unknown Object (File)
Mon, Jul 18, 8:11 AM
Unknown Object (File)
Sat, Jul 16, 8:08 PM
Unknown Object (File)
Jul 16 2022, 8:35 AM
Unknown Object (File)
Jul 16 2022, 7:46 AM
Unknown Object (File)
Jul 14 2022, 11:21 PM
Subscribers
None

Details

Summary

Depends on D20011. Ref T920. This change lets a "MetaMTAMail" storage object represent various different types of messages, and makes "all" the bin/mail stuff "totally work" with messages of non-email types.

In practice, a lot of the related tooling needs some polish/refinement, but the basics work.

Test Plan

Used echo beep boop | bin/mail send-test --to epriestley --type sms to send myself SMS.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53

Shouldn't this be impossible? I haven't checked to see if we automatically make the first number added a primary or not, though.

This revision is now accepted and ready to land.Jan 22 2019, 12:08 AM
src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53

This one is possible: just don't add any contact numbers to your account.

(Technically, this should become part of whether or not the actor is "deliverable" in a future change, but this is just getting a baseline working.)

The one below is "impossible" but enterprising users can go uPdAtE TaBlE sET ....

This revision was automatically updated to reflect the committed changes.