Page MenuHomePhabricator
Differential D20026

Add a Duo API future
ClosedPublic
Actions

Authored by epriestley on Jan 23 2019, 9:33 PM.
Tags
None
Referenced Files
F14755596: D20026.id47802.diff
Tue, Jan 21, 4:05 PM
F14751270: D20026.id.diff
Tue, Jan 21, 12:29 PM
Unknown Object (File)
Sat, Jan 18, 2:23 PM
Unknown Object (File)
Sat, Jan 18, 12:40 AM
Unknown Object (File)
Mon, Jan 13, 3:55 PM
Unknown Object (File)
Wed, Jan 1, 4:25 AM
Unknown Object (File)
Dec 5 2024, 10:41 AM
Unknown Object (File)
Dec 3 2024, 2:10 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13231: Duo MFA Support
Commits
rP069160404fe8: Add a Duo API future
Summary

Depends on D20025. Ref T13231. Although I'm not currently planning to actually upstream a Duo MFA provider, it's probably easiest to put most of the support pieces in the upstream until T5055.

Test Plan

Used a test script to make some (mostly trivial) API calls and got valid results back, so I think the parameter signing is correct.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 23 2019, 9:33 PM
Harbormaster completed remote builds in B21655: Diff 47802.Jan 23 2019, 9:35 PM
epriestley requested review of this revision.Jan 23 2019, 9:35 PM
epriestley added inline comments.Jan 23 2019, 9:36 PM
src/applications/metamta/future/PhabricatorTwilioFuture.php
61

This was a leftover from implementing the thing, setPath() wiped it out. I caught it while COPY/PASTING CODE HA HA HA

amckinley accepted this revision.Jan 24 2019, 7:08 PM
This revision is now accepted and ready to land.Jan 24 2019, 7:08 PM
epriestley added a child revision: D20028: Add CSRF to SMS challenges, and pave the way for more MFA types (including Duo).Jan 24 2019, 10:21 PM
Closed by commit rP069160404fe8: Add a Duo API future (authored by epriestley). · Explain WhyJan 24 2019, 11:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
future/
150 lines
metamta/
future/
2 lines

Diff 47834

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/future/PhabricatorDuoFuture.php

Loading...
View Options

src/applications/metamta/future/PhabricatorTwilioFuture.php

Loading...
Phabricator · Built by Phacility