Page MenuHomePhabricator

Add a Duo API future
ClosedPublic

Authored by epriestley on Jan 23 2019, 9:33 PM.

Details

Summary

Depends on D20025. Ref T13231. Although I'm not currently planning to actually upstream a Duo MFA provider, it's probably easiest to put most of the support pieces in the upstream until T5055.

Test Plan

Used a test script to make some (mostly trivial) API calls and got valid results back, so I think the parameter signing is correct.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 23 2019, 9:33 PM
epriestley requested review of this revision.Jan 23 2019, 9:35 PM
epriestley added inline comments.Jan 23 2019, 9:36 PM
src/applications/metamta/future/PhabricatorTwilioFuture.php
61

This was a leftover from implementing the thing, setPath() wiped it out. I caught it while COPY/PASTING CODE HA HA HA

amckinley accepted this revision.Jan 24 2019, 7:08 PM
This revision is now accepted and ready to land.Jan 24 2019, 7:08 PM
This revision was automatically updated to reflect the committed changes.