Page MenuHomePhabricator
Differential D20010

Allow contact numbers to be enabled and disabled
ClosedPublic
Actions

Authored by epriestley on Jan 21 2019, 8:52 PM.
Tags
None
Referenced Files
F15422358: D20010.id47779.diff
Sat, Mar 22, 7:41 AM
F15390123: D20010.id47809.diff
Sat, Mar 15, 5:55 AM
F15344845: D20010.id47774.diff
Mon, Mar 10, 6:59 AM
F15336082: D20010.diff
Sat, Mar 8, 6:13 PM
Unknown Object (File)
Mon, Feb 24, 6:15 PM
Unknown Object (File)
Feb 22 2025, 7:23 PM
Unknown Object (File)
Feb 11 2025, 12:26 AM
Unknown Object (File)
Feb 11 2025, 12:18 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T920: Provide SMS Support
Commits
rP12203762b7f0: Allow contact numbers to be enabled and disabled
Summary

Depends on D20008. Ref T920. Continue fleshing out contact number behaviors.

Test Plan
  • Enabled and disabled a contact number.
  • Saw list, detail views reflect change.
  • Added number X, disabled it, added it again (allowed), enabled the disabled one ("already in use" exception).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 21 2019, 8:52 PM
Harbormaster completed remote builds in B21630: Diff 47774.Jan 21 2019, 8:54 PM
epriestley requested review of this revision.Jan 21 2019, 8:54 PM
epriestley added a child revision: D20011: Support designating a contact number as "primary".Jan 21 2019, 10:32 PM
amckinley accepted this revision.Jan 21 2019, 10:40 PM
amckinley added inline comments.
src/applications/auth/xaction/PhabricatorAuthContactNumberStatusTransaction.php
18

Unused variable.

This revision is now accepted and ready to land.Jan 21 2019, 10:40 PM
epriestley updated this revision to Diff 47779.Jan 22 2019, 12:01 AM
  • Prune unused variable.
Harbormaster completed remote builds in B21635: Diff 47779.Jan 22 2019, 12:02 AM
Closed by commit rP12203762b7f0: Allow contact numbers to be enabled and disabled (authored by epriestley). · Explain WhyJan 23 2019, 10:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47809

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/auth/controller/contact/PhabricatorAuthContactNumberDisableController.php

Loading...
View Options

src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthContactNumber.php

Loading...
View Options

src/applications/auth/xaction/PhabricatorAuthContactNumberStatusTransaction.php

Loading...
Phabricator · Built by Phacility