Page MenuHomePhabricator

Allow contact numbers to be enabled and disabled
ClosedPublic

Authored by epriestley on Mon, Jan 21, 8:52 PM.

Details

Summary

Depends on D20008. Ref T920. Continue fleshing out contact number behaviors.

Test Plan
  • Enabled and disabled a contact number.
  • Saw list, detail views reflect change.
  • Added number X, disabled it, added it again (allowed), enabled the disabled one ("already in use" exception).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Jan 21, 8:52 PM
epriestley requested review of this revision.Mon, Jan 21, 8:54 PM
amckinley accepted this revision.Mon, Jan 21, 10:40 PM
amckinley added inline comments.
src/applications/auth/xaction/PhabricatorAuthContactNumberStatusTransaction.php
18

Unused variable.

This revision is now accepted and ready to land.Mon, Jan 21, 10:40 PM
  • Prune unused variable.
This revision was automatically updated to reflect the committed changes.