Page MenuHomePhabricator

Correct an issue where the default "Settings" screen could show the wrong settings
ClosedPublic

Authored by epriestley on Jan 23 2019, 2:46 PM.

Details

Summary

Depends on D20013. Recently, I renamed the "Account" panel to "Language".

When you land on "Settings" and the first panel is an "EditEngine" panel ("Account/Langauge", "Date and Time", and "Conpherence" are all "EditEngine" panels), the engine shows the controls for the first panel.

However, the "first panel" according to EditEngine and the "first panel" in the menu are currently different: the menu groups panels into topics.

When I renamed "Account" to "Language", it went from conicidentally being the first panel in both lists to being the second panel in the grouped menu list and the, uh, like 12th panel in the ungrouped raw list.

This made landing on "Settings" show you the right chrome, but show you a different panel's controls ("Conpherence", now alphabetically first).

Instead, use the same order in both places.

(This was also a pre-existing bug if you use a language which translates the panel names such that "Account" is not alphabetically first.)

Test Plan

Visited "Settings", saw "Date & Time" form controls instead of "Conpherence" form controls on the default screen with "Date & Time" selected in the menu.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 23 2019, 2:46 PM
epriestley requested review of this revision.Jan 23 2019, 2:48 PM
epriestley retitled this revision from Correct an issue where the defualt "Settings" screen could show the wrong settings to Correct an issue where the default "Settings" screen could show the wrong settings.Jan 23 2019, 3:09 PM
amckinley accepted this revision.Jan 23 2019, 6:02 PM
This revision is now accepted and ready to land.Jan 23 2019, 6:02 PM
This revision was automatically updated to reflect the committed changes.