Paths

Table of Contentst

Differential D19322

Modularize Almanac Network transactions
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 12:21 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rP580409b5628d: Modularize Almanac Network transactions

Summary

Depends on D19321. Ref T13120. Ref T12414. Move transactions for Almanac Networks (just "name") to ModularTransactions.

Test Plan

Created a new network.
Renamed a network.
Tried to create a network with no name (got an error).
Grepped for AlmanacNetworkTransaction::.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 10 2018, 12:21 PM

epriestley edited the test plan for this revision. (Show Details)Apr 10 2018, 12:21 PM

Harbormaster completed remote builds in B20052: Diff 46228.Apr 10 2018, 12:22 PM

epriestley requested review of this revision.Apr 10 2018, 12:22 PM

epriestley added a child revision: D19323: Add skeleton code for Almanac Interfaces to have real transactions.Apr 10 2018, 12:57 PM

amckinley accepted this revision.Apr 10 2018, 3:52 PM

This revision is now accepted and ready to land.Apr 10 2018, 3:52 PM

Closed by commit rP580409b5628d: Modularize Almanac Network transactions (authored by epriestley). · Explain WhyApr 11 2018, 5:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

almanac/

editor/

AlmanacNetworkEditEngine.php

2 lines

AlmanacNetworkEditor.php

88 lines

storage/

AlmanacNetworkTransaction.php

26 lines

xaction/

AlmanacNetworkNameTransaction.php

44 lines

AlmanacNetworkTransactionType.php

4 lines

Diff 46263

View Options

src/__phutil_library_map__.php

View Options

src/applications/almanac/editor/AlmanacNetworkEditEngine.php

View Options

src/applications/almanac/editor/AlmanacNetworkEditor.php

View Options

src/applications/almanac/storage/AlmanacNetworkTransaction.php

View Options

src/applications/almanac/xaction/AlmanacNetworkNameTransaction.php

View Options

src/applications/almanac/xaction/AlmanacNetworkTransactionType.php

Modularize Almanac Network transactionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46263

src/__phutil_library_map__.php

src/applications/almanac/editor/AlmanacNetworkEditEngine.php

src/applications/almanac/editor/AlmanacNetworkEditor.php

src/applications/almanac/storage/AlmanacNetworkTransaction.php

src/applications/almanac/xaction/AlmanacNetworkNameTransaction.php

src/applications/almanac/xaction/AlmanacNetworkTransactionType.php

Modularize Almanac Network transactions
ClosedPublic
Actions

Revision Contents
Changeset List