Page MenuHomePhabricator
Differential D19322

Modularize Almanac Network transactions
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 12:21 PM.
Tags
None
Referenced Files
F15524496: D19322.id46263.diff
Mon, Apr 21, 8:25 AM
F15524183: D19322.id46228.diff
Mon, Apr 21, 6:28 AM
F15518972: D19322.id46263.diff
Sat, Apr 19, 6:37 PM
F15514976: D19322.diff
Fri, Apr 18, 7:08 AM
F15479644: D19322.id46263.diff
Tue, Apr 8, 8:33 AM
F15477514: D19322.id46228.diff
Mon, Apr 7, 3:37 PM
F15459026: D19322.id.diff
Mon, Mar 31, 9:12 AM
F15459025: D19322.id46228.diff
Mon, Mar 31, 9:11 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content
Commits
rP580409b5628d: Modularize Almanac Network transactions
Summary

Depends on D19321. Ref T13120. Ref T12414. Move transactions for Almanac Networks (just "name") to ModularTransactions.

Test Plan
  • Created a new network.
  • Renamed a network.
  • Tried to create a network with no name (got an error).
  • Grepped for AlmanacNetworkTransaction::.

Diff Detail

Repository
rP Phabricator
Branch
almanac7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20052
Build 27196: Run Core Tests
Build 27195: arc lint + arc unit

Revision Contents
Changeset List

Diff 46228

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/editor/AlmanacNetworkEditEngine.php

Loading...
View Options

src/applications/almanac/editor/AlmanacNetworkEditor.php

Loading...
View Options

src/applications/almanac/storage/AlmanacNetworkTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacNetworkNameTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacNetworkTransactionType.php

Loading...
Phabricator · Built by Phacility