Thank you very much!

The "Clowncopterize" button was a huge roadblock to adopting code reviews in Differential in our organization. The engineers refused to press it, opting instead of just email each other in the email Phabricator sent out when the Diff was created. Everyone was confused about what it did, and were too conservative to take the risk. We had to hire a PHP outsourcing company in Indiana to patch our deploy so the button instead displayed "Comment".

Is there an expected date when this change will be safe for production use? That red warning bar at the top of the summary is very intimidating, though I want to keep our instance responsibly close to the edge (should I just use stable?).

I definitely get that it's a prototype and I know not to file bugs against prototypes, but this interaction wasn't directly with Almanac but with a core Diffusion feature. Diffusion shouldn't use Almanac unless explicitly set to use it. 

Yea, I figured it was more on us. Their reason is:

Boss-person insists on auto-emailing all of eng for every bit of activity on our install, so we've had to create a ton of email filters. However every so often mail that should've passed gets scrapped, and it's different for every person. Some people cannot deal with the deluge of email and just direct all phab email to the trash.

Oh! I didn't notice the prototype tag all the way on the right (we have really wide monitors). That is totally fair. Apologies for wasting your time on prototype bugs.

@chad: Not even eventually?

I don't know enough PHP to really get what this app is doing, but I imagined some smart folks at Phacility had created a generic commenting service and I was just not seeing it. Thanks for the help!

remove leading / as it was getting trimmed anyway

yup: https://secure.phabricator.com/diffusion/P/browse/master/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php;b24935df2f74006c8221ee934c3d06b0781ac70b$48

Thankfully clicking the notifications opens a dropdown with "undefined" in it. Maybe tagging with Security was overzealous but every MFA screen I've ever encountered showed no data from the underlying system. At worst it just looks sloppy since half of the features don't return useful data, the custom logo disappears (it's not accessible, therefore doesn't return), etc. Also, like @Lavoaster points out, there could be info in saved searches. This isn't huge, just something that should be fixed eventually.

strangely enough that config is already there. Maybe it's a linter bug?

Better, @avivey?

• add tests to check go test parser against go 1.4 test result format