Page MenuHomePhabricator

ArcanistGoTestResultParser incorrectly parses go test results for Go 1.4
Closed, ResolvedPublic

Description

When using the ArcanistGoTestResultParser to parse the output of running go test ... -v, the resulting output doesn't contain the test function's name that failed, just the package. This leads to a useless output which requires running go test manually. This has been observed in Go 1.4.2. The problem is that the regex used to capture the time the test took to execute expects a format like (24 seconds), whereas the go test output is now (24s). The old format can be seen in this youtube clip about writing go code, and the page that references that clip now has the "modern" format. The easiest way to support both is to modify the regex in the parseTestResults method of ArcanistGoTestResultParser to be able to support either format.