The default Go Test Parser stopped showing the test function name at the end of the package after some Go upgrade. We fixed it locally and wanted to share it upstream.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7845: ArcanistGoTestResultParser incorrectly parses go test results for Go 1.4
- Commits
- rARCa9ebe1cb4ffc: allow either (<time> seconds) or (<time>s) format for test result time
- Required Signatures
L28 Phacility Individual Contributor License Agreement
We ran it on our test suite using go1.4.2 darwin/amd64. We have version-dependent code which cannot be compiled with earlier versions of Go, unfortunately.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
There's a bunch of test cases in https://secure.phabricator.com/diffusion/ARC/browse/master/src/unit/parser/__tests__/testresults/ (With a test runner in https://secure.phabricator.com/diffusion/ARC/browse/master/src/unit/parser/__tests__/ArcanistGoTestResultParserTestCase.php).
Can you add one or two for this change?
Comment Actions
You should mark these files as allowing tabs in .editorconfig to clear lint. I think a block like this will do it:
[src/unit/parser/__tests__/testresults/go.*] indent_style =