So this would work in theory, but the problem is that the buildNavigation() method in PhabricatorProfileMenuEngine.php is called twice. The first time, the selection is properly set, but the second time around, it's reset back to the original buggy behavior. Wanted to know if I'm generally in the right direction or if I should pivot before it's too late.

Make ambiguous commit identifier bold in the warning message

• The commit identifier in the warning message isn't bold... should it be?
• The repository/branch in the crumbs isn't a link... should it be? I looked at the crumbs code a bit and I think I'd have to add a new parameter to pass to crumbs so that we can have a link without a branch appended to it.

Conforming to best practices for commit lists

@epriestley what do you think of creating another column in the calendar_eventinvitee table, something like a bool futureStatus so that when we get a list of invitees back, we can check for that flag. I think this would mean a lot of date comparisons (seems inefficient), and I'm not quite sure when to populate event stubs. For example, if the futureStatus flag is set to true for instance 10, and there are stubs for instances 15 and 20, when would 15 and 20 get converted to have the updated status?

Query for events that were not cancelled instead of filtering out cancelled events later.

This fixed the border on the panel:

Css change to make week preview on day view border better

This particular change was for testing and doesn't seem right anyways.

A few possible directions:

Yeah, I think the dialog should clarify.

I just think it might not look pretty on standard resolutions (like my Mac)

Alternatively, we can make reinstating a series un-cancel all cancelled instances. That would make some sense to me.

"Cancel All Recurrences" works because it will keep already cancelled instances that way. When you reinstate the series, all the individually cancelled instances won't be un-cancelled, so "Reinstate All Instances" doesn't really cover it. It should be more like "Reinstate All Previously Un-cancelled Instances". How would we put that succinctly?

celerity

cleanup

celery sticks

oops, wrong direction

Fixing where new behavior is initialized

Correct way to specify the link color for badge view?

Specifying awards query in badges datasource