Addressing some PHP8 incompatibilities - ProfileMenuItem

Summary:
Updates to all of the ProfileMenuItem classes to be compatible with PHP 8.

These changes were moved from D21862.

Refs T13588

Test Plan:
I loaded the profile page for a user and saw all the items I expected to see.
I navigated through the different profile nav items.
I loaded the settings page for a user and saw all the items I expected to see.
I navigated through the differnt setting nave items.
I added Cat Facts to my navigation.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21863