HomePhabricator

Fix support for pk-zip compressed figlet font files

Description

Fix support for pk-zip compressed figlet font files

Summary: The change from https://secure.phabricator.com/D21860 introduced a PHP error due to an invalid variable reference (zip instead of $zip). This fixes that issue as well as confirms that pk-zip compressed figlet font files can continue to be used/loaded.

Test Plan:

  1. I ensured I had numerous figlet font files installed in resources/figlet/custom and used file to verify that univers.flf and puffy.flf are pk-zip archives.
  2. With this change applied I added a comment with figlet(font=univers){{{hello}}} and verified that the comment used the univers font to render hello, and like-wise with the puffy font.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D21861

Details

Provenance
cspeckmimAuthored on Apr 25 2023, 3:31 PM
cspeckmimPushed on Apr 25 2023, 8:30 PM
Reviewer
Blessed Reviewers
Differential Revision
D21861: Fix support for pk-zip compressed figlet font files
Parents
rPd5c63c86e7e4: Update Figlet implementation to be PHP8 compatible
Branches
Unknown
Tags
Unknown