Page MenuHomePhabricator
Create Task
Maniphest T4774

"Pending Differential Revisions" not displaying in when browsing repository
Closed, ResolvedPublic
Actions

Description

If I look at this instance, for example, https://secure.phabricator.com/diffusion/P/browse/master/, there is a "Pending Differential Revisions" section. When I look at my instance, I see no such section. The URL I'm using (though it's not internet-accessible) is http://phabricator.macprofessionals.lan/diffusion/PPHAB/browse/master/

I'm pretty sure there are indeed pending differential revisions for that repo. I can get to it by looking at revisions "waiting on others", then follow the repository link, then click "Browse Repository". The only obvious difference I see is that rP is "Public", while rPPHAB on my instance is visible to "All Users".

Revisions and Commits

rP Phabricator
D8757rPcb675a46a24d Differential - fix bug writing affected paths

Event Timeline

• bitglue created this task.Apr 8 2014, 9:42 PM
• bitglue raised the priority of this task from to Needs Triage.
• bitglue updated the task description. (Show Details)
• bitglue added a project: Phabricator.
• bitglue added a subscriber: • bitglue.
btrahan claimed this task.Apr 11 2014, 12:58 AM
btrahan edited this Maniphest Task.Apr 11 2014, 12:59 AM
btrahan triaged this task as Normal priority.Apr 11 2014, 1:05 AM

This is a symptom of DifferentialAffectedPath rows not being written for diffs against repositories where the arcanist project is not configured to know about the repository. The bug exists because we are downplaying the role of arcanist projects and missed a spot. See D8757 for a fix.

Note as D8757 is written you'll only see it fixed for future diffs.
Note it works on secure.phabricator.com because our arcanist projects are configured to point at the pertinent repos. We are working to deprecate this configuration though.

• bitglue added a comment.Apr 11 2014, 5:14 PM

With D8757 applied, I can't arc diff new changes. A log of output with --trace is attached.

btrahan added a comment.Apr 11 2014, 5:16 PM

Do you have the log output?

• bitglue added a comment.Apr 11 2014, 5:16 PM

Also apache error.log attached.

btrahan added a comment.Apr 11 2014, 5:17 PM

These attachments aren't showing up, but I can repro locally.

• bitglue added a subscriber: btrahan.Apr 11 2014, 5:20 PM

@btrahan, I'm setting "Action: Upload File" in the comment box and attaching the file, but it's not showing up. Oddly, the preview says "bitglue changed files, attached: ; detached: ". Guess that's a separate problem. Anyhow, here's the arc output and apache log: https://gist.github.com/bitglue/8c6f53331186577c4bfc

btrahan added a comment.Apr 11 2014, 5:29 PM

i'll take a look at the upload file bug in a minute. :) updated the diff to fix this issue - thanks for the report!

btrahan added a comment.Apr 11 2014, 5:53 PM

(T4655 is the upload file bug)

btrahan edited this Maniphest Task.Apr 11 2014, 7:54 PM
btrahan closed this task as Resolved.Apr 11 2014, 7:54 PM

Closed by commit rPcb675a46a24d.

Phabricator · Built by Phacility