Fixes T4774. With the new code and configuration instructions downplaying the role of arcanist project we weren't writing affected paths at all! I had this issue on my installation - no affected paths were written. We seem to always have the repository now though if we can see it, so not too bad of a fix.
Details
Details
- Reviewers
epriestley • bitglue - Maniphest Tasks
- T4774: "Pending Differential Revisions" not displaying in when browsing repository
- Commits
- Restricted Diffusion Commit
rPcb675a46a24d: Differential - fix bug writing affected paths
updated a diff and was able to browse in diffusion.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Fix bug - in applyFinalEffects (re-)attach the repository to guarantee we always have it. Sometimes the $revision ($object) in question has just been created or otherwise comes via a code path where the repository was improperly attached
Comment Actions
Fixes the problem and doesn't break things for me now. Maybe you want an actual developer like @epriestley to review it also -- I really have no idea why what you changed makes a difference.