Can you reproduce this on this install?

Does reloading fix it?

Reloading does not fix it. I tried to reproduce at D8994, but was unable. I'll try updating my install and see if that changes anything.

Still need to try updating my version. Perhaps a significant difference: I updated the diffs here "via web". On my instance it was done with arc, and it says "via conduit".

Actually, I forgot a key part of what I wrote in my reproduction steps: edit that comment. When I look at D8994, there's no option to edit. On my instance, it seems like I can go back to any revision, edit an inline comment, and it disappears. Why can I edit on mine but not yours?

A weird thing, perhaps relevant to you: the "edit" button is in the conversation at the top, not in the inline view. That doesn't make much sense, really. It especially doesn't make sense when you have multiple inline comments, since there's only one edit but there are multiple comments. It seems in this case, when you click it, it gets "all screwed up". It seems to present the text of the second comment for editting, but when saved, it shows that text in place of the first comment. Then upon reloading, the first comment is gone.

You aren't supposed to be able to edit inline comments right now. The option has moved to the gear menu, but the expectation is that it will work for normal comments but not inlines. If it works for inlines, that's a bug (at some point, we'll put an option on the actual inlines to edit them).

Looks like a working set of repro steps is:

• Make an inline comment, then submit it. Do not submit a normal comment with this transaction.
• Using the gear menu on the transaction group, select "Edit Comment". This should not be available in the UI, but erroneously is.
• Edit the comment. This should be disallowed, but erroneously is permitted.
• Inline breaks/vanishes.

The issue is that this isn't expected to work yet, which is why we supposedly don't expose it in the UI. In practice, we do actually expose it in the UI. I'll pull it out of the UI until the underlying interaction works correctly.

OK...looks like this instance is broken in a slightly different way. Here's what I got when I tried to edit:

Notice how the comment is "A bit redundant, don't you think?", but the text it gave me (I didn't edit it yet!) is "Test more emphatically." Perhaps this is because in this diff, I was also the one doing the updating. The UI suggests that somehow my updating the diff and the comments I made are lumpped together logically into one action.

Not the case in my instance, because I was commenting on someone else's diff.

OK looks like you got it, but I was able to reproduce here at https://secure.phabricator.com/D8994#23. Like you say, seems you must have inline comments without a normal comment.

◀ Merged tasks: T4978.