Page MenuHomePhabricator

Emails and history for Differential prefers "changed subscribers" over "accepted this revision"
Closed, ResolvedPublic

Description

When someone accepts a revision, I get an email that says [Changed Subscribers]. While this isn't false per se, it's far more relevant that the revision was accepted, but I have to read through the body of the email to get that information.

I think what's going on here is that the designated reviewer is a project, and when someone from the project does the review, they (the individual) gets automatically added to the revision, and some other stuff happens. I get an email with all of these things, but "changed subscribers" happens to be first. Here's an example email:

Subject: [Differential] [Changed Subscribers] D40: Create cgi.cfg after installing icinga-cgi

jbowman added a subscriber: jbowman.
jbowman accepted this revision.
jbowman added a reviewer: jbowman.
jbowman added a comment.
This revision is now accepted and ready to land.

Looks good, tests good.

BRANCH
  cgi_ordering

REVISION DETAIL
  http://phabricator.macprofessionals.lan/D40

To: pfrost, mwright, dnorton, jbowman
Cc: jbowman

Similarly, news feeds (in this case, for the user jbowman) say "changed subscribers" rather than the more relevant "accepted":

{F147317}

Event Timeline

bitglue raised the priority of this task from to Needs Triage.
bitglue updated the task description. (Show Details)
bitglue added a project: Differential.
bitglue added a subscriber: bitglue.
epriestley triaged this task as Normal priority.Apr 24 2014, 9:59 PM
epriestley added a subscriber: epriestley.

I think I got 'em all but let me know if you see anything else odd. Thanks for the report!