Page MenuHomePhabricator
Feed All Stories

Sep 12 2017

epriestley created T12981: Explicitly limit lint and unit test names to 255 characters.
Sep 12 2017, 7:08 PM · Harbormaster, Conduit
epriestley added a comment to T12978: Phacility Cluster Maintenance: 2017 Week 37.

Both bak volumes are now swapped. The old volumes are detached as dbak001.phacility.net-old and dbak002.phacility.net-old. I'll delete them after the deployment on Saturday if no issues arise before then.

Sep 12 2017, 6:57 PM · Ops, Phacility
epriestley added a comment to T12917: Move domain name registration and SSL to AWS.

I haven't gotten any emails yet so I may have to go muck with the WHOIS stuff and make sure there's a valid email somewhere -- phurl.io itself has no mail or MX records.

Sep 12 2017, 6:22 PM · Ops, Phacility
epriestley added a comment to T12978: Phacility Cluster Maintenance: 2017 Week 37.

Upgrade dbak001 to 128GB (from 64GB).
Upgrade dbak002 to 128GB (from 64GB).

Sep 12 2017, 6:16 PM · Ops, Phacility
epriestley added a revision to T12978: Phacility Cluster Maintenance: 2017 Week 37: Unknown Object (Differential Revision).
Sep 12 2017, 6:03 PM · Ops, Phacility
epriestley added a comment to T12978: Phacility Cluster Maintenance: 2017 Week 37.

Swap notify001 to notify002 in the LB.

Sep 12 2017, 6:02 PM · Ops, Phacility
epriestley added a comment to T12978: Phacility Cluster Maintenance: 2017 Week 37.

I think this is basically "node is bananas" and our AMI is Ubuntu 14 which ships with "Node for DOS".

Sep 12 2017, 5:57 PM · Ops, Phacility
amckinley added a comment to T12917: Move domain name registration and SSL to AWS.

Just sent a cert request for phurl.io. (Actually it should be two, one for each region).

Sep 12 2017, 5:56 PM · Ops, Phacility
amckinley added a revision to T12917: Move domain name registration and SSL to AWS: Unknown Object (Differential Revision).
Sep 12 2017, 5:52 PM · Ops, Phacility
epriestley added a comment to T12978: Phacility Cluster Maintenance: 2017 Week 37.

I'm bumping into T12171 when bringing up the new host. I'm going to take another stab at figuring out what's going on there because the workaround I found in that task is ridiculous.

Sep 12 2017, 5:50 PM · Ops, Phacility
epriestley added a comment to T12917: Move domain name registration and SSL to AWS.

Switch all SSL to AWS.

Sep 12 2017, 5:42 PM · Ops, Phacility
epriestley added a comment to T12978: Phacility Cluster Maintenance: 2017 Week 37.

Test that moving SSL termination to nlb001 works.

Sep 12 2017, 5:32 PM · Ops, Phacility
epriestley added a comment to T12917: Move domain name registration and SSL to AWS.

Oh, sorry, misread -- that makes more sense. phurl.io is the only one we serve anything from ourselves right now, and I think the only one we have plans to serve anything from.

Sep 12 2017, 5:30 PM · Ops, Phacility
amckinley added a comment to T12917: Move domain name registration and SSL to AWS.

Yeah I'm just talking about requesting the SSL certs, not moving the domains. Unless I'm missing something, I don't think there's any way to get stuck just by getting the certs ready.

Sep 12 2017, 5:25 PM · Ops, Phacility
epriestley added a comment to T12917: Move domain name registration and SSL to AWS.

Let's make sure all the SSL is swapped first just so we don't get into trouble if we make it halfway, run into issues, and something expires, but that's be helpful once SSL is in the clear. I'm not sure if nlb was the last case of SSL terminating somewhere other than LBs or not, but I think there's one left that I just don't remember offhand.

Sep 12 2017, 5:23 PM · Ops, Phacility
amckinley added a comment to T12917: Move domain name registration and SSL to AWS.

I can go request these certs via the AWS cert manager. We can also do it via CloudFormation, which will reduce the number of clicks significantly (and make it trivial to request all the same certs in multiple regions.

Sep 12 2017, 5:20 PM · Ops, Phacility
epriestley added a revision to T12917: Move domain name registration and SSL to AWS: Unknown Object (Differential Revision).
Sep 12 2017, 5:17 PM · Ops, Phacility
epriestley added a revision to T12978: Phacility Cluster Maintenance: 2017 Week 37: Unknown Object (Differential Revision).
Sep 12 2017, 5:17 PM · Ops, Phacility
epriestley updated subscribers of T12978: Phacility Cluster Maintenance: 2017 Week 37.

Replace notify001, which is scheduled for AWS downtime on September 20th.

Sep 12 2017, 5:14 PM · Ops, Phacility
epriestley renamed T12974: Upgrading: "Ferret" Fulltext Engine from Prototype: "Ferret" Fulltext Engine to Upgrading: "Ferret" Fulltext Engine.
Sep 12 2017, 4:14 PM · Installing & Upgrading, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 12 2017, 3:28 PM · Restricted Project, Search
epriestley updated the task description for T11932: Manual Activity: Rebuild Search Index.
Sep 12 2017, 3:25 PM · Search, Guides
epriestley closed T12443: Applying fulltext limits first causes missing results, a subtask of T12974: Upgrading: "Ferret" Fulltext Engine, as Resolved.
Sep 12 2017, 3:09 PM · Installing & Upgrading, Search
epriestley closed T12443: Applying fulltext limits first causes missing results as Resolved.

This is resolved by the Ferret engine, which can execute all parts of the query logic in MySQL.

Sep 12 2017, 3:09 PM · Restricted Project, Search, Bug Report
epriestley closed T6721: Would like ability to search tasks by title as Resolved.

This is resolved by the Ferret engine, using title:...:

Sep 12 2017, 3:08 PM · Search, Maniphest
epriestley closed T6721: Would like ability to search tasks by title, a subtask of T12974: Upgrading: "Ferret" Fulltext Engine, as Resolved.
Sep 12 2017, 3:08 PM · Installing & Upgrading, Search
epriestley closed T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index, a subtask of T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size, as Resolved.
Sep 12 2017, 3:07 PM · Restricted Project, Search
epriestley closed T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index as Resolved.

This is resolved by the Ferret engine:

Sep 12 2017, 3:07 PM · Customer Impact, Search
epriestley closed T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index, a subtask of T12974: Upgrading: "Ferret" Fulltext Engine, as Resolved.
Sep 12 2017, 3:07 PM · Installing & Upgrading, Search
Krinkle removed a watcher for Wikimedia: Krinkle.
Sep 12 2017, 2:57 PM
Krinkle added a member for Wikimedia: Krinkle.
Sep 12 2017, 2:57 PM
Krinkle added a watcher for Wikimedia: Krinkle.
Sep 12 2017, 2:57 PM
ftdysa awarded T12974: Upgrading: "Ferret" Fulltext Engine a Mountain of Wealth token.
Sep 12 2017, 2:54 PM · Installing & Upgrading, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 12 2017, 2:48 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 12 2017, 2:36 PM · Restricted Project, Search
chad updated the task description for T12980: Diffusion search throws exception on older git.
Sep 12 2017, 3:13 AM · Diffusion
chad created T12980: Diffusion search throws exception on older git.
Sep 12 2017, 2:55 AM · Diffusion
chad added a project to T12979: Sticky notifications no longer appear: Notifications.
Sep 12 2017, 2:45 AM · Notifications
epriestley added a comment to T784: Allow Differential changesets to be marked with various attributes.

See also PHI64.

Sep 12 2017, 1:18 AM · Restricted Project, Restricted Project, Restricted Project, Arcanist, Differential

Sep 11 2017

epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:45 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:43 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:38 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:31 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:29 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:21 PM · Restricted Project, Search
chad created T12979: Sticky notifications no longer appear.
Sep 11 2017, 11:19 PM · Notifications
epriestley closed T12932: GC old Differential changesets into File storage as Wontfix.

Per above, not planning to actually go forward with the GC step since the impact isn't ultimately very large.

Sep 11 2017, 11:09 PM · Files, Differential, Phacility, Ops
epriestley added projects to T12978: Phacility Cluster Maintenance: 2017 Week 37: Phacility, Ops.
Sep 11 2017, 11:09 PM · Ops, Phacility
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

From T12932, I don't think it's especially promising as a way forward, so I'm just going take an operations pathway instead (see T12978), so I expect to just move to unprototype the Ferret engine here.

Sep 11 2017, 11:05 PM · Restricted Project, Search
epriestley created T12978: Phacility Cluster Maintenance: 2017 Week 37.
Sep 11 2017, 11:03 PM · Ops, Phacility
eadler added a comment to T12974: Upgrading: "Ferret" Fulltext Engine.

kind of sad this isn't called pherret

Sep 11 2017, 4:29 PM · Installing & Upgrading, Search
epriestley added a comment to T12932: GC old Differential changesets into File storage.

Looking at the actual data, I'm less sure this is actually a good strategy. Here's the data for this install, considering the production configuration of storage.mysql-engine.max-size as 65535:

Sep 11 2017, 4:00 PM · Files, Differential, Phacility, Ops
epriestley added a revision to T12932: GC old Differential changesets into File storage: Unknown Object (Differential Revision).
Sep 11 2017, 3:51 PM · Files, Differential, Phacility, Ops
epriestley added a revision to T12932: GC old Differential changesets into File storage: Unknown Object (Differential Revision).
Sep 11 2017, 3:31 PM · Files, Differential, Phacility, Ops
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

The actual indexes are fairly large (3GB for ~500MB of task data, although lispum tasks have an exceptionally large amount of text).

Sep 11 2017, 12:31 PM · Restricted Project, Search
epriestley added a comment to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).

I expect T12819 will ultimately remove all tables with FULLTEXT indexes, which should moot this.

Sep 11 2017, 12:05 PM
epriestley added a parent task for T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): T12974: Upgrading: "Ferret" Fulltext Engine.
Sep 11 2017, 12:04 PM
epriestley added a subtask for T12974: Upgrading: "Ferret" Fulltext Engine: T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
Sep 11 2017, 12:04 PM · Installing & Upgrading, Search
epriestley closed T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates as Resolved.

bin/storage adjust and bin/storage upgrade now run ANALYZE, unless users opt-out with flags.

Sep 11 2017, 12:04 PM · Infrastructure
epriestley closed T10773: When the search table is marked as crashed, bin/storage should automatically repair it as Wontfix.

We generally stopped seeing this after moving to InnoDB FULLTEXT, which seems less prone to table crashes than MyISAM FULLTEXT was. See also T12819 for the fate of InnoDB FULLTEXT.

Sep 11 2017, 12:02 PM · Database, Feature Request

Sep 10 2017

epriestley edited the content of Changelog.
Sep 10 2017, 12:08 PM

Sep 9 2017

epriestley created T12977: Project "Chad's House" suggests #chad_s_house on this install but that doesn't link.
Sep 9 2017, 11:41 PM · Projects

Sep 8 2017

epriestley created 2017 Week 36 (Early September).
Sep 8 2017, 6:54 PM
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

All the search which was previously driven by InnoDB FULLTEXT is now driven by the Ferret engine on this install.

Sep 8 2017, 5:57 PM · Restricted Project, Search
amckinley created P2070 (An Untitled Masterwork).
Sep 8 2017, 4:35 PM
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 8 2017, 4:13 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 8 2017, 3:16 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 8 2017, 3:08 PM · Restricted Project, Search
amckinley claimed T12414: Implement Almanac edit endpoints in Conduit.
Sep 8 2017, 1:45 AM · Conduit, Almanac, Ops, Phacility

Sep 7 2017

epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 11:31 PM · Restricted Project, Search
epriestley closed T12976: Use a server for pygments? as Resolved.

Calling this resolved since there's no remaining upstream action, feel free to send diffs for lexers if you build them.

Sep 7 2017, 8:43 PM · Differential
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:40 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:20 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:07 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:02 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:50 PM · Restricted Project, Search
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

Here's a closer look at what's probably happening:

Sep 7 2017, 7:42 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:34 PM · Restricted Project, Search
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

I briefly hit a bizarre case where a Ferret engine query took 10 seconds to find a document in 163 projects. However, running ANALYZE TABLE on the ngrams table resolved this completely. I suspect the ngrams join may require some tweaking (and maybe a bin/storage analyze). Analyzing the Maniphest table actually seems to improve performance by ~50% too (???) although that's not a very scientific measurement.

Sep 7 2017, 7:32 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:14 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:06 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:06 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 5:30 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 5:23 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 5:06 PM · Restricted Project, Search
amckinley edited the content of Private Clusters.
Sep 7 2017, 5:00 PM
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 4:54 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 4:46 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 4:13 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 3:49 PM · Restricted Project, Search
epriestley added a comment to T12976: Use a server for pygments?.

Yeah -- we'll take the patch in the latter case (porting lexers to PHP) but may not have time to review them for a while. We aren't interested in any version of options/support for using HTTP to talk to Pygments in the upstream.

Sep 7 2017, 2:55 PM · Differential
csilvers added a comment to T12976: Use a server for pygments?.

Writing, deploying, and supporting an additional service is an enormous amount of work for us and not a solution I'm interested in pursuing for this problem

Sep 7 2017, 2:52 PM · Differential
epriestley added a comment to T12976: Use a server for pygments?.

The only way forward on Pygments performance with upstream support is porting language lexers to PHP. Writing, deploying, and supporting an additional service is an enormous amount of work for us and not a solution I'm interested in pursuing for this problem: it burdens us with a large ongoing support cost instead of very small mostly-one-time lexer porting costs.

Sep 7 2017, 11:45 AM · Differential
d.maznekov awarded T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected a Orange Medal token.
Sep 7 2017, 7:54 AM
csilvers added a comment to T12976: Use a server for pygments?.

(As a side note, the way we'd support this on our ubuntu phabricator machine is to write an upstart script to start the pygments server on startup -- it would also restart the server if it died -- and to run the server under pypy for even more performance happiness.)

Sep 7 2017, 6:32 AM · Differential
csilvers created T12976: Use a server for pygments?.
Sep 7 2017, 6:29 AM · Differential

Sep 6 2017

amckinley created Private Clusters.
Sep 6 2017, 10:08 PM
amckinley edited the content of Phacility Cluster Documentation.
Sep 6 2017, 8:59 PM
epriestley added a member for Phacility Documentation Editors: amckinley.
Sep 6 2017, 8:49 PM
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 6 2017, 7:30 PM · Restricted Project, Search