Page MenuHomePhabricator
Feed All Stories

Apr 6 2016

epriestley added a revision to T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields: Unknown Object (Differential Revision).
Apr 6 2016, 10:57 PM · Maniphest, Bug Report
epriestley added a comment to T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields.

Oh, I think I see.

Apr 6 2016, 10:55 PM · Maniphest, Bug Report
epriestley added a comment to T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields.

You ran bin/storage upgrade?

Apr 6 2016, 10:53 PM · Maniphest, Bug Report
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Chrome is free to send more "If-Modified-Since" headers when you press reload than when you navigate. I have no idea what its exact behaviors are.

Apr 6 2016, 10:52 PM · Restricted Project, Restricted Project, Wikimedia, Files
swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

I'm using the reload button next to the URL field indeed. I'm not sure this trashes the cache because if that was the case, there would be no 304s, right?

Apr 6 2016, 10:43 PM · Restricted Project, Restricted Project, Wikimedia, Files
chad created T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields.
Apr 6 2016, 10:40 PM · Maniphest, Bug Report
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

I can't reproduce that unless I actually use the "reload" command to reload the page, which looks like it makes Chrome dump caches on my system.

Apr 6 2016, 10:35 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley added a revision to T10262: Scramble file secrets when attached objects change their view policies: Unknown Object (Differential Revision).
Apr 6 2016, 10:32 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley merged T10739: Modify default user email preferences into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Apr 6 2016, 10:27 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley merged task T10739: Modify default user email preferences into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Apr 6 2016, 10:26 PM · Feature Request
ofbeaton created T10739: Modify default user email preferences.
Apr 6 2016, 10:21 PM · Feature Request
cburroughs awarded T10738: Comment previews render remarkup blocks four times a Manufacturing Defect? token.
Apr 6 2016, 10:16 PM · Performance
swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Thanks @epriestley, much looking forward to have this deployed to Phacility.

Apr 6 2016, 10:06 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley created T10738: Comment previews render remarkup blocks four times.
Apr 6 2016, 9:54 PM · Performance
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Those changes are live on this server now, let us know if you run into issues.

Apr 6 2016, 9:28 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley closed T10412: Change Milestone sort options as Resolved by committing Restricted Diffusion Commit.
Apr 6 2016, 9:14 PM · Feature Request
epriestley closed T10737: Milestone project tags should inherit their parent project's tag colour as Resolved by committing Restricted Diffusion Commit.
Apr 6 2016, 9:13 PM · Feature Request
epriestley added a revision to T10412: Change Milestone sort options: Unknown Object (Differential Revision).
Apr 6 2016, 9:02 PM · Feature Request
epriestley added a revision to T10737: Milestone project tags should inherit their parent project's tag colour: Unknown Object (Differential Revision).
Apr 6 2016, 8:58 PM · Feature Request
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

D15642 has additional details, but the new header/cache behavior is:

Apr 6 2016, 8:52 PM · Restricted Project, Restricted Project, Wikimedia, Files
ofbeaton awarded T9161: How can we fix "too much mail"? a Like token.
Apr 6 2016, 8:44 PM · Restricted Project, User Preferences, Mail
epriestley added a revision to T10262: Scramble file secrets when attached objects change their view policies: Unknown Object (Differential Revision).
Apr 6 2016, 8:42 PM · Restricted Project, Restricted Project, Wikimedia, Files
hach-que created T10737: Milestone project tags should inherit their parent project's tag colour.
Apr 6 2016, 8:41 PM · Feature Request
chad renamed T5654: Show more context for inline comments in Differential timeline from Show context for inline comments in the comment box to Show more context for inline comments in Differential timeline.
Apr 6 2016, 8:38 PM · Inline Comments, Prioritized, Restricted Project, Differential
chad updated subscribers of T5654: Show more context for inline comments in Differential timeline.
Apr 6 2016, 8:37 PM · Inline Comments, Prioritized, Restricted Project, Differential
chad merged task T10736: Add indicator that comment is done to Differential timeline into T5654: Show more context for inline comments in Differential timeline.
Apr 6 2016, 8:37 PM · Differential, Feature Request
ofbeaton awarded T5358: Make "Self Actions" default value a setting a Like token.
Apr 6 2016, 8:36 PM · User Preferences
bradley created T10736: Add indicator that comment is done to Differential timeline.
Apr 6 2016, 8:32 PM · Differential, Feature Request
epriestley added a comment to T10412: Change Milestone sort options.

If someone wants to dig the original change out of the log and send me a revert, I'll upstream it. I think this behavior (30, 29, 28) is probably better in some sense, but the other behavior (1, 2, 3) is very likely better in terms of how many upstream bug reports it generates, and I have no qualms about shipping a worse product that I don't have to support as much.

Apr 6 2016, 8:27 PM · Feature Request
epriestley merged task T10735: Workboard columns are incorrectly ordered for milestones into T10412: Change Milestone sort options.
Apr 6 2016, 8:22 PM · Bug Report
epriestley updated subscribers of T10412: Change Milestone sort options.
Apr 6 2016, 8:22 PM · Feature Request
hach-que created T10735: Workboard columns are incorrectly ordered for milestones.
Apr 6 2016, 8:16 PM · Bug Report
ofbeaton awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Like token.
Apr 6 2016, 8:15 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

On this:

Apr 6 2016, 7:56 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

D15641 has the technical details, but here's the behavior I've implemented:

Apr 6 2016, 7:30 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley added a revision to T10262: Scramble file secrets when attached objects change their view policies: Unknown Object (Differential Revision).
Apr 6 2016, 7:28 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley renamed T10262: Scramble file secrets when attached objects change their view policies from Paranoid file URL security mode causes nearly universal performance problems to Scramble file secrets when attached objects change their view policies.
Apr 6 2016, 6:51 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

If the unique url hash changed whenever the visibility policy changed, that would be fine.

Apr 6 2016, 6:49 PM · Restricted Project, Restricted Project, Wikimedia, Files
csteipp added a comment to T10262: Scramble file secrets when attached objects change their view policies.

Let me explain the WMF use case a little more. We have lots of users create public tasks, often with pictures attached, which should be private (security/privacy issues, legal issues, etc). We push notifications of new tasks to our public irc channels, and a lot of our users subscribe to huge numbers of projects. So once the task is created, the content is widely dispersed. And we need the ability to make that as private as possible.

Apr 6 2016, 6:44 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley closed T10734: "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com as Resolved by committing Restricted Diffusion Commit.
Apr 6 2016, 6:05 PM · Workboards (v3), Bug Report
epriestley claimed T10734: "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com.
Apr 6 2016, 6:03 PM · Workboards (v3), Bug Report
eadler added a revision to T10734: "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com: Unknown Object (Differential Revision).
Apr 6 2016, 6:01 PM · Workboards (v3), Bug Report
jasonfsmitty renamed T10734: "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com from I'm getting "Call to a member function getProject() on a non-object" clicking on a ticket on secure.phabricator.com to "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com.
Apr 6 2016, 5:57 PM · Workboards (v3), Bug Report
jasonfsmitty created T10734: "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com.
Apr 6 2016, 5:56 PM · Workboards (v3), Bug Report
epriestley added a revision to T6027: Way to edit which column a task is in from the task itself: Unknown Object (Differential Revision).
Apr 6 2016, 5:08 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
chad moved T6027: Way to edit which column a task is in from the task itself from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 6 2016, 4:56 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

Alright, a v0 of this is live here now -- "Move on Workboard" in the "Actions" menu above the comment box. This is a rough cut and we may not keep it in this form, but the infrastructure it needs is built now, at least.

Apr 6 2016, 4:27 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley moved T6027: Way to edit which column a task is in from the task itself from The Queue to Paused on the Prioritized board.

ignore this - test

Apr 6 2016, 4:20 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley closed T10486: Error when creating a sub-task from a prefilled URL that includes `column` as Resolved by committing Restricted Diffusion Commit.
Apr 6 2016, 4:14 PM · Maniphest, Bug Report
swisspol added a comment to T10262: Scramble file secrets when attached objects change their view policies.

I'm on my laptop using tethering on T-Mobile right now and I just noticed the user profile photos in the workboards are not being cached. Whenever I reload the page (Chrome 49.0.2623.110 on OS X 10.11.4), these photos reload from scratch. Here are the headers as reported by the Chrome inspector:

Apr 6 2016, 3:59 PM · Restricted Project, Restricted Project, Wikimedia, Files
• naktinis awarded T9425: Archiving all Spaces leaves sadpanda select behind a Love token.
Apr 6 2016, 3:41 PM · Restricted Project, Spaces
epriestley renamed T10633: Render timezones explicitly in email from countdown email does not honor timezone preferences to Render timezones explicitly in email.
Apr 6 2016, 3:27 PM · Calendar, Mail, Countdown, Bug Report
epriestley moved T7944: Add Conduit support to Calendar from Future Work (v2+) to Unprototype (v1) on the Calendar board.
Apr 6 2016, 3:23 PM · Conduit, Calendar
epriestley added a comment to T7944: Add Conduit support to Calendar.

This no longer needs to wait for T5873, since enough of that has been sorted out in EditEngine and related work that it can move forward.

Apr 6 2016, 3:23 PM · Conduit, Calendar
epriestley removed a parent task for T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: T7944: Add Conduit support to Calendar.
Apr 6 2016, 3:21 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley edited subtasks for T7944: Add Conduit support to Calendar, added: T9275: Move Calendar to EditEngine; removed: T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Apr 6 2016, 3:21 PM · Conduit, Calendar
epriestley added a parent task for T9275: Move Calendar to EditEngine: T7944: Add Conduit support to Calendar.
Apr 6 2016, 3:21 PM · ApplicationEditor, Policy, Calendar
epriestley closed T7925: Calendar v1 Errata as Resolved.

I think this is in good shape now, T9606 can track itself.

Apr 6 2016, 3:19 PM · Calendar
epriestley closed T7925: Calendar v1 Errata, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Apr 6 2016, 3:19 PM · Restricted Project, Prioritized, Calendar
epriestley closed T7926: Modernize Calendar Infrastructure as Resolved.

I think this is in good shape -- Herald is probably a ways out, and the only other chunk here is EditEngine which has a separate task (T9275).

Apr 6 2016, 3:18 PM · Calendar
epriestley closed T7926: Modernize Calendar Infrastructure, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Apr 6 2016, 3:18 PM · Restricted Project, Prioritized, Calendar
epriestley moved T7924: Unprototype Calendar (v1) from Backlog to Unprototype (v1) on the Calendar board.
Apr 6 2016, 3:16 PM · Restricted Project, Prioritized, Calendar
epriestley moved T9275: Move Calendar to EditEngine from Backlog to Unprototype (v1) on the Calendar board.
Apr 6 2016, 3:16 PM · ApplicationEditor, Policy, Calendar
epriestley moved T10684: Need a PhabricatorDateEditField from Backlog to Unprototype (v1) on the Calendar board.
Apr 6 2016, 3:16 PM · Calendar, ApplicationEditor
epriestley added a project to T10684: Need a PhabricatorDateEditField: Calendar.
Apr 6 2016, 3:16 PM · Calendar, ApplicationEditor
epriestley added a subtask for T9275: Move Calendar to EditEngine: T10684: Need a PhabricatorDateEditField.
Apr 6 2016, 3:16 PM · ApplicationEditor, Policy, Calendar
epriestley added a parent task for T10684: Need a PhabricatorDateEditField: T9275: Move Calendar to EditEngine.
Apr 6 2016, 3:16 PM · Calendar, ApplicationEditor
epriestley renamed T9275: Move Calendar to EditEngine from New Calendar events should have Public visibility by default to Move Calendar to EditEngine.
Apr 6 2016, 3:16 PM · ApplicationEditor, Policy, Calendar
epriestley closed T10733: Workboards don't have canonical URLs as Invalid.

/project/board/2/ always leads to the board and is the canonical URL.

Apr 6 2016, 3:14 PM · Bug Report
epriestley moved T9606: "Calendar" tab on user profiles is pretty junky from Backlog to Unprototype (v1) on the Calendar board.
Apr 6 2016, 3:04 PM · Calendar
epriestley renamed T9606: "Calendar" tab on user profiles is pretty junky from Only current month (ie:month unspecified) viewable on Calendar to "Calendar" tab on user profiles is pretty junky.
Apr 6 2016, 3:04 PM · Calendar
swisspol created T10733: Workboards don't have canonical URLs.
Apr 6 2016, 3:02 PM · Bug Report
epriestley moved T8897: "Attending" in Calendar list view shows all users, not just attending users from Backlog to Unprototype (v1) on the Calendar board.
Apr 6 2016, 3:02 PM · Calendar
epriestley renamed T8897: "Attending" in Calendar list view shows all users, not just attending users from Calendar event queries show wrong attendee list to "Attending" in Calendar list view shows all users, not just attending users.
Apr 6 2016, 3:02 PM · Calendar
epriestley assigned T9295: Date chooser picket fence issue with next month to lpriestley.
Apr 6 2016, 2:56 PM · Calendar
epriestley moved T9295: Date chooser picket fence issue with next month from Backlog to Unprototype (v1) on the Calendar board.
Apr 6 2016, 2:56 PM · Calendar
epriestley assigned T9296: Default "one hour jump" logic not formatted correctly to lpriestley.
Apr 6 2016, 2:56 PM · Calendar
epriestley moved T9296: Default "one hour jump" logic not formatted correctly from Backlog to Unprototype (v1) on the Calendar board.
Apr 6 2016, 2:56 PM · Calendar
spawnlt awarded T3980: Support "Bind to External Thing" to define project membership a Yellow Medal token.
Apr 6 2016, 2:02 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
sascha-egerer added a comment to T10731: Script-and-regex linter documentation does not make it clear enough that you really have to do what it says.

The use of sh as it is written in the documentation is important.

This is what you are intended to write:

$ sh -c 'echo "$0"' xxx
xxx

This is what it looks like you're writing:

$ echo $0 xxx
-bash xxx
Apr 6 2016, 1:47 PM · Lint, Bug Report
epriestley added a comment to T10729: Improve layout tools for side-by-side tables of images in Remarkup documents.

At least today, I don't think we can reasonably guess when a table is really a collection of side-by-side comparison images to do anything special with it. I think allowing block-level elements to change behavior based on content would require a total restructuring of how Remarkup parses, and make adding new rules far more complex (see also T10354).

Apr 6 2016, 1:43 PM · Remarkup, Feature Request
epriestley renamed T10729: Improve layout tools for side-by-side tables of images in Remarkup documents from Make Phriction document render full-page width (like Maniphest tasks) to Improve layout tools for side-by-side tables of images in Remarkup documents.
Apr 6 2016, 1:35 PM · Remarkup, Feature Request
Luke081515.2 awarded T6027: Way to edit which column a task is in from the task itself a Like token.
Apr 6 2016, 1:33 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley merged task T10732: Creating repository via repository.create API does not get uri indexed into T10337: Implement `diffusion.search` and think about `diffusion.edit`.
Apr 6 2016, 1:33 PM · Search, Diffusion, Conduit, Bug Report
epriestley updated subscribers of T10337: Implement `diffusion.search` and think about `diffusion.edit`.
Apr 6 2016, 1:33 PM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10732: Creating repository via repository.create API does not get uri indexed.

I'm just going to merge this into T10337, which discusses providing modern endpoints. repository.create is a broken mess and we tend to replace it rather than fixing it (it can't reasonably be fixed without breaking the API, anyway, so we'd end up with a new endpoint in effect, regardless). The new diffusion.edit will fix this and the many other problems with repository.create.

Apr 6 2016, 1:32 PM · Search, Diffusion, Conduit, Bug Report
epriestley added a revision to T6027: Way to edit which column a task is in from the task itself: Unknown Object (Differential Revision).
Apr 6 2016, 1:24 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
Pawka created T10732: Creating repository via repository.create API does not get uri indexed.
Apr 6 2016, 1:13 PM · Search, Diffusion, Conduit, Bug Report
epriestley added a revision to T6027: Way to edit which column a task is in from the task itself: Unknown Object (Differential Revision).
Apr 6 2016, 1:08 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

The infrastructure changes should now be complete, and we're clear to start experimenting with the UI. Progress so far:

Apr 6 2016, 12:23 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T7789: Support Git Large File Storage.

(This is paused since we're waiting on feedback -- if you give it a shot, let us know how things go.)

Apr 6 2016, 12:17 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley moved T6027: Way to edit which column a task is in from the task itself from Backlog to The Queue on the Prioritized board.
Apr 6 2016, 12:16 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley moved T7789: Support Git Large File Storage from Backlog to Paused on the Prioritized board.
Apr 6 2016, 12:16 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T6027: Way to edit which column a task is in from the task itself: Unknown Object (Differential Revision).
Apr 6 2016, 12:14 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T10486: Error when creating a sub-task from a prefilled URL that includes `column`.

D15636 is marked as fixing this. Specifically:

Apr 6 2016, 11:45 AM · Maniphest, Bug Report
epriestley added a revision to T5214: Add Conduit API methods for workboards: Unknown Object (Differential Revision).
Apr 6 2016, 11:38 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley added a revision to T6027: Way to edit which column a task is in from the task itself: Restricted Differential Revision.
Apr 6 2016, 11:38 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a revision to T10486: Error when creating a sub-task from a prefilled URL that includes `column`: Restricted Differential Revision.
Apr 6 2016, 11:38 AM · Maniphest, Bug Report
epriestley added a revision to T6027: Way to edit which column a task is in from the task itself: Unknown Object (Differential Revision).
Apr 6 2016, 11:11 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a revision to T6027: Way to edit which column a task is in from the task itself: Restricted Differential Revision.
Apr 6 2016, 10:10 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest