Page MenuHomePhabricator

Archiving all Spaces leaves sadpanda select behind
Open, Needs TriagePublic

"Love" token, awarded by kuba-orlik."Love" token, awarded by naktinis."Love" token, awarded by tycho.tatitscheff.
Assigned To
Authored By
Sep 15 2015, 7:05 PM


People like to "play" with Spaces, even though they may not actually use it in production. Archiving Spaces is possible, but leaves UI behind.

Event Timeline

chad created this task.Sep 15 2015, 7:05 PM
chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added a project: Spaces.
chad moved this task to Backlog on the Spaces board.
chad added a subscriber: chad.

May I try to submit a fix ?

tycho.tatitscheff added a subscriber: epriestley.EditedSep 17 2015, 7:38 AM

@chad @epriestley :

My goal is to edit [[;23b2653f52cd16bc9cedfdf7328d401171e668ca$328-358 | AphrontFormPolicyControl::buildSpacesControl ]] to return null also when only default Space is remaining active.

My proposal is to replace [[;23b2653f52cd16bc9cedfdf7328d401171e668ca$337-340 | this call to PhabricatorSpacesNamespaceQuery::getViewerSpacesExist($viewer) ]] by a call to PhabricatorSpacesNamespaceQuery::getViewerActiveSpacesExist($viewer).

The PhabricatorSpacesNamespaceQuery::getViewerActiveSpacesExist($viewer) don't exist so i will create something similar to [[;23b2653f52cd16bc9cedfdf7328d401171e668ca$95-104 | PhabricatorSpacesNamespaceQuery::getViewerSpacesExist($viewer) ]] using $spaces = self::getActiveViewerSpaces($viewer) instead of $spaces = self::getViewerSpaces($viewer).

Did you agree on the fix ? Am I authorized to Submit a diff. I would be very pleased.

I'm not quite sure if I should expect a response (here or on IRC) before submitting some code. Or if the maniphest task is sufficient.

naktinis added a subscriber: naktinis.
eadler added a project: Restricted Project.Aug 5 2016, 5:09 PM
hyOzd added a subscriber: hyOzd.Jan 19 2017, 9:51 AM

In Barcelona we're looking at the same problem: how to deactive Spaces? After archiving all spaces, the UI still keeps on showing the Space dropdown with default Space. We would be glad to simplify life of our users, and haven't seen the added value of Spaces as such. If anyone could give us a hint that would be greatly appreciated. Thanks in advance!