People like to "play" with Spaces, even though they may not actually use it in production. Archiving Spaces is possible, but leaves UI behind.
My goal is to edit AphrontFormPolicyControl::buildSpacesControl to return null also when only default Space is remaining active.
My proposal is to replace this call to PhabricatorSpacesNamespaceQuery::getViewerSpacesExist($viewer) by a call to PhabricatorSpacesNamespaceQuery::getViewerActiveSpacesExist($viewer).
The PhabricatorSpacesNamespaceQuery::getViewerActiveSpacesExist($viewer) don't exist so i will create something similar to PhabricatorSpacesNamespaceQuery::getViewerSpacesExist($viewer) using $spaces = self::getActiveViewerSpaces($viewer) instead of $spaces = self::getViewerSpaces($viewer).
Did you agree on the fix ? Am I authorized to Submit a diff. I would be very pleased.
In Barcelona we're looking at the same problem: how to deactive Spaces? After archiving all spaces, the UI still keeps on showing the Space dropdown with default Space. We would be glad to simplify life of our users, and haven't seen the added value of Spaces as such. If anyone could give us a hint that would be greatly appreciated. Thanks in advance!