People like to "play" with Spaces, even though they may not actually use it in production. Archiving Spaces is possible, but leaves UI behind.
Description
Description
Revisions and Commits
Revisions and Commits
Related Objects
Related Objects
Event Timeline
Comment Actions
My goal is to edit [[https://secure.phabricator.com/diffusion/P/browse/master/src/view/form/control/AphrontFormPolicyControl.php;23b2653f52cd16bc9cedfdf7328d401171e668ca$328-358 | AphrontFormPolicyControl::buildSpacesControl ]] to return null also when only default Space is remaining active.
My proposal is to replace [[ https://secure.phabricator.com/diffusion/P/browse/master/src/view/form/control/AphrontFormPolicyControl.php;23b2653f52cd16bc9cedfdf7328d401171e668ca$337-340 | this call to PhabricatorSpacesNamespaceQuery::getViewerSpacesExist($viewer) ]] by a call to PhabricatorSpacesNamespaceQuery::getViewerActiveSpacesExist($viewer).
The PhabricatorSpacesNamespaceQuery::getViewerActiveSpacesExist($viewer) don't exist so i will create something similar to [[ https://secure.phabricator.com/diffusion/P/browse/master/src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php;23b2653f52cd16bc9cedfdf7328d401171e668ca$95-104 | PhabricatorSpacesNamespaceQuery::getViewerSpacesExist($viewer) ]] using $spaces = self::getActiveViewerSpaces($viewer) instead of $spaces = self::getViewerSpaces($viewer).
Did you agree on the fix ? Am I authorized to Submit a diff. I would be very pleased.
Comment Actions
I'm not quite sure if I should expect a response (here or on IRC) before submitting some code. Or if the maniphest task is sufficient.
Comment Actions
In Barcelona we're looking at the same problem: how to deactive Spaces? After archiving all spaces, the UI still keeps on showing the Space dropdown with default Space. We would be glad to simplify life of our users, and haven't seen the added value of Spaces as such. If anyone could give us a hint that would be greatly appreciated. Thanks in advance!