Page MenuHomePhabricator
Feed Advanced Search

Apr 26 2015

epriestley added a comment to T7915: Logged out search dropdown... unneeded?.

I think we should keep it around but make it work, there's no reason the options can't function for logged-out users.

Apr 26 2015, 2:39 AM · Search

Apr 25 2015

epriestley awarded T7920: projectdisimbiguationpages a Pterodactyl token.
Apr 25 2015, 9:53 PM · Search
epriestley added a revision to T7918: Maniphest filters with `allProjects` in the URL no longer work: Unknown Object (Differential Revision).
Apr 25 2015, 9:52 PM · Maniphest
epriestley claimed T7918: Maniphest filters with `allProjects` in the URL no longer work.
Apr 25 2015, 9:47 PM · Maniphest
epriestley renamed T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items from Update error on mercurial repo with 11k+ commits to Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.
Apr 25 2015, 9:43 PM · Diffusion, Mercurial, Daemons
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Unknown Object (Differential Revision).
Apr 25 2015, 9:40 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Unknown Object (Differential Revision).
Apr 25 2015, 9:31 PM · Mercurial, Diffusion
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Unknown Object (Differential Revision).
Apr 25 2015, 9:31 PM · Diffusion
epriestley claimed T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.
Apr 25 2015, 9:29 PM · Diffusion, Mercurial, Daemons
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Unknown Object (Differential Revision).
Apr 25 2015, 9:18 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Unknown Object (Differential Revision).
Apr 25 2015, 9:18 PM · Mercurial, Diffusion
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Unknown Object (Differential Revision).
Apr 25 2015, 9:09 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Unknown Object (Differential Revision).
Apr 25 2015, 9:09 PM · Mercurial, Diffusion
epriestley created T7919: Actions dropdown in Phriction immediately closes with Quicksand active.
Apr 25 2015, 9:05 PM · Phriction, Conpherence, Quicksand
epriestley added a comment to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.

D12549 applies the strategy recursively, although we'll probably hit shell argument length limits before we hit 65K branch heads.

Apr 25 2015, 5:01 PM · Diffusion, Mercurial, Daemons
epriestley added a revision to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items: Unknown Object (Differential Revision).
Apr 25 2015, 4:56 PM · Diffusion, Mercurial, Daemons
epriestley added a comment to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.

This is rooted in a limitation with Mercurial. I've filed a report upstream:

Apr 25 2015, 4:46 PM · Diffusion, Mercurial, Daemons
epriestley added a comment to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.

The change breaks "Track Only", breaks repositories without "Track Only", breaks new imports, runs 75x slower than necessary in the cases above, etc.

Apr 25 2015, 4:01 PM · Diffusion, Mercurial, Daemons
epriestley added a comment to T7108: high server load due to continuous hg calls.

D12548 probably fixes this. Let me know how things look after that lands.

Apr 25 2015, 3:53 PM · Mercurial
epriestley added a revision to T7108: high server load due to continuous hg calls: Unknown Object (Differential Revision).
Apr 25 2015, 3:52 PM · Mercurial
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Unknown Object (Differential Revision).
Apr 25 2015, 3:52 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Unknown Object (Differential Revision).
Apr 25 2015, 3:52 PM · Mercurial, Diffusion
epriestley closed T3868: Implement a "Link" StandardCustomField as Resolved by committing Restricted Diffusion Commit.
Apr 25 2015, 3:24 PM · Maniphest, Custom Fields
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Unknown Object (Differential Revision).
Apr 25 2015, 3:24 PM · Diffusion
vrusinov awarded T5222: Exception pylint is an invalid linter a Like token.
Apr 25 2015, 2:11 PM · Arcanist
epriestley added a comment to T7918: Maniphest filters with `allProjects` in the URL no longer work.

I need to go hunt all of these down, this is now statuses=open()&projects=PHID-PROJ-...

Apr 25 2015, 12:35 PM · Maniphest
joshuaspence added a comment to T7917: Better Duplicate Icon?.

#1 gets my vote.

Apr 25 2015, 7:30 AM · Maniphest
epriestley added a comment to T5411: Allow pasting images when creating Pholio mocks.

Pasteboard.co uses the separate-div-with-contentEditable technique as well:

Apr 25 2015, 1:18 AM · Pholio
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

As I recall, the problem isn't getting the event (that's relatively straightforward), it's reading image data out of it. At least as of a year ago, Safari and Firefox did not let you read image data from a paste.

Apr 25 2015, 1:12 AM · Restricted Project, Firefox, Safari, PHUI
epriestley added a comment to T7917: Better Duplicate Icon?.

I think I like #1 the best, but #3 is good, and also #2 is good.

Apr 25 2015, 12:14 AM · Maniphest
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

This has never worked, and still wasn't practical to implement when I checked last year (T5411#64865).

Apr 25 2015, 12:13 AM · Restricted Project, Firefox, Safari, PHUI

Apr 24 2015

epriestley added a comment to T7909: Allow ascending order for Conduit's maniphest.query's "order" parameter (order-created, order-modified).

For context, it sounds like https://phabricator.wikimedia.org/T96238 is the root issue here, specifically https://phabricator.wikimedia.org/T96238#1234459. In general:

Apr 24 2015, 9:27 PM · Conduit
epriestley closed T7905: Close the notification menu when a user clicks it as Resolved by committing Restricted Diffusion Commit.
Apr 24 2015, 9:25 PM · Conpherence, Quicksand
epriestley closed T7905: Close the notification menu when a user clicks it, a subtask of T7573: Ship Quicksand, as Resolved.
Apr 24 2015, 9:25 PM · Quicksand, Conpherence
epriestley closed T7900: Update search scope selector for Quicksand navigation as Resolved by committing Restricted Diffusion Commit.
Apr 24 2015, 9:20 PM · Conpherence, Quicksand
epriestley closed T7900: Update search scope selector for Quicksand navigation, a subtask of T7573: Ship Quicksand, as Resolved.
Apr 24 2015, 9:20 PM · Quicksand, Conpherence
epriestley added a comment to T7804: Implement an "Acting User" Herald condition.

In the general case, we need to let you write this rule:

Apr 24 2015, 9:14 PM · Restricted Project, Herald, Mail
epriestley renamed T7804: Implement an "Acting User" Herald condition from Some users are getting emails for self actions after upgrade to Implement an "Acting User" Herald condition.
Apr 24 2015, 9:13 PM · Restricted Project, Herald, Mail
epriestley reopened T7804: Implement an "Acting User" Herald condition as "Open".
Apr 24 2015, 9:13 PM · Restricted Project, Herald, Mail
epriestley added a comment to T7908: Implement aliases for objects.

Yeah, it's nice in a gluey sort of way, I just don't see many gluey use cases for it.

Apr 24 2015, 7:49 PM · Maniphest
epriestley renamed T7908: Implement aliases for objects from Implement aliases for objects (or at least for to Implement aliases for objects.
Apr 24 2015, 7:37 PM · Maniphest
epriestley added a comment to T7908: Implement aliases for objects.

But I don't really see any use cases for this, either.

Apr 24 2015, 7:35 PM · Maniphest
epriestley added a comment to T7908: Implement aliases for objects.

I'm not really convinced that this is hugely valuable, although it seems like it might plausibly be worth building at some point, maybe.

Apr 24 2015, 7:32 PM · Maniphest
epriestley renamed T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads) from Getting 'Ref "default" is ambiguous or does not exist' error (multiple default branches) to Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).
Apr 24 2015, 7:23 PM · Diffusion
epriestley added a comment to T7908: Implement aliases for objects.

See also T3725.

Apr 24 2015, 7:05 PM · Maniphest
epriestley added a revision to T3868: Implement a "Link" StandardCustomField: Unknown Object (Differential Revision).
Apr 24 2015, 6:50 PM · Maniphest, Custom Fields
epriestley added a revision to T3868: Implement a "Link" StandardCustomField: Unknown Object (Differential Revision).
Apr 24 2015, 6:48 PM · Maniphest, Custom Fields
epriestley updated the task description for T3868: Implement a "Link" StandardCustomField.
Apr 24 2015, 6:48 PM · Maniphest, Custom Fields
epriestley updated the task description for T3868: Implement a "Link" StandardCustomField.
Apr 24 2015, 6:48 PM · Maniphest, Custom Fields
epriestley closed T7906: this is a new task. as Resolved.

good task

Apr 24 2015, 6:16 PM · Nuance
epriestley updated subscribers of T5474: Support workboard column triggers which activate when a task is dropped into a column.
Apr 24 2015, 6:15 PM · Workboards (v3), Restricted Project
epriestley merged task T7907: Ability to filter/search Maniphest tasks based on Workboard column position into T5474: Support workboard column triggers which activate when a task is dropped into a column.
Apr 24 2015, 6:15 PM · Maniphest, Workboards
epriestley added a comment to T7907: Ability to filter/search Maniphest tasks based on Workboard column position.

We don't currently plan to implement this. Instead, we're going to implement triggers. Triggers would let you change task states or projects as they moved between columns, and then you could query by that derived field.

Apr 24 2015, 6:15 PM · Maniphest, Workboards
epriestley added a revision to T7905: Close the notification menu when a user clicks it: Unknown Object (Differential Revision).
Apr 24 2015, 5:48 PM · Conpherence, Quicksand
epriestley claimed T7905: Close the notification menu when a user clicks it.
Apr 24 2015, 5:44 PM · Conpherence, Quicksand
epriestley added a revision to T7900: Update search scope selector for Quicksand navigation: Unknown Object (Differential Revision).
Apr 24 2015, 5:42 PM · Conpherence, Quicksand
epriestley created T7905: Close the notification menu when a user clicks it.
Apr 24 2015, 5:42 PM · Conpherence, Quicksand
epriestley added a comment to T3868: Implement a "Link" StandardCustomField.

people type random junk in the next block to celebrate their freedom

Apr 24 2015, 4:41 PM · Maniphest, Custom Fields
epriestley changed the visibility for T3868: Implement a "Link" StandardCustomField.
Apr 24 2015, 4:13 PM · Maniphest, Custom Fields
epriestley closed T7902: Visiting deleted differential revision causes unrecoverable fatal error as Resolved by committing Restricted Diffusion Commit.
Apr 24 2015, 4:11 PM · Differential
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Apr 24 2015, 3:41 PM · Restricted Project, Typeahead
epriestley closed T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php as Resolved by committing Restricted Diffusion Commit.
Apr 24 2015, 3:39 PM · Dashboards
epriestley triaged T7903: Conduit differential.query search by branches is broken as Low priority.
Apr 24 2015, 3:38 PM · Restricted Project, Differential, Conduit
epriestley added a revision to T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php: Unknown Object (Differential Revision).
Apr 24 2015, 3:38 PM · Dashboards
epriestley claimed T7903: Conduit differential.query search by branches is broken.

This is a bug in Phabricator.

Apr 24 2015, 3:31 PM · Restricted Project, Differential, Conduit
epriestley added a comment to T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php.

Oh, it's the "authored" prebuilt query specifically.

Apr 24 2015, 3:29 PM · Dashboards
epriestley added a comment to T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php.

Does someone have detailed repro steps? Here's what I tried:

Apr 24 2015, 3:29 PM · Dashboards
robertos awarded T6973: Associating Diffusion commits to Projects a Like token.
Apr 24 2015, 1:45 PM · Feed, Projects, Diffusion
Cst awarded T6973: Associating Diffusion commits to Projects a Like token.
Apr 24 2015, 1:21 PM · Feed, Projects, Diffusion
epriestley added a revision to T7902: Visiting deleted differential revision causes unrecoverable fatal error: Unknown Object (Differential Revision).
Apr 24 2015, 10:29 AM · Differential
epriestley added a comment to T7573: Ship Quicksand.

It would ideally be nice to do POST over Quicksand too, some day, but we can hold that for v5 or whatever.

Apr 24 2015, 12:18 AM · Quicksand, Conpherence
epriestley added a comment to T7573: Ship Quicksand.

phantom back-forward issue

Apr 24 2015, 12:17 AM · Quicksand, Conpherence
epriestley created T7900: Update search scope selector for Quicksand navigation.
Apr 24 2015, 12:16 AM · Conpherence, Quicksand
epriestley added a comment to T7573: Ship Quicksand.

I think we should probably just close T7448 as wontfix, it's just a diagnostic error message with no other negative effects in Firefox only and I don't think the complexity of dealing with explicitly tearing the socket down is worth its weight in code.

Apr 24 2015, 12:15 AM · Quicksand, Conpherence

Apr 23 2015

epriestley added a comment to T7842: Durable Column unable to scroll when mouse is over embeded Pholio.

Good news: still can't repro.

Apr 23 2015, 11:33 PM · Conpherence
epriestley added a comment to T7842: Durable Column unable to scroll when mouse is over embeded Pholio.

Oh, I wasn't testing in the column and it's not in my 6 most recent theads anymore.

Apr 23 2015, 11:33 PM · Conpherence
epriestley added a comment to T7842: Durable Column unable to scroll when mouse is over embeded Pholio.

As usual, I can't reproduce this on my machine. :)

Apr 23 2015, 11:32 PM · Conpherence
epriestley added a comment to T7844: Workboard printable is incomplete/empty.

The position: static; in this rule causes the issue:

Apr 23 2015, 11:31 PM · Workboards
epriestley renamed T7899: DifferentialDiff->description is "text255?" but should be "text" from Arcanist returns HTTP/500 "data too long for column 'description'" when performing `arc diff --update` with long commit message on first line. to DifferentialDiff->description is "text255?" but should be "text".
Apr 23 2015, 11:08 PM · Differential, Mercurial, Arcanist
epriestley closed T5733: Add option for "show only assigned" tasks in search as Resolved by committing Restricted Diffusion Commit.
Apr 23 2015, 10:44 PM · Maniphest
epriestley added a comment to T7860: When users search for "#x y", treat "#x" as a project hashtag.

I have half a diff for this, but project slug lookup is a gigantic mess right now.

Apr 23 2015, 10:43 PM · Search
epriestley triaged T7860: When users search for "#x y", treat "#x" as a project hashtag as Low priority.
Apr 23 2015, 10:43 PM · Search
epriestley closed T6973: Associating Diffusion commits to Projects as Resolved.

Global "Commit" rules in Herald can now add or remove projects, so you could write a rule like this:

Apr 23 2015, 10:41 PM · Feed, Projects, Diffusion
epriestley added a revision to T5733: Add option for "show only assigned" tasks in search: Unknown Object (Differential Revision).
Apr 23 2015, 10:06 PM · Maniphest
epriestley claimed T5733: Add option for "show only assigned" tasks in search.
Apr 23 2015, 10:06 PM · Maniphest
epriestley triaged T7894: Give more specific error when git clone fails as Low priority.
Apr 23 2015, 8:28 PM · Diffusion
epriestley triaged T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked as Wishlist priority.
Apr 23 2015, 8:28 PM · Typeahead, Notifications
epriestley renamed T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked from Event Listeners should respect middle and right clicks if possible to Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.
Apr 23 2015, 8:25 PM · Typeahead, Notifications
epriestley added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

Event listeners do, generally speaking, respect middle and right clicks. This isn't a case of event listeners just being too ambitious.

Apr 23 2015, 8:24 PM · Typeahead, Notifications
epriestley added a comment to T7895: Make HIGHLIGHT_BYTE_LIMIT configurable.

(Our largest human-facing source file is PhabricatorApplicationTransactionEditor.php and weighs in at a paltry 78KB.)

Apr 23 2015, 7:48 PM · Restricted Project, Restricted Project, Differential
epriestley added a comment to T7895: Make HIGHLIGHT_BYTE_LIMIT configurable.

In an ideal world, would the regularly edited human-facing 537KB file still be a single 537KB file (rather than, e.g., a collection of smaller files, or a code-generated file, or some other kind of resource)?

Apr 23 2015, 7:44 PM · Restricted Project, Restricted Project, Differential
epriestley added a comment to T7860: When users search for "#x y", treat "#x" as a project hashtag.

I think it's reasonable for #x y to mean "documents matching query y in project #x", but I don't think x y should mean this on its own.

Apr 23 2015, 7:31 PM · Search
epriestley lowered the priority of T6187: Allow query results to be exported to spreadsheet rendered in the browser from Normal to Wishlist.
Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a comment to T6187: Allow query results to be exported to spreadsheet rendered in the browser.

T5307 discusses finding some way to fit "Export to spreadsheet.." -- and various other options -- into the UI in the general case.

Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a subtask for T6187: Allow query results to be exported to spreadsheet rendered in the browser: T5307: UX for taking actions with search results.
Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a parent task for T5307: UX for taking actions with search results: T6187: Allow query results to be exported to spreadsheet rendered in the browser.
Apr 23 2015, 7:27 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a comment to T6187: Allow query results to be exported to spreadsheet rendered in the browser.

We're vanishingly unlikely to redesign search results in the general case, and this request isn't compatible with responsive "object" list search results.

Apr 23 2015, 7:26 PM · ApplicationSearch
epriestley renamed T6187: Allow query results to be exported to spreadsheet rendered in the browser from Make ApplicationSearch better on large result sets to Allow query results to be exported to spreadsheet rendered in the browser.
Apr 23 2015, 7:22 PM · ApplicationSearch
epriestley closed T6383: Blogs and Posts should be searchable. as Invalid.

Sorry, we don't accept feature requests for prototype applications like Phame. See:

Apr 23 2015, 7:15 PM · Phame
epriestley closed T5595: Allow all applications to filter results by project as Resolved.

Diffusion, Pholio, Differential and Maniphest now support generic, full-power modern project filtering. I think that covers all the applications we're aware of significant interest in for this feature. It will come to other applications as they get modernized and updated over time.

Apr 23 2015, 7:12 PM · Projects, ApplicationSearch