Page MenuHomePhabricator
Feed Advanced Search

Aug 2 2019

epriestley added a comment to T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22.

Per T13366, I'm just going to get rid of this behavior for now, with the expectation that we'll soon begin generating side-channel emails for "Billing Department Email Address" under the umbrella of T8389 and could put "Merchant Emails" on a similar channel if we want.

Aug 2 2019, 5:43 PM · Phortune, Phacility
epriestley added a parent task for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T7607: Invoicing emails probably need some work: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added a parent task for T13358: Generate PDFs for Phortune invoices: T13366: Update Phortune to work better with "enterprise" billing/accounts departments.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley added subtasks for T13366: Update Phortune to work better with "enterprise" billing/accounts departments: T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22, T13358: Generate PDFs for Phortune invoices, T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, T7607: Invoicing emails probably need some work.
Aug 2 2019, 5:41 PM · Phortune, Phacility
epriestley triaged T13366: Update Phortune to work better with "enterprise" billing/accounts departments as Normal priority.
Aug 2 2019, 5:40 PM · Phortune, Phacility
epriestley added a revision to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases: Unknown Object (Differential Revision).
Aug 2 2019, 4:42 PM · Diffusion, Conduit
epriestley closed T8830: `bin/remove destroy` is dangerous and leaves dangling edges as Resolved by committing Restricted Diffusion Commit.
Aug 2 2019, 4:31 PM · Infrastructure, Restricted Project
epriestley closed T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation as Resolved by committing Restricted Diffusion Commit.
Aug 2 2019, 4:30 PM · Diffusion, Policy, Documentation
epriestley added a revision to T8830: `bin/remove destroy` is dangerous and leaves dangling edges: Unknown Object (Differential Revision).
Aug 2 2019, 4:23 PM · Infrastructure, Restricted Project
epriestley added a revision to T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation: Unknown Object (Differential Revision).
Aug 2 2019, 4:23 PM · Diffusion, Policy, Documentation
epriestley triaged T13365: Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit" as Low priority.
Aug 2 2019, 1:58 PM · Diffusion

Aug 1 2019

epriestley triaged T13364: Clarify that deleting repositories (and users?) from the web UI is explicitly not supported, not a resource limitation as Low priority.
Aug 1 2019, 9:53 PM · Diffusion, Policy, Documentation
aklapper awarded T13255: transaction.search should accept user PHIDs as constraints a Love token.
Aug 1 2019, 8:32 PM · Conduit, Transactions
epriestley added a comment to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.

See also https://phabricator.wikimedia.org/T197935.

Aug 1 2019, 7:55 PM · Diffusion, Conduit
epriestley closed T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Resolved by committing Restricted Diffusion Commit.
Aug 1 2019, 7:25 PM · Quicksand
epriestley added a revision to T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog: Unknown Object (Differential Revision).
Aug 1 2019, 7:06 PM · Quicksand
epriestley triaged T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Normal priority.
Aug 1 2019, 6:59 PM · Quicksand
epriestley triaged T13362: Push the "Config" application UI out to full-width as Low priority.
Aug 1 2019, 6:53 PM · Design, Config
epriestley triaged T13361: Get rid of the "Actions" dropdown in Diffusion as Low priority.
Aug 1 2019, 6:10 PM · Design, Diffusion
epriestley triaged T13360: Document the pull and push logs in Diffusion as Low priority.
Aug 1 2019, 6:05 PM · Documentation, Diffusion
epriestley triaged T13359: Phacility deploy workflow should not conflate versions-for-deployment with "latest stable release" as Low priority.
Aug 1 2019, 5:48 PM · Phacility, Ops
epriestley added a revision to T13358: Generate PDFs for Phortune invoices: Unknown Object (Differential Revision).
Aug 1 2019, 5:37 PM · Phortune, Phacility
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

$info_object = new PhabricatorPDFInfoObject();

Aug 1 2019, 5:20 PM · Phortune, Phacility
epriestley added a comment to T13358: Generate PDFs for Phortune invoices.

PDF files appear to consist of a series of objects that (mostly) look like this:

Aug 1 2019, 2:36 AM · Phortune, Phacility
epriestley triaged T13358: Generate PDFs for Phortune invoices as Low priority.
Aug 1 2019, 12:55 AM · Phortune, Phacility

Jul 31 2019

epriestley closed T13356: Support a "limit" configuration option for tokenizer-based custom fields as Resolved by committing Restricted Diffusion Commit.
Jul 31 2019, 8:13 PM · Custom Fields
epriestley closed T4900: Workboards updating in real time as Resolved.

See T13357 for followup.

Jul 31 2019, 8:13 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13357: Improvements to Workboard Real-Time Updates as Low priority.
Jul 31 2019, 8:12 PM · Aphlict, Workboards
epriestley closed T13355: Support editing "date" custom fields via Conduit as Resolved by committing Restricted Diffusion Commit.
Jul 31 2019, 8:10 PM · Custom Fields, Conduit
epriestley added a revision to T13356: Support a "limit" configuration option for tokenizer-based custom fields: Unknown Object (Differential Revision).
Jul 31 2019, 8:02 PM · Custom Fields
epriestley added a comment to T13356: Support a "limit" configuration option for tokenizer-based custom fields.

This is likely straightforward.

Jul 31 2019, 7:55 PM · Custom Fields
epriestley triaged T13356: Support a "limit" configuration option for tokenizer-based custom fields as Low priority.
Jul 31 2019, 7:51 PM · Custom Fields
epriestley added a revision to T13355: Support editing "date" custom fields via Conduit: Unknown Object (Differential Revision).
Jul 31 2019, 7:48 PM · Custom Fields, Conduit
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 31 2019, 7:42 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13355: Support editing "date" custom fields via Conduit as Low priority.
Jul 31 2019, 7:38 PM · Custom Fields, Conduit
epriestley added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

See also PHI1358, which is an actual concrete request for sensible relabeling of "Description" in a subtype.

Jul 31 2019, 7:32 PM · Custom Fields, Maniphest
epriestley edited the content of Changelog.
Jul 31 2019, 7:02 PM
epriestley created an object: 2019 Week 31 (July).
Jul 31 2019, 7:01 PM
epriestley closed T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing as Resolved by committing Restricted Diffusion Commit.
Jul 31 2019, 6:44 PM · Phame
epriestley closed T13354: Test: Workboards Real-Time Updates!? as Invalid.
Jul 31 2019, 6:43 PM · Workboards
epriestley reopened T13354: Test: Workboards Real-Time Updates!? as "Open".
Jul 31 2019, 6:43 PM · Workboards
epriestley closed T13354: Test: Workboards Real-Time Updates!? as Invalid.
Jul 31 2019, 6:42 PM · Workboards
epriestley renamed T13354: Test: Workboards Real-Time Updates!? from Test: Workboards Real-Time Updates! to Test: Workboards Real-Time Updates!?.
Jul 31 2019, 6:42 PM · Workboards
epriestley moved T13354: Test: Workboards Real-Time Updates!? from Future Work to Backlog on the Workboards board.
Jul 31 2019, 6:42 PM · Workboards
epriestley renamed T13354: Test: Workboards Real-Time Updates!? from Test: Workboards Real-Time Updates to Test: Workboards Real-Time Updates!.
Jul 31 2019, 6:42 PM · Workboards
epriestley created T13354: Test: Workboards Real-Time Updates!?.
Jul 31 2019, 6:42 PM · Workboards
epriestley added a revision to T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing: Unknown Object (Differential Revision).
Jul 31 2019, 6:40 PM · Phame
epriestley triaged T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing as Low priority.
Jul 31 2019, 6:33 PM · Phame
epriestley closed T13350: Ancient "slowvote.info" API method bypasses policy checks as Resolved by committing Restricted Diffusion Commit.
Jul 31 2019, 6:28 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Unknown Object (Differential Revision).
Jul 31 2019, 6:26 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Unknown Object (Differential Revision).
Jul 31 2019, 6:22 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Unknown Object (Differential Revision).
Jul 31 2019, 6:17 PM · Slowvote, Security
epriestley updated the task description for T13352: Very large objects may not be distributable via CDN (CloudFront has 20GB object limit).
Jul 31 2019, 12:14 AM · Files, Infrastructure

Jul 30 2019

epriestley triaged T13352: Very large objects may not be distributable via CDN (CloudFront has 20GB object limit) as Low priority.
Jul 30 2019, 11:42 PM · Files, Infrastructure
epriestley triaged T13351: "Settings" objects render very generically in the transaction log as Low priority.
Jul 30 2019, 11:21 PM · User Preferences, Feed
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Unknown Object (Differential Revision).
Jul 30 2019, 6:53 PM · Slowvote, Security
epriestley triaged T13350: Ancient "slowvote.info" API method bypasses policy checks as Low priority.
Jul 30 2019, 6:46 PM · Slowvote, Security
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 30 2019, 6:20 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:20 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Ops, Restricted Project, Phacility

Jul 24 2019

epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 24 2019, 6:11 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

There's currently a bug (likely related to D20652 or D20654?) where normal edits aren't respecting card order correctly during the redraw. I suspect this is just an order parameter getting lost somewhere.

Jul 24 2019, 5:31 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 24 2019, 5:29 PM · Workboards (v3), User Delight, Wikimedia
epriestley closed T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion as Resolved.

Everything has made it to master now so I suspect we're in good shape here.

Jul 24 2019, 5:04 PM · Auth
epriestley closed T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Resolved by committing Restricted Diffusion Commit.
Jul 24 2019, 4:25 PM · Harbormaster
epriestley added a revision to T13348: "Restart All Builds" is misleading in the presence of non-restartable builds: Unknown Object (Differential Revision).
Jul 24 2019, 3:14 PM · Harbormaster
epriestley closed T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Resolved by committing Restricted Diffusion Commit.
Jul 24 2019, 2:09 PM · Feed
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Adjusting log_warnings = 2 in production (to get connection aborts into the error log) is also possibly desirable, although the background level of connection abortions (general network flakiness, server restarts during deploy, wait_timeout on very long-running demons?) may be high enough that this is more noise than signal.

Jul 24 2019, 2:03 PM · Ops, Restricted Project, Phacility

Jul 23 2019

epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: Unknown Object (Differential Revision).
Jul 23 2019, 11:03 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

To reproduce this easily:

Jul 23 2019, 10:57 PM · Feed
epriestley triaged T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Low priority.
Jul 23 2019, 10:47 PM · Feed
epriestley triaged T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Normal priority.
Jul 23 2019, 1:18 PM · Harbormaster
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

We could also consider these things:

Jul 23 2019, 1:10 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

So actual actionable stuff here is:

Jul 23 2019, 1:04 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?) to During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
Jul 23 2019, 12:59 PM · Ops, Restricted Project, Phacility

Jul 22 2019

epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Bumping max_allowed_packet to 1G in the server config resolved things. The export process then spent a long time doing a bin/files migration (which could use a progress bar, maybe) and is now doing a dump (which could too, although I'm less sure of how we'd build one).

Jul 22 2019, 11:52 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
190722 18:55:55 [Warning] Aborted connection 6 to db: '<instance>_differential' user: 'root' host: 'localhost' (Got a packet bigger than 'max_allowed_packet' bytes)
Jul 22 2019, 6:59 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I adjusted innodb_log_file_size to 1GB and attempted the import again, but ran into the same issue.

Jul 22 2019, 6:16 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?).
Jul 22 2019, 6:13 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 22 2019, 5:05 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 22 2019, 4:38 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "go away" on large dumps? to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size".
Jul 22 2019, 4:27 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

The "age of the last checkpoint" error appears to primarily implicate innodb_log_file_size, which is currently set to the default value (5MB):

Jul 22 2019, 4:26 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I'll also double check wait_timeout and interactive_timeout...

Jul 22 2019, 4:01 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Aha! The MySQL error log actually appears to have something useful:

Jul 22 2019, 3:55 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Run it with source ...;

Jul 22 2019, 3:54 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Unzip the dump before running it.

Jul 22 2019, 3:45 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Look at the unzipped dump and see if line 13935 is bad in some obvious way.

Jul 22 2019, 3:40 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Whatever the resolution is here might also motivate tailoring our restore/import instructions, since this error is pretty opaque and the next steps aren't obvious.)

Jul 22 2019, 3:21 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Internally, see also PHI1329.)

Jul 22 2019, 3:18 PM · Ops, Restricted Project, Phacility
epriestley triaged T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting as Low priority.
Jul 22 2019, 3:18 PM · Ops, Restricted Project, Phacility

Jul 20 2019

Krinkle awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Orange Medal token.
Jul 20 2019, 7:07 PM · Auth
Krinkle added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

See also https://trac.wildfiregames.com/wiki/Phabricator#Downloadapatch where a tedious workaround is needed in order to apply patches to a mirror of an SVN repo that is updated once a day:

Jul 20 2019, 5:51 PM · Restricted Project, Arcanist

Jul 19 2019

aklapper awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Love token.
Jul 19 2019, 11:07 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Not all of this has landed yet, but once it does:

Jul 19 2019, 10:55 PM · Auth
epriestley triaged T13346: Make "bin/auth lock" also lock "Customize Messages" in Auth as Low priority.
Jul 19 2019, 10:36 PM · Auth
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: Restricted Differential Revision.
Jul 19 2019, 10:30 PM · Auth