Page MenuHomePhabricator
Feed Advanced Search

Oct 5 2015

joshkel added a comment to T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.

I don't see any error trace in my web server logs (/var/log/apache2/error.log, /var/log/apache2/other_vhosts_access.log). I may have been unclear in my description: the error message appears at the top of the Diffusion commit page, but the page appears to work fine otherwise. It seems as if Diffusion is generating an error and catching and showing it but is otherwise working fine.

Oct 5 2015, 9:06 PM · Subversion, Diffusion
avivey added a comment to T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.

This install is giving a different error: rSVNTEST3:
svn: E155007: '/core/lib/phabricator/webroot' is not a working copy

Oct 5 2015, 8:58 PM · Subversion, Diffusion
chad added a comment to T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.

rP0db86cce7d was recently landed, you could check it that's the culprit by reverting just that commit. I presume you're pulling HEAD and not Stable?

Oct 5 2015, 8:53 PM · Subversion, Diffusion
avivey added a comment to T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.

Can you paste the full error trace? It would be in the webserver's error log.

Oct 5 2015, 8:51 PM · Subversion, Diffusion
joshkel added a comment to T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.

1.8.8 (as shipped with Ubuntu 14.04, in case that's relevant).

Oct 5 2015, 8:49 PM · Subversion, Diffusion
chad added a project to T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion: Subversion.
Oct 5 2015, 8:40 PM · Subversion, Diffusion
chad added a comment to T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.

What specific version of Subversion are you using?

Oct 5 2015, 8:40 PM · Subversion, Diffusion
joshkel updated the task description for T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.
Oct 5 2015, 8:23 PM · Subversion, Diffusion
joshkel created T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion.
Oct 5 2015, 8:21 PM · Subversion, Diffusion
• jayfar updated Q162: How to rescan a repository for commit comment changes? from to How to rescan a repository for commit comment changes?.
Oct 5 2015, 7:47 PM · Diffusion

Oct 2 2015

joshuaspence added projects to T9488: track accounts who did git clone: Facts, Diffusion.
Oct 2 2015, 8:54 AM · Diffusion, Facts

Sep 30 2015

chad added a project to Q154: Is it possible to "move" an external svn repository into Phabricator's hosting?: Diffusion.
Sep 30 2015, 12:17 AM · Diffusion

Sep 29 2015

epriestley closed T2015: Implement Drydock, a subtask of T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag, as Resolved.
Sep 29 2015, 3:01 PM · Drydock, Diffusion
epriestley closed T9481: Allow 'revision' section in history to be hidden when differential is uninstalled as Resolved by committing Restricted Diffusion Commit.
Sep 29 2015, 2:09 PM · Differential, Diffusion
epriestley claimed T9481: Allow 'revision' section in history to be hidden when differential is uninstalled.
Sep 29 2015, 1:22 PM · Differential, Diffusion
epriestley added a revision to T9481: Allow 'revision' section in history to be hidden when differential is uninstalled: Restricted Differential Revision.
Sep 29 2015, 1:22 PM · Differential, Diffusion
revi created T9481: Allow 'revision' section in history to be hidden when differential is uninstalled.
Sep 29 2015, 12:55 PM · Differential, Diffusion

Sep 28 2015

epriestley closed T8728: Setting "Notify/Publish" to "Disable Notifications, Feed and Herald" in Diffusion doesn't actually work as Resolved by committing Restricted Diffusion Commit.
Sep 28 2015, 6:17 PM · Diffusion
epriestley added a revision to T8728: Setting "Notify/Publish" to "Disable Notifications, Feed and Herald" in Diffusion doesn't actually work: Restricted Differential Revision.
Sep 28 2015, 6:02 PM · Diffusion
chad added a comment to T9475: "Readme.md"-Display does not render inline HTML.

Not as an upstream solution.

Sep 28 2015, 3:20 PM · Diffusion
timor added a comment to T9475: "Readme.md"-Display does not render inline HTML.

Would stripping the tags from the md file during rendering be a solution? It would be sufficient here...

Sep 28 2015, 3:18 PM · Diffusion
epriestley closed T9475: "Readme.md"-Display does not render inline HTML as Wontfix.

There's no way to do this. It would allow anyone with commit access to XSS other users and take over their accounts.

Sep 28 2015, 2:19 PM · Diffusion
timor updated the task description for T9475: "Readme.md"-Display does not render inline HTML.
Sep 28 2015, 1:57 PM · Diffusion
timor created T9475: "Readme.md"-Display does not render inline HTML.
Sep 28 2015, 1:56 PM · Diffusion

Sep 26 2015

chad closed Q152: Author information not matching as resolved.
Sep 26 2015, 4:58 PM · Diffusion
revi updated Q152: Author information not matching from to Author information not matching.
Sep 26 2015, 10:32 AM · Diffusion
chad removed a project from T2442: Show images in Diffusion diffs: OS Students 2013.
Sep 26 2015, 3:15 AM · Wikimedia, Diffusion
hach-que added a comment to T9301: 403 when trying to HTTP pull from Inactive repositoy.

I believe so? Maybe only some clients do?

Sep 26 2015, 12:23 AM · Diffusion
cspeckmim added a comment to T9301: 403 when trying to HTTP pull from Inactive repositoy.

According to http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html

Sep 26 2015, 12:21 AM · Diffusion
hach-que added a comment to T9301: 403 when trying to HTTP pull from Inactive repositoy.

403 is access denied, which Git clients treat as "bad credentials". When the repository is disabled, there's no credentials which will make the check pass.

Sep 26 2015, 12:10 AM · Diffusion

Sep 25 2015

epriestley added a comment to T9331: Configure test-plan per repository.

Oh, I guess there isn't actually a "test plan" Herald field. We could add one easily enough. I was thinking:

Sep 25 2015, 11:28 PM · Diffusion, Differential
joshuaspence added a comment to T9301: 403 when trying to HTTP pull from Inactive repositoy.

Either Phabricator should allow pulling from Inactive repositories (I see no reason to prevent pulls, but preventing pushes is probably reasonable),

Sep 25 2015, 11:25 PM · Diffusion
joshuaspence added a comment to T9331: Configure test-plan per repository.

Workarounds like the one above (or just writing similar Herald rules) seem reasonable to me, if not ideal.

Sep 25 2015, 11:23 PM · Diffusion, Differential
joshuaspence added a comment to T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.

I frequently use backticks in task/revision titles and would like for those to be rendered as monoscoped text, but this is a relatively small use case.

Sep 25 2015, 11:20 PM · Remarkup
epriestley added a comment to T9301: 403 when trying to HTTP pull from Inactive repositoy.

What status code do you feel is more appropriate? 403 seems quite reasonable to me.

Sep 25 2015, 5:22 PM · Diffusion
epriestley closed T9331: Configure test-plan per repository as Wontfix.

I don't currently plan to try to let fields be configured per-repository. This would be a lot of work to accommodate a fairly rare need, require substantial workflow changes, and doesn't seem to be particularly valuable. Workarounds like the one above (or just writing similar Herald rules) seem reasonable to me, if not ideal.

Sep 25 2015, 4:03 PM · Diffusion, Differential
epriestley renamed T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas from Build a summary mode Remarkup engine for constrained text areas to ⛄ Build a summary mode Remarkup engine for constrained text areas.
Sep 25 2015, 3:47 PM · Remarkup
epriestley added a comment to T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.

I think it's probably correct for task titles, Phriction document titles, etc., to not be Remarkup.

Sep 25 2015, 3:46 PM · Remarkup
epriestley updated subscribers of T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Sep 25 2015, 3:32 PM · Remarkup

Sep 24 2015

epriestley closed T9466: Self accept of commits only for certain projects? as Resolved.

It might become possible after T731, but this is a very rare need and not a good fit for the upstream except as part of more general changes in T731.

Sep 24 2015, 12:01 PM · Diffusion, Differential
maxie created T9466: Self accept of commits only for certain projects?.
Sep 24 2015, 11:49 AM · Diffusion, Differential

Sep 22 2015

epriestley closed T9458: No longer receiving emails from Phacility as Resolved.

Cool, glad things are working again.

Sep 22 2015, 10:34 PM · Custom Fields, Diffusion, Phacility Support
kislyuk added a comment to T9458: No longer receiving emails from Phacility.

Also, we certainly disable and re-enable users occasionally, so hopefully that will continue to be a supported use case.

Sep 22 2015, 10:31 PM · Custom Fields, Diffusion, Phacility Support
kislyuk added a comment to T9458: No longer receiving emails from Phacility.

@epriestley, I got a flood of emails starting at 1 PM, thanks! I'm not aware of any further issues with this.

Sep 22 2015, 10:31 PM · Custom Fields, Diffusion, Phacility Support
epriestley added a comment to T9458: No longer receiving emails from Phacility.

The queue has flushed so I think this is now resolved (there are no longer any publish actions backed up in the queue), can you let me know if you're still seeing issues when you have a chance?

Sep 22 2015, 8:24 PM · Custom Fields, Diffusion, Phacility Support
epriestley added a comment to T9458: No longer receiving emails from Phacility.

I've deployed this to repo001 (where this instance's daemons are located) and the queue appears to be flushing. I'd expect that you'll start receiving missing mail shortly (there are about 100 affected commits in the backlog). I'll follow up in a few minutes once things flush or otherwise stabilize.

Sep 22 2015, 8:08 PM · Custom Fields, Diffusion, Phacility Support
epriestley claimed T9458: No longer receiving emails from Phacility.
Sep 22 2015, 7:59 PM · Custom Fields, Diffusion, Phacility Support

Sep 21 2015

• tinytiongson closed Q141: Is there a way for a user to be known by Phabricator for previously imported repositories? as resolved.
Sep 21 2015, 5:43 AM · People, Diffusion
• frankth1 updated Q142: How to modify phabricator svn password? from to How to modify phabricator svn password?.
Sep 21 2015, 2:43 AM · Diffusion

Sep 18 2015

radioact1ve added a comment to T9443: "Public (No Login Required)" policy name still displayed..

Ah good point. I keep learning!

Sep 18 2015, 8:47 PM · Diffusion
chad closed T9443: "Public (No Login Required)" policy name still displayed. as Wontfix.
Sep 18 2015, 8:23 PM · Diffusion
chad added a comment to T9443: "Public (No Login Required)" policy name still displayed..

Public (No Login Required) is the name of the Policy control. I think it's more clear to use the exact name vs the short name.

Sep 18 2015, 8:21 PM · Diffusion
radioact1ve added a comment to T9443: "Public (No Login Required)" policy name still displayed..

I'm a complete noob to phabricator but I'm loving it! Found this while setting up my own instance. This is obviously of little to low priority but thought I'd drop it here just in case. As mentioned my skills are low with phabricator so searching Maniphest might have failed me if this is a duplicate.

Sep 18 2015, 7:57 PM · Diffusion
radioact1ve created T9443: "Public (No Login Required)" policy name still displayed..
Sep 18 2015, 7:56 PM · Diffusion
• tinytiongson updated Q141: Is there a way for a user to be known by Phabricator for previously imported repositories? from to Is there a way for a user to be known by Phabricator for previously imported repositories?.
Sep 18 2015, 2:58 PM · People, Diffusion

Sep 16 2015

chad added projects to Q137: API repository.create Hosted: Diffusion, Conduit.
Sep 16 2015, 3:52 PM · Conduit, Diffusion

Sep 13 2015

• ivan-1986 closed Restricted Maniphest Task, a subtask of T9319: Accessing image file in Diffusion must not generate error (unhandled exception), as Spite.
Sep 13 2015, 10:00 AM · Phacility, Diffusion, Phacility Support
• 123123123 added a project to T9191: Display repository status (e.g. "importing") in search results: Search.
Sep 13 2015, 2:47 AM · Search, Diffusion
• 123123123 removed a project from T9191: Display repository status (e.g. "importing") in search results: Search.
Sep 13 2015, 2:47 AM · Search, Diffusion
• 123123123 updated subscribers of T9191: Display repository status (e.g. "importing") in search results.
Sep 13 2015, 2:33 AM · Search, Diffusion
• 123123123 updated subscribers of T9191: Display repository status (e.g. "importing") in search results.
Sep 13 2015, 2:24 AM · Search, Diffusion

Sep 11 2015

chad added a parent task for T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas: T9398: External links in blurb not parsed when previewing (hovering) over the usernames.
Sep 11 2015, 5:46 PM · Remarkup
chad renamed T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas from Apply summary/header remarkup to commit message summaries to Build a summary mode Remarkup engine for constrained text areas.
Sep 11 2015, 5:45 PM · Remarkup
chad closed T9392: Paging UI is missing some padding for Diffusion history view as Resolved by committing Restricted Diffusion Commit.
Sep 11 2015, 4:00 PM · Design, Diffusion
chad added a revision to T9392: Paging UI is missing some padding for Diffusion history view: Restricted Differential Revision.
Sep 11 2015, 3:56 PM · Design, Diffusion
cspeckmim updated subscribers of T6118: Support for Mercurial extensions in hosted repositories.

@argylelabcoat - The last comment made by @epriestley is describing the use case of @bcran's need for the Blackbox extension available for Mercurial. See T9393 for their discussions. This task is a generic task for providing some support for Mercurial extensions in general. He was just relaying a summary of the conversation.

Sep 11 2015, 3:45 AM · Mercurial, Diffusion
argylelabcoat added a comment to T6118: Support for Mercurial extensions in hosted repositories.

The use case I was trying to accommodate was source control for projects with large binary files -- often multimedia files of some sort that get updated and integrated into a complex build process. Presently, SVN handles this better than HG or Git unless extensions such as hg largefiles or git-lfs are utilized

Sep 11 2015, 3:30 AM · Mercurial, Diffusion
epriestley added a comment to T9126: diffusion history page should give browse links for each committed version of the file.

D14096 has some screenshots of this and I've pushed it to this server. It may get some design followup but feels relatively reasonable to me in its current form.

Sep 11 2015, 3:23 AM · Prioritized, Diffusion, Restricted Project
epriestley added a comment to T6118: Support for Mercurial extensions in hosted repositories.

T9393 discusses the "Blackbox" extension. To summarize:

Sep 11 2015, 3:21 AM · Mercurial, Diffusion
angie moved T9126: diffusion history page should give browse links for each committed version of the file from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 11 2015, 3:20 AM · Prioritized, Diffusion, Restricted Project
epriestley closed T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision as Wontfix.

Cool, that sounds reasonable. Broadly:

Sep 11 2015, 3:18 AM · Mercurial, Diffusion
bcran added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

Since I have a workaround should I close this? Or, since my system's using Mercurial 3.5.1 should the code be skipping the workaround for older versions?

Sep 11 2015, 3:18 AM · Mercurial, Diffusion
bcran added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

Yup, I understand now: we enable the extension system-wide, so I'll update the hgrc in Phabricator's clone of the repo with "blackbox = !" to disable it.

Sep 11 2015, 3:03 AM · Mercurial, Diffusion
epriestley added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

Can you just disable the extension for Phabricator's copy of the repository?

Sep 11 2015, 3:01 AM · Mercurial, Diffusion
bcran added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

Why are you interested in running this extension?

Sep 11 2015, 3:00 AM · Mercurial, Diffusion
epriestley added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

The erroneous revision is because when hg log is invoked with --debug, it prints arbitrary messages to stdout which we can not distinguish from log output.

Sep 11 2015, 2:58 AM · Mercurial, Diffusion
epriestley added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

Why are you interested in running this extension?

Sep 11 2015, 2:50 AM · Mercurial, Diffusion
bcran renamed T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision from Importing Mercurial repo with blackbox extension enabled results in non-completing import and superfluous revision to Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.
Sep 11 2015, 2:49 AM · Mercurial, Diffusion
bcran created T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.
Sep 11 2015, 2:46 AM · Mercurial, Diffusion
epriestley closed T9126: diffusion history page should give browse links for each committed version of the file as Resolved by committing Restricted Diffusion Commit.
Sep 11 2015, 2:28 AM · Prioritized, Diffusion, Restricted Project
epriestley moved T9126: diffusion history page should give browse links for each committed version of the file from Backlog to The Queue on the Prioritized board.
Sep 11 2015, 2:05 AM · Prioritized, Diffusion, Restricted Project
epriestley claimed T9126: diffusion history page should give browse links for each committed version of the file.
Sep 11 2015, 2:04 AM · Prioritized, Diffusion, Restricted Project
epriestley added a revision to T9126: diffusion history page should give browse links for each committed version of the file: Restricted Differential Revision.
Sep 11 2015, 1:23 AM · Prioritized, Diffusion, Restricted Project

Sep 10 2015

chad claimed T9392: Paging UI is missing some padding for Diffusion history view.
Sep 10 2015, 7:31 PM · Design, Diffusion
epriestley created T9392: Paging UI is missing some padding for Diffusion history view.
Sep 10 2015, 7:30 PM · Design, Diffusion
angie moved T9126: diffusion history page should give browse links for each committed version of the file from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 10 2015, 5:18 PM · Prioritized, Diffusion, Restricted Project
angie moved T9108: Don't die horribly when large commit is pushed from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 10 2015, 4:55 PM · Diffusion, Restricted Project
angie closed T9108: Don't die horribly when large commit is pushed as Invalid.

The person who reported this is no longer around to provide more context.

Sep 10 2015, 4:55 PM · Diffusion, Restricted Project
epriestley closed T7959: Mercurial doesn't store HTTP passwords in config anymore as Resolved.

This should be resolved by D14092. Thanks for the fix!

Sep 10 2015, 12:44 PM · Diffusion, Mercurial
epriestley added a revision to T7959: Mercurial doesn't store HTTP passwords in config anymore: Unknown Object (Differential Revision).
Sep 10 2015, 12:42 PM · Diffusion, Mercurial
epriestley added a comment to T7959: Mercurial doesn't store HTTP passwords in config anymore.

@berenm suggests what is likely a simpler fix here:

Sep 10 2015, 12:30 PM · Diffusion, Mercurial
berenm added a comment to T7959: Mercurial doesn't store HTTP passwords in config anymore.

D14092 is a patch that doesn't require to store the password as clear text in the hgrc.

Sep 10 2015, 12:30 PM · Diffusion, Mercurial
epriestley updated subscribers of T7959: Mercurial doesn't store HTTP passwords in config anymore.
Sep 10 2015, 12:27 PM · Diffusion, Mercurial
epriestley merged task T9387: Diffusion is unable to pull updates from a Mercurial repository with HTTP authentication into T7959: Mercurial doesn't store HTTP passwords in config anymore.
Sep 10 2015, 12:27 PM · Diffusion, Mercurial
berenm created T9387: Diffusion is unable to pull updates from a Mercurial repository with HTTP authentication.
Sep 10 2015, 12:22 PM · Diffusion, Mercurial
epriestley added a comment to T9383: Support `git notes`.

No.

Sep 10 2015, 12:04 PM · KDE, Git, Diffusion
devurandom added a comment to T9383: Support `git notes`.

Is this related to T8936? I.e. similar cause?

Sep 10 2015, 12:03 PM · KDE, Git, Diffusion
epriestley added a comment to T9383: Support `git notes`.

We do not currently support git notes, and I had never heard of it before this task.

Sep 10 2015, 11:07 AM · KDE, Git, Diffusion
epriestley renamed T9383: Support `git notes` from Diffusion rejects git-notes objects to Support `git notes`.
Sep 10 2015, 11:07 AM · KDE, Git, Diffusion
SeMeKh created T9383: Support `git notes`.
Sep 10 2015, 7:21 AM · KDE, Git, Diffusion