Page MenuHomePhabricator
Feed Advanced Search

Aug 28 2019

epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

According to curl/symbols-in-versions (this is a text file in the repository):

Aug 28 2019, 6:46 PM · Infrastructure, libphutil
epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

A possible issue is that letting cURL pick a protocol might lead to it selecting HTTP/1.0 in some cases (how/when could it possibly do this? Only by hard-coding known-broken hostnames, I think?), and forcing it to use HTTP/1.1 could break those cases, so maybe I'll go spelunking here. I also can't immediately find a date of introduction for CURL_HTTP_VERSION_1_1 from the documentation.

Aug 28 2019, 6:44 PM · Infrastructure, libphutil
epriestley triaged T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock as Normal priority.
Aug 28 2019, 6:39 PM · Infrastructure, libphutil
epriestley added a comment to T13376: Write about "add more logging / monitoring / tests".

Another variation of this is "add more documentation", although I think the pattern around this one is more rarely a sort of "problem domain / solution domain mismatch" sort of issue and more often a "human communication" issue, usually with one of these two templates:

Aug 28 2019, 3:39 PM · Guides
epriestley closed T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE as Resolved by committing Restricted Diffusion Commit.
Aug 28 2019, 3:25 PM · Infrastructure
epriestley added a revision to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE: Unknown Object (Differential Revision).
Aug 28 2019, 3:19 PM · Infrastructure
epriestley added a comment to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE.

An adjacent issue is that PhabricatorMarkupCache is not currently marked as having cache persistence

Aug 28 2019, 2:06 PM · Infrastructure
epriestley closed T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation as Resolved by committing Restricted Diffusion Commit.
Aug 28 2019, 1:57 PM · EditEngine

Aug 27 2019

epriestley added a comment to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE.

loading a dump with missing data into a replica and then starting replication really causes issues

Aug 27 2019, 11:42 PM · Infrastructure
epriestley closed T13390: "bin/storage dump" should force the client character set to utf8mb4 when server supports utf8mb4 as Resolved by committing Restricted Diffusion Commit.
Aug 27 2019, 11:36 PM · Restricted Project, Infrastructure
epriestley edited the content of Changelog.
Aug 27 2019, 11:34 PM
epriestley created an object: 2019 Week 34 (Late August).
Aug 27 2019, 11:33 PM
epriestley added a revision to T13390: "bin/storage dump" should force the client character set to utf8mb4 when server supports utf8mb4: Unknown Object (Differential Revision).
Aug 27 2019, 10:33 PM · Restricted Project, Infrastructure
epriestley triaged T13390: "bin/storage dump" should force the client character set to utf8mb4 when server supports utf8mb4 as Normal priority.
Aug 27 2019, 10:25 PM · Restricted Project, Infrastructure
epriestley set the color for 🐳 to Red.
Aug 27 2019, 9:41 PM
epriestley added a revision to T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation: Unknown Object (Differential Revision).
Aug 27 2019, 2:57 PM · EditEngine
epriestley claimed T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation.
Aug 27 2019, 2:54 PM · EditEngine
epriestley triaged T13389: Editing Calendar forms can fail to build "newEditEngineSubtypeMap()" during transaction validation as Normal priority.
Aug 27 2019, 2:54 PM · EditEngine
epriestley closed T13388: Non-ideal view in mobile when using browser's "desktop" mode as Wontfix.

Use case from the thread is far off the beaten path ("The ideal version of the site on devices is a tiny version of the site on desktop"), so I'm not planning to put the time into investigating this unless substantially more interest emerges. I doubt the root issue is strictly a bug in Phabricator.

Aug 27 2019, 2:50 PM
epriestley updated the task description for T13134: Give Conduit API tokens PHIDs, transactions, and other modern capabilities.
Aug 27 2019, 3:41 AM · Conduit
epriestley added a comment to T13388: Non-ideal view in mobile when using browser's "desktop" mode.

I'd like to understand why this option is useful before making any changes here (that is, why wasn't the user happy with the site as it appeared by default on their device)?

Aug 27 2019, 3:36 AM

Aug 26 2019

epriestley closed T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, a subtask of T9303: Improve Phacility Onboarding/NUX, as Resolved.
Aug 26 2019, 2:48 PM · Phacility
epriestley closed T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, a subtask of T13366: Update Phortune to work better with "enterprise" billing/accounts departments, as Resolved.
Aug 26 2019, 2:48 PM · Phortune, Phacility
epriestley closed T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails as Resolved by committing Restricted Diffusion Commit.
Aug 26 2019, 2:48 PM · Phortune, Phacility

Aug 24 2019

epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 24 2019, 6:06 PM · Phortune, Phacility

Aug 23 2019

epriestley added a revision to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: Unknown Object (Differential Revision).
Aug 23 2019, 8:42 PM · Phortune, Phacility
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 23 2019, 8:42 PM · Phortune, Phacility
epriestley added a revision to T13367: Phortune "enterprise" update errata: Unknown Object (Differential Revision).
Aug 23 2019, 6:56 PM · Phortune, Phacility
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 23 2019, 4:14 PM · Phortune, Phacility
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 23 2019, 3:07 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 23 2019, 2:58 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 23 2019, 2:18 PM · Phortune, Phacility
epriestley triaged T13387: "Save Query" loses ApplicationSearch state in the URI, so "Cancel" may lead to the wrong place as Wishlist priority.
Aug 23 2019, 2:17 PM · ApplicationSearch
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 23 2019, 5:42 AM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 23 2019, 4:19 AM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

The "Merchant" profile screen is now somewhat inconsistent with the "Account" profile screen, and uses different icons for "Subscriptions" and "Orders".

Aug 23 2019, 4:03 AM · Phortune, Phacility
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 23 2019, 3:54 AM · Phortune, Phacility

Aug 22 2019

epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 22 2019, 9:59 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

We're also using inconsistent icons for "Order/Invoice/Receipt/Cart" in different interfaces. I'm going to standardize on this lovely purse, I think:

Aug 22 2019, 9:50 PM · Phortune, Phacility
epriestley added a comment to T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes.

sourceMachine is currently exposed only in the UI.

Aug 22 2019, 8:53 PM · Differential
epriestley closed T13386: Offset paging in "differential.query" can overheat with a nonsensical error message as Resolved by committing Restricted Diffusion Commit.
Aug 22 2019, 8:34 PM · ApplicationSearch, Differential
epriestley added a revision to T13386: Offset paging in "differential.query" can overheat with a nonsensical error message: Restricted Differential Revision.
Aug 22 2019, 8:21 PM · ApplicationSearch, Differential
epriestley added a revision to T13382: Update various user account CLI tools: Unknown Object (Differential Revision).
Aug 22 2019, 2:07 PM · People
epriestley added a revision to T13386: Offset paging in "differential.query" can overheat with a nonsensical error message: Unknown Object (Differential Revision).
Aug 22 2019, 3:16 AM · ApplicationSearch, Differential
epriestley triaged T13386: Offset paging in "differential.query" can overheat with a nonsensical error message as Normal priority.
Aug 22 2019, 2:45 AM · ApplicationSearch, Differential
epriestley added a revision to T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes: Unknown Object (Differential Revision).
Aug 22 2019, 2:16 AM · Differential
epriestley renamed T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes from Get rid of "sourcePath" and "host" as Diff attributes to Get rid of "sourcePath" and "sourceMachine" as Diff attributes.
Aug 22 2019, 2:11 AM · Differential
epriestley created T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes.
Aug 22 2019, 2:05 AM · Differential
epriestley closed T13384: When a custom field is "disabled", that should take precedence over the field being "required" as Resolved by committing Restricted Diffusion Commit.
Aug 22 2019, 1:03 AM · Custom Fields
epriestley added a revision to T13384: When a custom field is "disabled", that should take precedence over the field being "required": Unknown Object (Differential Revision).
Aug 22 2019, 1:02 AM · Custom Fields
epriestley updated the task description for T13384: When a custom field is "disabled", that should take precedence over the field being "required".
Aug 22 2019, 12:52 AM · Custom Fields
epriestley updated the task description for T13384: When a custom field is "disabled", that should take precedence over the field being "required".
Aug 22 2019, 12:47 AM · Custom Fields
epriestley triaged T13384: When a custom field is "disabled", that should take precedence over the field being "required" as Normal priority.
Aug 22 2019, 12:47 AM · Custom Fields

Aug 21 2019

epriestley closed T13382: Update various user account CLI tools as Resolved by committing Restricted Diffusion Commit.
Aug 21 2019, 12:58 AM · People
epriestley added a comment to T13382: Update various user account CLI tools.

./bin/user create

Aug 21 2019, 12:55 AM · People
epriestley added a revision to T13382: Update various user account CLI tools: Unknown Object (Differential Revision).
Aug 21 2019, 12:45 AM · People

Aug 20 2019

epriestley added a revision to T13382: Update various user account CLI tools: Unknown Object (Differential Revision).
Aug 20 2019, 9:45 PM · People
epriestley added a comment to T13382: Update various user account CLI tools.

You can automate at least some administrative actions...

Aug 20 2019, 9:35 PM · People
epriestley closed T13383: Provide a "drydock.resource.search" API method as Resolved by committing Restricted Diffusion Commit.
Aug 20 2019, 8:07 PM · Conduit, Drydock
epriestley added a revision to T13383: Provide a "drydock.resource.search" API method: Unknown Object (Differential Revision).
Aug 20 2019, 8:02 PM · Conduit, Drydock
epriestley edited the content of Changelog.
Aug 20 2019, 4:05 PM
epriestley created an object: 2019 Week 33 (Mid August).
Aug 20 2019, 4:04 PM
epriestley triaged T13383: Provide a "drydock.resource.search" API method as Normal priority.
Aug 20 2019, 3:52 PM · Conduit, Drydock
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 20 2019, 3:50 PM · Harbormaster
epriestley added a comment to T13382: Update various user account CLI tools.

(You can automate at least some administrative actions at an "omnipotent" power level with bin/conduit call --method user.edit nowadays, too, although accountadmin operated with interactive prompts so it's unlikely anyone automated on top of it.)

Aug 20 2019, 2:11 PM · People
epriestley triaged T13382: Update various user account CLI tools as Normal priority.
Aug 20 2019, 2:08 PM · People

Aug 17 2019

epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 17 2019, 2:51 AM · Phortune, Phacility

Aug 16 2019

epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

Stuff to fix with subscriptions:

Aug 16 2019, 10:51 PM · Phortune, Phacility
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 16 2019, 9:56 PM · Phortune, Phacility
epriestley added a revision to T13367: Phortune "enterprise" update errata: Unknown Object (Differential Revision).
Aug 16 2019, 9:56 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

if this is really an issue we could likely throw a rate limit on the action

Aug 16 2019, 5:44 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

This is sort-of-quasi-intentional

Aug 16 2019, 5:42 PM · Phortune, Phacility
epriestley added a comment to T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading.

A related issue is that when object A returns object B as an extended policy check and the user fails the extended policy check, the "PolicyException" dialog is misleading. It reads like this:

Aug 16 2019, 5:27 PM · Policy
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 16 2019, 5:08 PM · Phortune, Phacility
epriestley triaged T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading as Wishlist priority.
Aug 16 2019, 5:04 PM · Policy
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 16 2019, 4:38 PM · Phortune, Phacility
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 16 2019, 3:18 PM · Phortune, Phacility

Aug 15 2019

epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Aug 15 2019, 11:16 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 11:00 PM · Phortune, Phacility
epriestley triaged T13380: `git push` fatals when CWD does not exist as Low priority.
Aug 15 2019, 8:02 PM · Arcanist
epriestley closed T13379: Query panels executing bucketed queries with limits have unclear behavior as Wontfix.

Actually, since the modern behavior is reasonable by default (the "Limit" field is not required, and defaults to empty, and the panel works properly if "Limit" is left blank), users have to explicitly set a limit to get any unintuitive behavior here. If they do, they still get a "View All Results" hint.

Aug 15 2019, 7:47 PM · Dashboards
epriestley added a comment to T13379: Query panels executing bucketed queries with limits have unclear behavior.

The bucket limit is currently implemented like this:

Aug 15 2019, 7:43 PM · Dashboards
epriestley closed T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Resolved by committing Restricted Diffusion Commit.
Aug 15 2019, 7:22 PM · Projects
epriestley triaged T13379: Query panels executing bucketed queries with limits have unclear behavior as Low priority.
Aug 15 2019, 7:21 PM · Dashboards
epriestley added a revision to T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging: Unknown Object (Differential Revision).
Aug 15 2019, 7:02 PM · Projects
epriestley triaged T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Low priority.
Aug 15 2019, 7:00 PM · Projects
epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

It would also be nice to figure out Phortune permissions better here since this is a good opportunity to vet everything.

Aug 15 2019, 6:49 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 5:54 PM · Phortune, Phacility
avivey awarded T13376: Write about "add more logging / monitoring / tests" a Manufacturing Defect? token.
Aug 15 2019, 5:26 PM · Guides
epriestley triaged T13377: Write about "how to solve problems with program behavior" as Wishlist priority.
Aug 15 2019, 4:54 PM · Guides
epriestley triaged T13376: Write about "add more logging / monitoring / tests" as Wishlist priority.
Aug 15 2019, 4:42 PM · Guides

Aug 12 2019

epriestley added a revision to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: Unknown Object (Differential Revision).
Aug 12 2019, 10:58 PM · Phortune, Phacility
epriestley closed T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Resolved by committing Restricted Diffusion Commit.
Aug 12 2019, 7:46 PM · Daemons
epriestley added a revision to T13369: When a large number of commits are pushed to a repository, import them at lower priority: Unknown Object (Differential Revision).
Aug 12 2019, 7:09 PM · Daemons, Diffusion
epriestley added a revision to T13373: Clarify some messaging in `bin/config`: Unknown Object (Differential Revision).
Aug 12 2019, 6:22 PM · Setup, Config
epriestley added a revision to T13374: Daemons summary table is missing a cell in the "Temporary Failures" row: Unknown Object (Differential Revision).
Aug 12 2019, 6:12 PM · Daemons
epriestley added a comment to T731: Allow revisions to have alternate acceptance conditions.

See PHI1378, which is interested in "at least N", for N = 2.

Aug 12 2019, 5:42 PM · Restricted Project, Restricted Project, Differential
epriestley closed T13371: When instances change up/down status, start or stop their daemons as Resolved.

There was one issue with this: bin/host stop --instance X (which is rarely used, and has no prior automated callers) used --force, which stops all daemons on the host. The recent changes to the --force flag in D20601 also had an indirect impact here. I fixed this and redeployed the repo tier.

Aug 12 2019, 3:19 PM · Phacility
epriestley triaged T13375: Treat "'to'" address failures as permanent in Mailgun adapter as Low priority.
Aug 12 2019, 3:14 PM · Mail

Aug 11 2019

epriestley triaged T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Low priority.
Aug 11 2019, 8:24 PM · Daemons