Page MenuHomePhabricator
Feed Advanced Search

Dec 14 2015

epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 14 2015, 2:25 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 14 2015, 2:06 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 14 2015, 1:54 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 14 2015, 1:34 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

Yes, but I have some hesitance around adding "search for a string in another string" fields without building better infrastructure first. There's some discussion in D14411#161139.

Dec 14 2015, 11:04 AM · Maniphest, Phame, Owners, Arcanist, Conduit
nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

Ok, got it. Do you think it's reasonable to search using a package name?

Dec 14 2015, 6:21 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

We don't check that the path actually exists -- you might be searching for a deleted path that used to exist, or the repository might have a million branches and it only exists on one, and you might have a thousand different repositories too.

Dec 14 2015, 12:21 AM · Maniphest, Phame, Owners, Arcanist, Conduit
nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

You are right for the cases you described. But the case I mentinoed is that /src/infrastructure/PhabricatorEditor.php doesn't exist in both Arcanist and libutil.

Dec 14 2015, 12:18 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

That result looks correct to me -- if a package includes "/", that means it includes everything under "/" too. So if you search for /x/y/z.cpp, any package that owns /, /x/, /x/y/ or /x/y/z.cpp will be returned, since any package owning a parent also owns the path itself.

Dec 14 2015, 12:14 AM · Maniphest, Phame, Owners, Arcanist, Conduit

Dec 13 2015

nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

I can't reproduce that. Here's a search using "Path", which seems to work correctly:

Screen Shot 2015-12-11 at 3.23.39 PM.png (628×1 px, 76 KB)

Can you give me more details about how to reproduce the issue you're seeing?

Dec 13 2015, 11:56 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 6:21 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 6:06 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 3:49 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 3:36 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 3:03 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 1:29 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 12:06 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 10:47 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 10:35 AM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Restricted Differential Revision.
Dec 13 2015, 12:36 AM · Maniphest, Phame, Owners, Arcanist, Conduit

Dec 12 2015

chad closed T9927: Improve PhameHome, a subtask of T9360: Unbeta Phame, as Resolved.
Dec 12 2015, 9:34 PM · Phame
chad closed T9927: Improve PhameHome as Resolved.

Happy enough for v1 for me.

Dec 12 2015, 9:34 PM · Phame
chad added a revision to T9927: Improve PhameHome: Restricted Differential Revision.
Dec 12 2015, 9:33 PM · Phame
epriestley added a parent task for T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: T9897: Unbeta Feedback on Phame.
Dec 12 2015, 4:09 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a subtask for T9897: Unbeta Feedback on Phame: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
Dec 12 2015, 4:09 PM · Phame
epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 12 2015, 4:08 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

D14748 should fix the double feed stories.

Dec 12 2015, 2:52 AM · Phame
epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 12 2015, 2:51 AM · Phame
epriestley added a revision to T9360: Unbeta Phame: Restricted Differential Revision.
Dec 12 2015, 2:49 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

The behavior of TITLE and VISIBILITY are also wrong: they emit the current body text, not the body text at the time the change was made.

Dec 12 2015, 2:49 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

I think this is happening because both the "Title" and "Body" transactions are emitting text:

Dec 12 2015, 2:44 AM · Phame
joshuaspence added a project to T9968: Phame can fatal if handed an older-style URI: Phame.
Dec 12 2015, 2:26 AM · Phame, Bug Report
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 12 2015, 2:24 AM · Phame
epriestley added a comment to T9927: Improve PhameHome.

New blogs element is great :3

Dec 12 2015, 1:51 AM · Phame

Dec 11 2015

epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

I can't reproduce that. Here's a search using "Path", which seems to work correctly:

Dec 11 2015, 11:25 PM · Maniphest, Phame, Owners, Arcanist, Conduit
nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

You might already know, but I noticed that the owners search is broken if I use "path" instead of "Repositories" to query. Also it would be great if we can use the package name to search.

Dec 11 2015, 9:56 PM · Maniphest, Phame, Owners, Arcanist, Conduit
chad added a revision to T9927: Improve PhameHome: Restricted Differential Revision.
Dec 11 2015, 9:21 PM · Phame
epriestley added projects to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Conduit, Arcanist, Owners, Phame, Maniphest.
Dec 11 2015, 7:49 PM · Maniphest, Phame, Owners, Arcanist, Conduit
chad triaged T9927: Improve PhameHome as High priority.
Dec 11 2015, 7:01 PM · Phame
johnny-bit added a comment to T9927: Improve PhameHome.

Multiple different ways of proceeding. Current way, while not bad, has it's downsides.

Dec 11 2015, 6:13 PM · Phame
johnny-bit added a comment to T9897: Unbeta Feedback on Phame.

I eventually got this live. blog.phacility.com is a little plain now, but seems to work fine:

http://blog.phacility.com/

Dec 11 2015, 6:05 PM · Phame
chad updated subscribers of T9897: Unbeta Feedback on Phame.
Dec 11 2015, 5:27 PM · Phame
chad merged task T9961: http://blog.phacility.com/ gives `Unhandled Exception ("Exception")` when clicking on something that should be internal (like user name) into T9897: Unbeta Feedback on Phame.
Dec 11 2015, 5:27 PM · Phame, Phacility, Bug Report
tycho.tatitscheff created T9961: http://blog.phacility.com/ gives `Unhandled Exception ("Exception")` when clicking on something that should be internal (like user name).
Dec 11 2015, 5:20 PM · Phame, Phacility, Bug Report
epriestley added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 11 2015, 4:30 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

I eventually got this live. blog.phacility.com is a little plain now, but seems to work fine:

Dec 11 2015, 4:26 PM · Phame
chad moved T9927: Improve PhameHome from After Launch to Unbeta (v1) on the Phame board.
Dec 11 2015, 3:53 PM · Phame
chad added a subtask for T9360: Unbeta Phame: T9927: Improve PhameHome.
Dec 11 2015, 3:53 PM · Phame
chad added a parent task for T9927: Improve PhameHome: T9360: Unbeta Phame.
Dec 11 2015, 3:53 PM · Phame
epriestley added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 11 2015, 3:19 PM · Phame
chad renamed T9897: Unbeta Feedback on Phame from Address Evan Feedback on Phame to Unbeta Feedback on Phame.
Dec 11 2015, 2:55 PM · Phame
epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 11 2015, 2:53 PM · Phame
epriestley added a subtask for T9897: Unbeta Feedback on Phame: T6299: Remarkup links to objects in Phame break if a CNAME is set.
Dec 11 2015, 2:52 PM · Phame
epriestley added a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Dec 11 2015, 2:52 PM · Haskell.org, Remarkup, Phame
epriestley closed T9546: Phame "Oblivious" skin a few rough edges as Wontfix.

I'm planning to just remove skin support in T9897.

Dec 11 2015, 12:54 PM · Phame

Dec 10 2015

chad triaged T9897: Unbeta Feedback on Phame as High priority.
Dec 10 2015, 9:24 PM · Phame
chad triaged T9895: Update Phame Documentation as High priority.
Dec 10 2015, 9:24 PM · Phame
chad triaged T9360: Unbeta Phame as High priority.
Dec 10 2015, 9:24 PM · Phame

Dec 9 2015

chad added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 9 2015, 7:22 PM · Phame

Dec 8 2015

chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 8 2015, 11:18 PM · Phame
cspeckmim added a comment to T9927: Improve PhameHome.

Just clarifying, is this link is considered PhameHome?
https://secure.phabricator.com/phame/

Dec 8 2015, 11:18 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 8 2015, 11:05 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 8 2015, 10:56 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 8 2015, 10:56 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 8 2015, 9:47 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 8 2015, 9:38 PM · Phame
chad closed T9928: PhameHome should filter archived blogs, a subtask of T9360: Unbeta Phame, as Resolved.
Dec 8 2015, 3:24 AM · Phame

Dec 7 2015

chad added a subtask for T9360: Unbeta Phame: T9928: PhameHome should filter archived blogs.
Dec 7 2015, 10:49 PM · Phame
chad removed a parent task for T9360: Unbeta Phame: T9928: PhameHome should filter archived blogs.
Dec 7 2015, 10:49 PM · Phame
chad added a parent task for T9360: Unbeta Phame: T9928: PhameHome should filter archived blogs.
Dec 7 2015, 10:49 PM · Phame
chad updated the task description for T9927: Improve PhameHome.
Dec 7 2015, 10:37 PM · Phame
chad created T9927: Improve PhameHome.
Dec 7 2015, 10:26 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 7 2015, 9:31 PM · Phame

Dec 5 2015

Mnkras added a comment to T9897: Unbeta Feedback on Phame.

That is hypothetical, but for example, lets say Evan publishes a post with the following:
/blog/750/development_notes_2015_week_494949494949494/
but really meant for the slug to be
/blog/750/development_notes_2015_week_49/

Dec 5 2015, 5:55 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 5 2015, 5:53 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

Isn't that a hypothetical?

Dec 5 2015, 5:50 PM · Phame
Mnkras added a comment to T9897: Unbeta Feedback on Phame.

The easiest thing I can think of is simple typos/ bad c&p job

Dec 5 2015, 5:43 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

How are you expecting bad urls to get generated?

Dec 5 2015, 5:42 PM · Phame
Mnkras added a comment to T9897: Unbeta Feedback on Phame.

I have a concern about the /blog/<postid>/ignored_post_title/ approach, if the blog is indexed by Google, /blog/<postid>/ignored_post_title/ and /blog/<postid>/derpa/ will have the exact same content which Google penalizes.

Dec 5 2015, 5:10 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 5 2015, 4:48 PM · Phame
chad added a revision to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that.: Restricted Differential Revision.
Dec 5 2015, 4:40 PM · Phame, Mail
chad moved T9895: Update Phame Documentation from Backlog to Unbeta (v1) on the Phame board.
Dec 5 2015, 4:40 PM · Phame
chad moved T9897: Unbeta Feedback on Phame from Backlog to Unbeta (v1) on the Phame board.
Dec 5 2015, 4:40 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Restricted Differential Revision.
Dec 5 2015, 4:39 PM · Phame
johnny-bit added a comment to T9360: Unbeta Phame.

We use SNI and nobody says it's bad. Hell, people actually WANT SNI, since when hositng fo example small shop, you basically need SSL (even cheap one), but IP address (especially IPv4) is pricey per month. Most people when faced with "additional $$$/month with only benefit being customers using ancient software" or "0/month additional charges, only lose handfull of ancient software-using customers" chose 0/month 😉

Dec 5 2015, 3:30 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

(You could put more ignore stuff in the route too if you want the blog title.)

Dec 5 2015, 3:21 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

You can probably just do that by adding a route like this:

Dec 5 2015, 3:11 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

ah yeah thats good enough

Dec 5 2015, 3:07 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Yes, but blogs don't have slugs right now and blog post slugs are editable.

Dec 5 2015, 3:06 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

Also, I need to fix this:

Dec 5 2015, 3:05 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

is it relatively easy to do with routes, something like /b/blog_title/blog_post/

Dec 5 2015, 3:03 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

The story on SNI actually looks pretty reasonable (we're mostly just losing IE on XP and very old mobile devices), and should be more reasonable by the time we're thinking about whitelabeling main instances.

Dec 5 2015, 2:02 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

It's also possible that we can roll our own loadbalancers by assigning a lot of elastic IPs to a single host. This currently allows us to put ~240 domains on a host, at a cost of ~$4 per domain per month (for the elastic IP) instead of ~$20 per domain per month, but is more work. In contrast, SNI would let us put thousands of domains on a host with no cost per domain.

Dec 5 2015, 1:52 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

One other thing is that custom domains won't work on Phacility by default, and I don't think we can easily make them work (we can't just have users CNAME their DNS because we won't have the right SSL certificate). So maybe that's an argument for removing the feature or adding an option (ugh) to disable it.

Dec 5 2015, 1:46 PM · Phame
chad added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

I should probably add a subscriber setting for posts too, though.

Dec 5 2015, 3:20 AM · Phame, Mail
cspeckmim added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

Ah sorry, thanks for the clarification. I also just remembered that it's still prototype.

Dec 5 2015, 3:19 AM · Phame, Mail
chad added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

You have blogs set to ignore subscriber changes, not posts (not really a setting for that).

Dec 5 2015, 3:16 AM · Phame, Mail
chad closed T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that. as Resolved.
Dec 5 2015, 3:14 AM · Phame, Mail
chad added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

pasted_file (61×811 px, 23 KB)

Dec 5 2015, 3:14 AM · Phame, Mail
cspeckmim created T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..
Dec 5 2015, 2:56 AM · Phame, Mail