Page MenuHomePhabricator
Feed Advanced Search

Nov 13 2015

joshuaspence added a comment to T9773: Unit tests are slow.

MySQL version is 5.6.27-0ubuntu1.

Nov 13 2015, 10:54 PM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.
> time ./bin/storage upgrade --namespace testT9773 --force --no-adjust
Loading quickstart template...
Applying patch 'phabricator:db.xhpast'...
Applying patch 'phabricator:20150906.mailinglist.sql'...
Applying patch 'phabricator:20150930.drydock.log.1.sql'...
Applying patch 'phabricator:20151001.drydock.rname.1.sql'...
Applying patch 'phabricator:20151002.dashboard.status.1.sql'...
Applying patch 'phabricator:20151002.harbormaster.bparam.1.sql'...
Applying patch 'phabricator:20151009.drydock.auth.1.sql'...
Applying patch 'phabricator:20151010.drydock.auth.2.sql'...
Applying patch 'phabricator:20151013.drydock.op.1.sql'...
Applying patch 'phabricator:20151023.harborpolicy.1.sql'...
Applying patch 'phabricator:20151023.harborpolicy.2.php'...
Applying patch 'phabricator:20151023.patchduration.sql'...
Applying patch 'phabricator:20151030.harbormaster.initiator.sql'...
Applying patch 'phabricator:20151106.editengine.1.table.sql'...
Applying patch 'phabricator:20151106.editengine.2.xactions.sql'...
Applying patch 'phabricator:20151106.phame.post.mailkey.1.sql'...
Applying patch 'phabricator:20151106.phame.post.mailkey.2.php'...
Applying patch 'phabricator:20151107.phame.blog.mailkey.1.sql'...
Applying patch 'phabricator:20151107.phame.blog.mailkey.2.php'...
Applying patch 'phabricator:20151108.phame.blog.joinpolicy.sql'...
Applying patch 'phabricator:20151108.xhpast.stderr.sql'...
Applying patch 'phabricator:20151109.phame.post.comments.1.sql'...
Applying patch 'phabricator:20151109.repository.coverage.1.sql'...
Applying patch 'phabricator:20151109.xhpast.db.1.sql'...
Applying patch 'phabricator:20151109.xhpast.db.2.sql'...
Applying patch 'phabricator:20151110.daemonenvhash.sql'...
Storage is up to date. Use 'storage status' for details.
Declining to apply storage adjustments.
Nov 13 2015, 10:52 PM · Infrastructure
epriestley added a comment to T9773: Unit tests are slow.

I can't reproduce this either, nor does it reproduce on this install.

Nov 13 2015, 7:26 PM · Infrastructure
johnny-bit added a comment to T9773: Unit tests are slow.

generally, number of databases should not have impact on unit test performance... but nevertheless, it wouldn't hurt to prune database and maybe check local mysql performance settings? maybe You have something enabled/disabled that slows down mysql itself?

Nov 13 2015, 2:57 PM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.

One thing I noticed is that I have a large number of test databases locally.

Nov 13 2015, 11:26 AM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.

Here is a profile from running ManiphestTaskTestCase only (and without coverage): https://secure.phabricator.com/xhprof/profile/PHID-FILE-fkx2c4q3wtfn6cetww6s/

Nov 13 2015, 11:21 AM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.

See https://secure.phabricator.com/xhprof/profile/PHID-FILE-jfpnkcj4lvtjwojxmttl/, which shows the profile from running arc unit --everything.

Nov 13 2015, 11:14 AM · Infrastructure
joshuaspence closed T9778: Allow DarkConsole to be enabled based on policies as Wontfix.

Right, I see. I had darkconsole.always-on enabled.

Nov 13 2015, 11:10 AM · Infrastructure
chad added a comment to T9778: Allow DarkConsole to be enabled based on policies.

They have to enable it on their account in settings. It's not going to trigger accidentally before then.

Nov 13 2015, 6:45 AM · Infrastructure
joshuaspence added a comment to T9778: Allow DarkConsole to be enabled based on policies.

I'm not concern ed from a security point of view... I'd just rather not give people functionality that they don't need. Specifically, I'm sure someone will open DarkConsole by mistake and not know how to close it.

Nov 13 2015, 6:06 AM · Infrastructure
chad added a comment to T9778: Allow DarkConsole to be enabled based on policies.

It's enabled on this server, I can't think of any issues because of it.

Nov 13 2015, 5:15 AM · Infrastructure
chad added a comment to T9778: Allow DarkConsole to be enabled based on policies.

So, hypothetically, you're worried people will go into settings and enable Dark Console by choice and do.... what?

Nov 13 2015, 5:14 AM · Infrastructure
joshuaspence created T9778: Allow DarkConsole to be enabled based on policies.
Nov 13 2015, 4:55 AM · Infrastructure
Mnkras added a comment to T9773: Unit tests are slow.

Yea, im getting the same results as chad, tested on php 5.6, and php7 is super fast.

Nov 13 2015, 3:31 AM · Infrastructure

Nov 12 2015

joshuaspence added a comment to T9773: Unit tests are slow.

Running on a local MySQL server... I'll try to profile the tests later.

Nov 12 2015, 11:26 PM · Infrastructure
chad added a comment to T9773: Unit tests are slow.
macbook:phabricator chad$ arc unit --everything
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
   PASS  377ms   PhabricatorLibraryTestCase::testLibraryMap
   PASS  743ms   PhabricatorLibraryTestCase::testEverythingImplemented
   PASS   1.3s   PhabricatorLibraryTestCase::testMethodVisibility
   PASS    9ms★  DifferentialAdjustmentMapTestCase::testNearestMaps
   PASS    5ms★  DifferentialAdjustmentMapTestCase::testBasicMaps
   PASS    4ms★  DifferentialAdjustmentMapTestCase::testInverseMaps
   PASS    2ms★  DifferentialAdjustmentMapTestCase::testChainMaps
   PASS    1ms★  DifferentialDiffTestCase::testDetectCopiedOverlaidCode
   PASS   38ms★  DifferentialDiffTestCase::testDetectSlowCopiedCode
   PASS    3ms★  DifferentialDiffTestCase::testDetectCopiedCode
   PASS   <1ms★  DifferentialHunkTestCase::testMakeStructuredNewlineAbsent
   PASS   <1ms★  DifferentialHunkTestCase::testMakeStructuredOffset
   PASS   <1ms★  DifferentialHunkTestCase::testMakeStructuredChanges2
   PASS   <1ms★  DifferentialHunkTestCase::testMakeChanges
   PASS    1ms★  DifferentialHunkTestCase::testMakeStructuredChanges1
   PASS    2ms★  DifferentialHunkTestCase::testMakeStructuredNewlineAdded
   PASS    1ms★  DifferentialHunkTestCase::testMakeStructuredNewlineRemoved
   PASS   <1ms★  DiffusionURITestCase::testBlobDecodeFail
   PASS   <1ms★  DiffusionURITestCase::testURIGeneration
   PASS   <1ms★  DiffusionURITestCase::testBlobDecode
   PASS    2ms★  HeraldFieldTestCase::testGetAllFields
   PASS    2ms★  PhabricatorPHIDTypeTestCase::testGetPHIDTypeApplicationClass
   PASS   <1ms★  PhabricatorPHIDTypeTestCase::testGetAllTypes
   PASS   <1ms★  AlmanacNamesTestCase::testServiceOrDeviceNames
   PASS   <1ms★  AlmanacServiceTypeTestCase::testGetAllServiceTypes
   PASS   <1ms★  AphrontHTTPSinkTestCase::testHTTPSinkResponseSplitting
   PASS   <1ms★  AphrontHTTPSinkTestCase::testHTTPSinkStatusCode
   PASS   <1ms★  AphrontHTTPSinkTestCase::testHTTPSinkBasics
   PASS   <1ms★  AphrontHTTPSinkTestCase::testJSONContentSniff
   PASS   <1ms★  AphrontHTTPSinkTestCase::testHTTPHeaderNames
   PASS    6ms★  AphrontIsolatedDatabaseConnectionTestCase::testTransactionRollback
   PASS   <1ms★  AphrontIsolatedDatabaseConnectionTestCase::testTransactionStack
   PASS   <1ms★  AphrontIsolatedDatabaseConnectionTestCase::testIsolation
   PASS   <1ms★  AphrontIsolatedDatabaseConnectionTestCase::testInsertGeneratesID
   PASS   <1ms★  AphrontIsolatedDatabaseConnectionTestCase::testDeletePermitted
   PASS    3ms★  AphrontMySQLDatabaseConnectionTestCase::testConnectionFailures
   PASS    2ms★  AphrontRedirectResponseTestCase::testLocalRedirectURIs
   PASS   <1ms★  AphrontRequestTestCase::testRequestDataAccess
   PASS   <1ms★  AphrontRequestTestCase::testGetHTTPHeader
   PASS   <1ms★  AphrontRequestTestCase::testHostAttacks
   PASS   <1ms★  AphrontRequestTestCase::testFlattenRequestData
   PASS    2ms★  CalendarTimeUtilTestCase::testTimestampsStartDay
   PASS    1ms★  CalendarTimeUtilTestCase::testTimestampsAtMidnight
   PASS   <1ms★  CelerityPhysicalResourcesTestCase::testGetAll
   PASS   <1ms★  CelerityPostprocessorTestCase::testGetAllCelerityPostprocessors
   PASS    4ms★  CelerityResourceTransformerTestCase::testTransformation
   PASS    3ms★  ConduitAPIMethodTestCase::testLoadAllConduitMethods
   PASS   <1ms★  ConduitCallTestCase::testConduitPing
   PASS   <1ms★  ConduitCallTestCase::testConduitAuth
   PASS  157ms   ConpherenceRoomTestCase::testAddMessageWithFileAttachments
   PASS   58ms   ConpherenceRoomTestCase::testRoomParticipantDeletion
   PASS   35ms★  ConpherenceRoomTestCase::testNUserRoomCreate
   PASS   48ms★  ConpherenceRoomTestCase::testRoomParticipantAddition
   PASS   16ms★  ConpherenceRoomTestCase::testOneUserRoomCreate
   PASS   87ms   DifferentialChangesetParserTestCase::testDiffChangesets
   PASS    3ms★  DifferentialCommitMessageParserTestCase::testDifferentialCommitMessageParser
   PASS   <1ms★  DifferentialCommitMessageParserTestCase::testDifferentialCommitMessageParserNormalization
   PASS   <1ms★  DifferentialCustomFieldDependsOnParserTestCase::testParser
   PASS   <1ms★  DifferentialCustomFieldRevertsParserTestCase::testParser
   PASS   <1ms★  DifferentialHunkParserTestCase::testInclusionOfOldFileInNewCommentFromStartWithContext
   PASS   <1ms★  DifferentialHunkParserTestCase::testMultiLineNewComment
   PASS   <1ms★  DifferentialHunkParserTestCase::testOverlapAfterEndOfHunk
   PASS   <1ms★  DifferentialHunkParserTestCase::testInclusionOfOldFileInNewCommentFromStart
   PASS    2ms★  DifferentialHunkParserTestCase::testMissingContext
   PASS   <1ms★  DifferentialHunkParserTestCase::testOneLineOldComment
   PASS   <1ms★  DifferentialHunkParserTestCase::testOverlapFromStartOfHunk
   PASS   <1ms★  DifferentialHunkParserTestCase::testMultiLineOldComment
   PASS   <1ms★  DifferentialHunkParserTestCase::testOneLineNewComment
   PASS   <1ms★  DifferentialHunkParserTestCase::testInclusionOfNewFileInOldCommentFromStartWithContext
   PASS   <1ms★  DifferentialHunkParserTestCase::testCannotFindContext
   PASS   <1ms★  DifferentialHunkParserTestCase::testNoNewlineAtEndOfFile
   PASS   <1ms★  DifferentialHunkParserTestCase::testInclusionOfNewFileInOldCommentFromStart
   PASS  145ms   DifferentialParseRenderTestCase::testParseRender
   PASS   <1ms★  DiffusionCommitRemarkupRuleTestCase::testProjectObjectRemarkup
   PASS   <1ms★  DiffusionGitBranchTestCase::testRemoteBranchParser
   PASS   <1ms★  DiffusionGitFileContentQueryTestCase::testAuthorName
   PASS   <1ms★  DiffusionLowLevelMercurialPathsQueryTests::testCommandByVersion
   PASS   <1ms★  DiffusionMercurialWireProtocolTests::testFilteringBundle2Capability
   PASS    3ms★  DiffusionMercurialWireSSHTestCase::testMercurialClientWireProtocolParser
   PASS   <1ms★  DiffusionPathQueryTestCase::testExpandEdgeCases
   PASS   <1ms★  DiffusionPathQueryTestCase::testParentEdgeCases
   PASS   <1ms★  DiffusionSubversionWireProtocolTestCase::testSubversionWireProtocolParser
   PASS   <1ms★  DiffusionSubversionWireProtocolTestCase::testSubversionWireProtocolPartialFrame
   PASS   <1ms★  DoorkeeperBridgeJIRATestCase::testJIRABridgeRestAPIURIConversion
   PASS   <1ms★  DrydockBlueprintImplementationTestCase::testGetAllBlueprintImplementations
   PASS  102ms   HarbormasterAutotargetsTestCase::testGenerateHarbormasterAutotargets
   PASS   <1ms★  HarbormasterBuildStepImplementationTestCase::testGetImplementations
   PASS   <1ms★  HeraldRuleTestCase::testHeraldRuleExecutionOrder
   PASS    1ms★  HeraldTranscriptTestCase::testTranscriptTruncation
   PASS   <1ms★  LiskChunkTestCase::testSQLChunking
   PASS   <1ms★  LiskDAOTestCase::testCheckProperty
   PASS    2ms★  LiskFixtureTestCase::testTransactionalIsolation1of2
   PASS    5ms★  LiskFixtureTestCase::testReadableTransactions
   PASS    1ms★  LiskFixtureTestCase::testTransactionalIsolation2of2
   PASS    2ms★  LiskFixtureTestCase::testFixturesBasicallyWork
   PASS    6ms★  LiskFixtureTestCase::testGarbageLoadCalls
   PASS   12ms★  LiskFixtureTestCase::testCounters
   PASS    3ms★  LiskFixtureTestCase::testNonmutableColumns
   PASS   <1ms★  LiskIsolationTestCase::testEphemeral
   PASS   <1ms★  LiskIsolationTestCase::testMagicMethods
   PASS   <1ms★  LiskIsolationTestCase::testIsolatedWrites
   PASS   <1ms★  LiskIsolationTestCase::testIsolationContainment
   PASS    1ms★  ManiphestCustomFieldStatusParserTestCase::testParser
   PASS   <1ms★  ManiphestExcelFormatTestCase::testLoadAllFormats
   PASS  108ms   ManiphestTaskStatusTestCase::testManiphestStatusConfigValidation
   PASS   <1ms★  ManiphestTaskStatusTestCase::testManiphestStatusConstants
   PASS  227ms   ManiphestTaskTestCase::testTaskReordering
   PASS  150ms   ManiphestTaskTestCase::testTaskAdjacentBlocks
   PASS    1ms★  MetaMTAEmailTransactionCommandTestCase::testGetAllTypes
   PASS   <1ms★  NuanceSourceDefinitionTestCase::testGetAllTypes
   PASS   <1ms★  PHUIListViewTestCase::testAppendAfter
   PASS   <1ms★  PHUIListViewTestCase::testAppend
   PASS   <1ms★  PHUIListViewTestCase::testAppendLabel
   PASS   <1ms★  PHUIListViewTestCase::testAppendBefore
   PASS   <1ms★  PassphraseCredentialTypeTestCase::testGetAllTypes
   PASS  181ms   PhabricatorAccessControlTestCase::testControllerAccessControls
   PASS   <1ms★  PhabricatorAphrontViewTestCase::testHasChildren
   PASS   <1ms★  PhabricatorApplicationConfigurationPanelTestCase::testLoadAllPanels
   PASS    1ms★  PhabricatorApplicationSearchEngineTestCase::testGetAllEngines
   PASS   <1ms★  PhabricatorApplicationTestCase::testGetAllApplications
   PASS   <1ms★  PhabricatorAuthFactorTestCase::testGetAllFactors
   PASS    8ms★  PhabricatorAuthInviteTestCase::testInvalidInvite
   PASS  438ms   PhabricatorAuthInviteTestCase::testInviteWithKnownEmail
   PASS   19ms★  PhabricatorAuthInviteTestCase::testDuplicateInvite
   PASS   22ms★  PhabricatorAuthInviteTestCase::testInviteWithNewEmail
   PASS   <1ms★  PhabricatorCachesTestCase::testRequestCache
   PASS    2ms★  PhabricatorCalendarHolidayTestCase::testNthBusinessDay
   PASS  188ms   PhabricatorCelerityTestCase::testCelerityMaps
   PASS    6ms★  PhabricatorConduitTestCase::testConduitMethods
   PASS    9ms★  PhabricatorEdgeTestCase::testCycleDetection
   PASS   <1ms★  PhabricatorEdgeTypeTestCase::testGetAllTypes
   PASS   <1ms★  PhabricatorEnvTestCase::testOverrideOrder
   PASS   <1ms★  PhabricatorEnvTestCase::testRemoteURIForLink
   PASS   <1ms★  PhabricatorEnvTestCase::testDictionarySource
   PASS   <1ms★  PhabricatorEnvTestCase::testStackSource
   PASS   <1ms★  PhabricatorEnvTestCase::testOverrides
   PASS   <1ms★  PhabricatorEnvTestCase::testLocalURIForLink
   PASS    6ms★  PhabricatorEnvTestCase::testRemoteURIForFetch
   PASS   <1ms★  PhabricatorEnvTestCase::testGetEnvExceptions
   PASS   <1ms★  PhabricatorFactEngineTestCase::testLoadAllEngines
   PASS   <1ms★  PhabricatorFileStorageEngineTestCase::testLoadAllEngines
   PASS   46ms★  PhabricatorFileTestCase::testFileVisibility
   PASS    9ms★  PhabricatorFileTestCase::testFileStorageDelete
   PASS    5ms★  PhabricatorFileTestCase::testFileStorageReadWrite
   PASS    8ms★  PhabricatorFileTestCase::testFileStorageUploadDifferentFiles
   PASS   37ms★  PhabricatorFileTestCase::testFileTransformDelete
   PASS    6ms★  PhabricatorFileTestCase::testFileStorageUploadSameFile
   PASS    5ms★  PhabricatorFileTestCase::testReadWriteTtlFiles
   PASS   10ms★  PhabricatorFileTestCase::testFileStorageDeleteSharedHandle
   PASS   <1ms★  PhabricatorFileTransformTestCase::testGetAllTransforms
   PASS   14ms★  PhabricatorHandlePoolTestCase::testHandlePools
   PASS   <1ms★  PhabricatorHashTestCase::testHashForIndex
   PASS    1ms★  PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
   PASS   <1ms★  PhabricatorInfrastructureTestCase::testApplicationsInstalled
   PASS   <1ms★  PhabricatorIteratedMD5PasswordHasherTestCase::testHasher
   PASS   <1ms★  PhabricatorLocalTimeTestCase::testLocalTimeFormatting
   PASS   <1ms★  PhabricatorLocaleScopeGuardTestCase::testLocaleScopeGuard
   PASS   <1ms★  PhabricatorMailReceiverTestCase::testAddressSimilarity
   PASS   <1ms★  PhabricatorMetaMTAEmailBodyParserTestCase::testFalsePositiveForOnWrote
   PASS   <1ms★  PhabricatorMetaMTAEmailBodyParserTestCase::testQuotedTextStripping
   PASS    4ms★  PhabricatorMetaMTAEmailBodyParserTestCase::testEmailBodyCommandParsing
   PASS   <1ms★  PhabricatorMetaMTAMailBodyTestCase::testBodyRender
   PASS   <1ms★  PhabricatorMetaMTAMailBodyTestCase::testBodyRenderNoHerald
   PASS   30ms★  PhabricatorMetaMTAMailTestCase::testRecipients
   PASS   13ms★  PhabricatorMetaMTAMailTestCase::testThreadIDHeaders
   PASS   24ms★  PhabricatorMetaMTAMailTestCase::testMailSendFailures
   PASS    3ms★  PhabricatorMetaMTAReceivedMailTestCase::testDropSelfMail
   PASS   13ms★  PhabricatorMetaMTAReceivedMailTestCase::testDropUnknownSenderMail
   PASS   21ms★  PhabricatorMetaMTAReceivedMailTestCase::testDropDisabledSenderMail
   PASS    6ms★  PhabricatorMetaMTAReceivedMailTestCase::testDropUnreceivableMail
   PASS    6ms★  PhabricatorMetaMTAReceivedMailTestCase::testDropDuplicateMail
   PASS    2ms★  PhabricatorOAuthServerTestCase::testValidateSecondaryRedirectURI
   PASS   <1ms★  PhabricatorOAuthServerTestCase::testValidateRedirectURI
   PASS   15ms★  PhabricatorObjectListQueryTestCase::testObjectListQuery
   PASS   58ms   PhabricatorObjectMailReceiverTestCase::testDropInvalidObjectMail
   PASS   62ms   PhabricatorObjectMailReceiverTestCase::testDropUnconfiguredPublicMail
   PASS   61ms   PhabricatorObjectMailReceiverTestCase::testDropHashMismatchMail
   PASS   58ms   PhabricatorObjectMailReceiverTestCase::testDropUserMismatchMail
   PASS   <1ms★  PhabricatorOwnersPackageTestCase::testFindLongestPathsPerPackage
   PASS   <1ms★  PhabricatorPasswordHasherTestCase::testHasherSyntax
   PASS   <1ms★  PhabricatorPasswordHasherTestCase::testGetAllHashers
   PASS   <1ms★  PhabricatorPolicyCapabilityTestCase::testGetCapabilityMap
   PASS   14ms★  PhabricatorPolicyDataTestCase::testObjectPolicyRuleTaskAuthor
   PASS   17ms★  PhabricatorPolicyDataTestCase::testCustomPolicyRuleLunarPhase
   PASS   25ms★  PhabricatorPolicyDataTestCase::testCustomPolicyRuleUser
   PASS   25ms★  PhabricatorPolicyDataTestCase::testCustomPolicyRuleAdministrators
   PASS   18ms★  PhabricatorPolicyDataTestCase::testProjectPolicyMembership
   PASS   15ms★  PhabricatorPolicyDataTestCase::testObjectPolicyRuleThreadMembers
   PASS   12ms★  PhabricatorPolicyDataTestCase::testObjectPolicyRuleSubscribers
   PASS   <1ms★  PhabricatorPolicyTestCase::testUsersPolicy
   PASS   <1ms★  PhabricatorPolicyTestCase::testOmnipotence
   PASS   <1ms★  PhabricatorPolicyTestCase::testNoOnePolicy
   PASS   <1ms★  PhabricatorPolicyTestCase::testPolicyStrength
   PASS    2ms★  PhabricatorPolicyTestCase::testExtendedPolicyCycles
   PASS   <1ms★  PhabricatorPolicyTestCase::testMultipleCapabilities
   PASS   <1ms★  PhabricatorPolicyTestCase::testPublicPolicyDisabled
   PASS   <1ms★  PhabricatorPolicyTestCase::testPublicPolicyEnabled
   PASS   <1ms★  PhabricatorPolicyTestCase::testAdminPolicy
   PASS    2ms★  PhabricatorPolicyTestCase::testExtendedPolicies
   PASS    8ms★  PhabricatorPolicyTestCase::testAllQueriesBelongToActualApplications
   PASS    1ms★  PhabricatorPolicyTestCase::testOffsets
   PASS    2ms★  PhabricatorPolicyTestCase::testRejectInvalidPolicy
   PASS   <1ms★  PhabricatorPolicyTestCase::testLimits
   PASS   <1ms★  PhabricatorPolicyTestCase::testInvalidPolicyVisibleByOmnipotentUser
   PASS  166ms   PhabricatorProjectEditorTestCase::testJoinLeaveProject
   PASS   37ms★  PhabricatorProjectEditorTestCase::testViewProject
   PASS   47ms★  PhabricatorProjectEditorTestCase::testEditProject
   PASS   <1ms★  PhabricatorQueryOrderTestCase::testQueryOrderItem
   PASS   <1ms★  PhabricatorQueryOrderTestCase::testQueryOrderVector
   PASS   <1ms★  PhabricatorQueryOrderTestCase::testQueryOrderBadVectors
   PASS   <1ms★  PhabricatorRepositoryTestCase::testSubversionPathInfo
   PASS   <1ms★  PhabricatorRepositoryTestCase::testBranchFilter
   PASS   <1ms★  PhabricatorRepositoryTestCase::testRepositoryURIProtocols
   PASS   <1ms★  PhabricatorRepositoryTestCase::testFilterMercurialDebugOutput
   PASS   <1ms★  PhabricatorRepositoryURINormalizerTestCase::testGitURINormalizer
   PASS   <1ms★  PhabricatorRepositoryURINormalizerTestCase::testSVNURINormalizer
   PASS   15ms★  PhabricatorRepositoryURITestCase::testURIGeneration
   PASS   <1ms★  PhabricatorSearchEngineTestCase::testLoadAllEngines
   PASS   <1ms★  PhabricatorSetupCheckTestCase::testLoadAllChecks
   PASS    1ms★  PhabricatorSlugTestCase::testSlugNormalization
   PASS   <1ms★  PhabricatorSlugTestCase::testProjectSlugs
   PASS   <1ms★  PhabricatorSlugTestCase::testSlugDepth
   PASS   <1ms★  PhabricatorSlugTestCase::testSlugAncestry
   PASS   53ms   PhabricatorSpacesTestCase::testSpacesAnnihilation
   PASS   20ms★  PhabricatorSpacesTestCase::testSpacesUniqueDefaultSpace
   PASS   35ms★  PhabricatorSpacesTestCase::testSpacesPolicyFiltering
   PASS    9ms★  PhabricatorSpacesTestCase::testSpacesRequireNames
   PASS   24ms★  PhabricatorSpacesTestCase::testSpacesSeveralSpaces
   PASS    1ms★  PhabricatorTOTPAuthFactorTestCase::testTOTPCodeGeneration
   PASS   <1ms★  PhabricatorTimeTestCase::testPhabricatorTimeStack
   PASS    1ms★  PhabricatorTimeTestCase::testParseLocalTime
   PASS    3ms★  PhabricatorTriggerClockTestCase::testSubscriptionTriggerClock
   PASS    1ms★  PhabricatorTriggerClockTestCase::testDailyRoutineTriggerClockDaylightSavings
   PASS    1ms★  PhabricatorTriggerClockTestCase::testDailyRoutineTriggerClockLeapSecond
   PASS    2ms★  PhabricatorTriggerClockTestCase::testCDailyRoutineTriggerClockAdjustTimeOfDay
   PASS   <1ms★  PhabricatorTriggerClockTestCase::testNeverTriggerClock
   PASS   <1ms★  PhabricatorTriggerClockTestCase::testOneTimeTriggerClock
   PASS   <1ms★  PhabricatorTrivialTestCase::testAllIsRightWithTheWorld
   PASS   <1ms★  PhabricatorUnitsTestCase::testByteFormatting
   PASS   <1ms★  PhabricatorUnitsTestCase::testByteParsing
   PASS   <1ms★  PhabricatorUnitsTestCase::testDetailedDurationFormatting
   PASS   <1ms★  PhabricatorUserEditorTestCase::testRegistrationEmailDomain
   PASS   10ms★  PhabricatorUserEditorTestCase::testRegistrationEmailApplicationEmailCollide
   PASS    7ms★  PhabricatorUserEditorTestCase::testRegistrationEmailOK
   PASS   <1ms★  PhabricatorUserEditorTestCase::testRegistrationEmailInvalid
   PASS   <1ms★  PhabricatorUserEmailTestCase::testEmailValidation
   PASS   <1ms★  PhabricatorUserTestCase::testUsernameValidation
   PASS   <1ms★  PhabricatorWorkerBulkJobTestCase::testGetAllBulkJobTypes
   PASS   15ms★  PhabricatorWorkerTestCase::testTooManyTaskFailures
   PASS    9ms★  PhabricatorWorkerTestCase::testLeasedIsOldestFirst
   PASS    5ms★  PhabricatorWorkerTestCase::testPermanentTaskFailure
   PASS    4ms★  PhabricatorWorkerTestCase::testLeaseTask
   PASS    5ms★  PhabricatorWorkerTestCase::testExecuteTask
   PASS   10ms★  PhabricatorWorkerTestCase::testLeasedIsLowestPriority
   PASS    8ms★  PhabricatorWorkerTestCase::testNewBeforeLeased
   PASS    8ms★  PhabricatorWorkerTestCase::testOldestFirst
   PASS    6ms★  PhabricatorWorkerTestCase::testRequiredLeaseTime
   PASS    5ms★  PhabricatorWorkerTestCase::testTemporaryTaskFailure
   PASS    6ms★  PhabricatorWorkerTestCase::testWaitBeforeRetry
   PASS    5ms★  PhabricatorWorkerTestCase::testMultipleLease
   PASS  737ms   PhabricatorChangeParserTestCase::testSubversionForeignStubsParser
   PASS   2.4s   PhabricatorChangeParserTestCase::testSubversionParser
   PASS  514ms   PhabricatorChangeParserTestCase::testSubversionPartialParser
   PASS  427ms   PhabricatorChangeParserTestCase::testGitParser
   PASS   2.4s   PhabricatorChangeParserTestCase::testMercurialParser
   PASS  353ms   PhabricatorChangeParserTestCase::testSubversionValidRootParser
   PASS  178ms   PhabricatorWorkingCopyDiscoveryTestCase::testGitCommitDiscovery
   PASS  679ms   PhabricatorWorkingCopyDiscoveryTestCase::testMercurialCommitDiscovery
   PASS  281ms   PhabricatorWorkingCopyDiscoveryTestCase::testSubversionCommitDiscovery
   PASS   79ms   PhabricatorWorkingCopyPullTestCase::testGitPullBasic
   PASS   38ms★  PhabricatorWorkingCopyPullTestCase::testSVNPullBasic
   PASS  267ms   PhabricatorWorkingCopyPullTestCase::testHgPullBasic
   PASS   <1ms★  PhortuneCurrencyTestCase::testInvalidCurrencyFromString
   PASS   <1ms★  PhortuneCurrencyTestCase::testCurrencyFormatBareValue
   PASS   <1ms★  PhortuneCurrencyTestCase::testCurrencyFormatForDisplay
   PASS   <1ms★  PhortuneCurrencyTestCase::testAddCurrency
   PASS   <1ms★  PhortuneCurrencyTestCase::testCurrencyRanges
   PASS   <1ms★  PhortuneCurrencyTestCase::testCurrencyFromString
   PASS   <1ms★  PhortunePaymentProviderTestCase::testGetAllProviders
   PASS   <1ms★  PhrequentTimeBlockTestCase::testEndDeeperStratum
   PASS   <1ms★  PhrequentTimeBlockTestCase::testPreemptingEvents
   PASS   <1ms★  PhrequentTimeBlockTestCase::testTimelineSort
   PASS   <1ms★  PhrequentTimeBlockTestCase::testPopAcrossStrata
   PASS   <1ms★  PhrequentTimeBlockTestCase::testOngoingInterrupted
   PASS   <1ms★  PhrequentTimeBlockTestCase::testSumTimeSlices
   PASS   <1ms★  PhrequentTimeBlockTestCase::testOngoingPreempted
   PASS   <1ms★  PhrequentTimeBlockTestCase::testInstantaneousEvent
   PASS   <1ms★  PhrequentTimeBlockTestCase::testMergeTimeRanges
   PASS   <1ms★  PhrequentTimeBlockTestCase::testOngoing
   PASS   <1ms★  ProjectRemarkupRuleTestCase::testProjectObjectRemarkup
   PASS   <1ms★  QueryFormattingTestCase::testQueryFormatting
Nov 12 2015, 10:47 PM · Infrastructure
chad added a comment to T9773: Unit tests are slow.

where is your database?

Nov 12 2015, 10:43 PM · Infrastructure
joshuaspence created T9773: Unit tests are slow.
Nov 12 2015, 8:33 PM · Infrastructure

Nov 10 2015

epriestley closed T302: Phabricator exception stack traces should include a call-to-action as Wontfix.

Given the modern realities of support, I don't actually think we'd be better off by making it easier to submit stack traces. We also explicitly don't want surprise patches.

Nov 10 2015, 7:00 PM · Nuance, Infrastructure
epriestley added a project to T302: Phabricator exception stack traces should include a call-to-action: Nuance.
Nov 10 2015, 6:59 PM · Nuance, Infrastructure

Nov 4 2015

chad added a project to T8633: Modernize query engines: Modernization.
Nov 4 2015, 9:20 PM · Restricted Project, Modernization, Infrastructure
chad added a project to T8634: Modernize search engines: Modernization.
Nov 4 2015, 9:20 PM · Modernization, Infrastructure
chad added a project to T9690: Remove calls to methods deprecated by newPage(): Modernization.
Nov 4 2015, 9:17 PM · Contributor Onboarding, Modernization, Infrastructure
chad changed the visibility for T2312: Modifying PHP.
Nov 4 2015, 9:16 PM · Infrastructure

Nov 3 2015

epriestley added a revision to T9690: Remove calls to methods deprecated by newPage(): Restricted Differential Revision.
Nov 3 2015, 8:48 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley closed T5752: Navigation menus should work correctly on mobile by default as Resolved by committing Restricted Diffusion Commit.
Nov 3 2015, 6:11 PM · ApplicationEditor, Infrastructure, PHUI, Mobile

Nov 2 2015

epriestley added a comment to T9690: Remove calls to methods deprecated by newPage().

Let me get a little further with ApplicationEditor and throw a couple of reference diffs up here before anyone goes crazy with this, since I might still need to change some APIs.

Nov 2 2015, 9:11 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley added a revision to T9690: Remove calls to methods deprecated by newPage(): Restricted Differential Revision.
Nov 2 2015, 8:52 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley created T9690: Remove calls to methods deprecated by newPage().
Nov 2 2015, 8:32 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley added a revision to T5752: Navigation menus should work correctly on mobile by default: Restricted Differential Revision.
Nov 2 2015, 8:20 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
chad added a comment to T5752: Navigation menus should work correctly on mobile by default.

Happy to help with conversions if that's how this gets solved.

Nov 2 2015, 6:24 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a comment to T5752: Navigation menus should work correctly on mobile by default.

Actually I guess (2) already got pretty much fixed in D11340.

Nov 2 2015, 6:14 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a comment to T5752: Navigation menus should work correctly on mobile by default.

There are broadly two issues here:

Nov 2 2015, 6:12 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley claimed T5752: Navigation menus should work correctly on mobile by default.
Nov 2 2015, 6:10 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley moved T5752: Navigation menus should work correctly on mobile by default from Backlog to v1 on the ApplicationEditor board.
Nov 2 2015, 6:06 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a project to T5752: Navigation menus should work correctly on mobile by default: ApplicationEditor.
Nov 2 2015, 6:05 PM · ApplicationEditor, Infrastructure, PHUI, Mobile

Oct 27 2015

joshuaspence merged T9635: arc unit throws when there are no tests to run on PHP7 into T9640: Make Phabricator compatible with PHP7.
Oct 27 2015, 12:55 PM · Prioritized, Restricted Project, Infrastructure
joshuaspence added a revision to T9640: Make Phabricator compatible with PHP7: Restricted Differential Revision.
Oct 27 2015, 12:53 PM · Prioritized, Restricted Project, Infrastructure
joshuaspence updated subscribers of T9640: Make Phabricator compatible with PHP7.
Oct 27 2015, 12:52 PM · Prioritized, Restricted Project, Infrastructure
joshuaspence added a revision to T9640: Make Phabricator compatible with PHP7: Restricted Differential Revision.
Oct 27 2015, 12:43 PM · Prioritized, Restricted Project, Infrastructure
joshuaspence added a revision to T9640: Make Phabricator compatible with PHP7: Restricted Differential Revision.
Oct 27 2015, 8:22 AM · Prioritized, Restricted Project, Infrastructure
joshuaspence created T9640: Make Phabricator compatible with PHP7.
Oct 27 2015, 8:21 AM · Prioritized, Restricted Project, Infrastructure

Sep 24 2015

• ybv closed T9464: /bin/storage upgrade fails while applying a patch. as Resolved.

That fixed it!
Sorry for the late response. Thank you so much guys.

Sep 24 2015, 6:59 PM · Infrastructure, Maniphest
• ybv added a comment to T9464: /bin/storage upgrade fails while applying a patch..

@chad oops, sorry!
@epriestley Thanks, will give it a shot in a bit.

Sep 24 2015, 2:28 AM · Infrastructure, Maniphest
epriestley added a comment to T9464: /bin/storage upgrade fails while applying a patch..

A likely fix for this is now available in HEAD:

Sep 24 2015, 2:19 AM · Infrastructure, Maniphest
epriestley added a revision to T9464: /bin/storage upgrade fails while applying a patch.: Restricted Differential Revision.
Sep 24 2015, 1:43 AM · Infrastructure, Maniphest
epriestley added a comment to T9464: /bin/storage upgrade fails while applying a patch..

Oh, I'm wrong. It is idempotent, so we should be OK.

Sep 24 2015, 1:40 AM · Infrastructure, Maniphest
epriestley added a comment to T9464: /bin/storage upgrade fails while applying a patch..

(This migration isn't idempotent and I can't really test it thoroughly since we don't have year-old environments on hand, so there's going to be some level of guesswork here.)

Sep 24 2015, 1:39 AM · Infrastructure, Maniphest
epriestley claimed T9464: /bin/storage upgrade fails while applying a patch..
Sep 24 2015, 1:36 AM · Infrastructure, Maniphest
epriestley added a comment to T9464: /bin/storage upgrade fails while applying a patch..

I'll relax this migration, give me a few minutes. You have some sketchy data in your transaction history but we can just ignore it safely.

Sep 24 2015, 1:36 AM · Infrastructure, Maniphest
chad added a comment to T9464: /bin/storage upgrade fails while applying a patch..

Please let us handle task assignment.

Sep 24 2015, 1:32 AM · Infrastructure, Maniphest
chad placed T9464: /bin/storage upgrade fails while applying a patch. up for grabs.
Sep 24 2015, 1:31 AM · Infrastructure, Maniphest
• ybv assigned T9464: /bin/storage upgrade fails while applying a patch. to btrahan.
Sep 24 2015, 1:30 AM · Infrastructure, Maniphest
• ybv added a comment to T9464: /bin/storage upgrade fails while applying a patch..

@chad thanks for the quick response.
just to clarify,
you mean: upgrade new phabricator connected to a fresh db via /bin/storage upgrade-> restore data from old database -> run /bin/storage upgrade again?

Sep 24 2015, 1:29 AM · Infrastructure, Maniphest
chad added a comment to T9464: /bin/storage upgrade fails while applying a patch..

Nothing looks suspicious in the migration diff and no one else in 10 months has reported any issues here from searching around. You should be reading out arrays from the DB, maybe upgrade first before the move?

Sep 24 2015, 1:21 AM · Infrastructure, Maniphest
chad placed T9464: /bin/storage upgrade fails while applying a patch. up for grabs.
Sep 24 2015, 1:09 AM · Infrastructure, Maniphest
• ybv assigned T9464: /bin/storage upgrade fails while applying a patch. to joshuaspence.
Sep 24 2015, 12:48 AM · Infrastructure, Maniphest
• ybv created T9464: /bin/storage upgrade fails while applying a patch..
Sep 24 2015, 12:47 AM · Infrastructure, Maniphest

Sep 21 2015

epriestley added a comment to T8243: Escape console output more thoroughly.

Although we still have a long way to go here, after D14136 the result of the sequence of steps above is a little better:

Sep 21 2015, 7:47 PM · Infrastructure
epriestley added a revision to T8243: Escape console output more thoroughly: Restricted Differential Revision.
Sep 21 2015, 6:30 PM · Infrastructure

Sep 10 2015

angie moved T6930: Build Multimeter, a "why is Phabricator slow?" toolset from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 10 2015, 4:52 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley moved T8900: Copying contents from Phriction history diff doesn't work from Backlog to Next on the Phriction board.
Sep 10 2015, 12:56 AM · Restricted Project, Infrastructure, Differential, Phriction
epriestley closed T6930: Build Multimeter, a "why is Phabricator slow?" toolset as Resolved.

This exist and has at least been minimally useful in making it easier to improve package definitions, if nothing else.

Sep 10 2015, 12:38 AM · Restricted Project, Performance, Infrastructure, Phacility

Sep 9 2015

epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

I plan to try to collect the above into documentation to try to better explain this, but I don't think that has any specific impact on anyone. I don't plan to make any behavioral changes. I'm open to suggestions here, but we can't write a bin/time rewind and can not fully redact data which has been committed to the system and published to email and other external channels.

Sep 9 2015, 11:44 PM · Infrastructure, Restricted Project

Sep 6 2015

joshuaspence updated the task description for T9350: Add linter rules to detect undeclared class constants and methods.
Sep 6 2015, 9:28 PM · Infrastructure, Lint
joshuaspence updated the task description for T9350: Add linter rules to detect undeclared class constants and methods.
Sep 6 2015, 8:38 PM · Infrastructure, Lint
joshuaspence created T9350: Add linter rules to detect undeclared class constants and methods.
Sep 6 2015, 9:25 AM · Infrastructure, Lint

Sep 1 2015

epriestley added a revision to T5752: Navigation menus should work correctly on mobile by default: Restricted Differential Revision.
Sep 1 2015, 5:26 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a parent task for T5752: Navigation menus should work correctly on mobile by default: T9132: Build an ApplicationEditor abstraction.
Sep 1 2015, 5:22 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley closed T9300: phpqrcode may need updating as Resolved.

I can't find an upstream version of this external newer than the one we're using, so I think we can close this. Last update I see on Sourceforge is from 2010.

Sep 1 2015, 2:45 AM · Infrastructure
chad added a comment to T9300: phpqrcode may need updating.

OK to close?

Sep 1 2015, 2:01 AM · Infrastructure
chad added a project to T9300: phpqrcode may need updating: Infrastructure.
Sep 1 2015, 2:01 AM · Infrastructure

Aug 29 2015

joshuaspence added a project to T8830: `bin/remove destroy` is dangerous and leaves dangling edges: Infrastructure.
Aug 29 2015, 1:09 PM · Infrastructure, Restricted Project

Aug 25 2015

joshuaspence added a project to T8945: Data loss in task details due to concurrent edits: Infrastructure.
Aug 25 2015, 9:53 PM · Infrastructure

Aug 5 2015

chad merged T9083: Allow querying by project in Fund into T8633: Modernize query engines.
Aug 5 2015, 9:09 PM · Restricted Project, Modernization, Infrastructure

Aug 4 2015

epriestley merged T9061: Can't change view in UIExamples into T5752: Navigation menus should work correctly on mobile by default.
Aug 4 2015, 4:39 PM · ApplicationEditor, Infrastructure, PHUI, Mobile

Jul 23 2015

joshuaspence claimed T8692: Include request URL in error logs.
Jul 23 2015, 8:51 AM · Restricted Project, Aphront, Infrastructure

Jul 22 2015

joshuaspence added projects to T8900: Copying contents from Phriction history diff doesn't work: Differential, Infrastructure.
Jul 22 2015, 8:35 AM · Restricted Project, Infrastructure, Differential, Phriction

Jul 21 2015

epriestley closed T6859: It is difficult to keep track of used PhabricatorEdgeType IDs as Resolved by committing Restricted Diffusion Commit.
Jul 21 2015, 12:08 AM · Infrastructure
epriestley added a revision to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs: Restricted Differential Revision.
Jul 21 2015, 12:04 AM · Infrastructure

Jul 20 2015

chad updated subscribers of T5752: Navigation menus should work correctly on mobile by default.
Jul 20 2015, 5:35 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
chad changed the visibility for T302: Phabricator exception stack traces should include a call-to-action.
Jul 20 2015, 3:12 AM · Nuance, Infrastructure

Jul 3 2015

epriestley closed T8749: Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST as Resolved by committing Restricted Diffusion Commit.
Jul 3 2015, 8:03 PM · Infrastructure
chad closed T8099: Mid-2015 Phabricator Redesign, a subtask of T5752: Navigation menus should work correctly on mobile by default, as Resolved.
Jul 3 2015, 6:45 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley added a revision to T8749: Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST: Restricted Differential Revision.
Jul 3 2015, 5:47 PM · Infrastructure
epriestley created T8749: Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST.
Jul 3 2015, 5:40 PM · Infrastructure

Jun 29 2015

epriestley added a comment to T6915: Allow the Aphlict server to scale across multiple hosts.

See Phacility Cluster Network and Phacility Cluster Devices.

Jun 29 2015, 9:10 PM · Restricted Project, Infrastructure, Aphlict
epriestley added a comment to T6915: Allow the Aphlict server to scale across multiple hosts.

Oh, actually, our setup isn't quite like yours. There's one notification LB which sends traffic to one box. Instances just have nlb.phacility.com configured. So no web-tier proxying.

Jun 29 2015, 9:10 PM · Restricted Project, Infrastructure, Aphlict
epriestley added a comment to T6915: Allow the Aphlict server to scale across multiple hosts.

Yeah, this is what we do in the Phacility cluster. We have every instance sharing one notification server with software instancing right now and the box is <1% utilized.

Jun 29 2015, 9:08 PM · Restricted Project, Infrastructure, Aphlict
joshuaspence added a comment to T6915: Allow the Aphlict server to scale across multiple hosts.

Actually, I think you are correct.

Jun 29 2015, 9:07 PM · Restricted Project, Infrastructure, Aphlict
epriestley added a comment to T6915: Allow the Aphlict server to scale across multiple hosts.

Yes, but are you sure you need it? What are you seeing which indicates a notification server scaling issue?

Jun 29 2015, 9:04 PM · Restricted Project, Infrastructure, Aphlict
joshuaspence added a comment to T6915: Allow the Aphlict server to scale across multiple hosts.

Would this task be available for paid prioritization?

Jun 29 2015, 8:57 PM · Restricted Project, Infrastructure, Aphlict

Jun 27 2015

joshuaspence created T8692: Include request URL in error logs.
Jun 27 2015, 12:39 AM · Restricted Project, Aphront, Infrastructure

Jun 21 2015

joshuaspence created T8634: Modernize search engines.
Jun 21 2015, 11:54 AM · Modernization, Infrastructure
joshuaspence created T8633: Modernize query engines.
Jun 21 2015, 11:54 AM · Restricted Project, Modernization, Infrastructure

Jun 19 2015

joshuaspence closed T8477: `./bin/storage probe` truncate table names as Resolved by committing Restricted Diffusion Commit.
Jun 19 2015, 3:11 AM · Infrastructure

Jun 18 2015

joshuaspence added a revision to T8477: `./bin/storage probe` truncate table names: Restricted Differential Revision.
Jun 18 2015, 2:35 PM · Infrastructure
joshuaspence closed T8599: Exceptions about after extending from Phobject as Resolved by committing Restricted Diffusion Commit.
Jun 18 2015, 12:40 PM · Infrastructure, Drydock
joshuaspence claimed T8477: `./bin/storage probe` truncate table names.
Jun 18 2015, 10:51 AM · Infrastructure
mikn added a comment to T8599: Exceptions about after extending from Phobject.

Ah, that was an intermediate error that I got when I was trying to solve it. I'll implement the fix that you have in D13335 and it solves the problem I experienced. :)

Jun 18 2015, 9:03 AM · Infrastructure, Drydock