Page MenuHomePhabricator
Create Task
Maniphest T9300

phpqrcode may need updating
Closed, ResolvedPublic
Actions

Description

phpqrcode is an external library that hasn't been updated in 2-3 years. On line 2940 of externals/phpqrcode/phpqrcode.php, it simply says $ret; which I believe is a bug in phpqrcode.

This task is to look into either updating phpqrcode from upstream (if there's a newer rev available), and to attach the quick work around which is $ret = null;.

Revisions and Commits

rP Phabricator
ClosedD14019 Quickly fix phpqrcode syntax

Related Objects

Event Timeline

linuxfood created this task.Aug 31 2015, 8:36 PM
linuxfood updated the task description. (Show Details)
linuxfood added a subscriber: linuxfood.
linuxfood added a revision: D14019: Quickly fix phpqrcode syntax.Aug 31 2015, 8:56 PM
linuxfood added subscribers: epriestley, avivey.Aug 31 2015, 9:03 PM
epriestley mentioned this in rP9692c1f2c249: Quickly fix phpqrcode syntax.Aug 31 2015, 9:07 PM
chad added a project: Infrastructure.Sep 1 2015, 2:01 AM
chad added a subscriber: chad.

OK to close?

epriestley closed this task as Resolved.Sep 1 2015, 2:45 AM
epriestley claimed this task.

I can't find an upstream version of this external newer than the one we're using, so I think we can close this. Last update I see on Sourceforge is from 2010.

There are some forks (?) on GitHub but they barely seem to have any activity.

Phabricator · Built by Phacility