Page MenuHomePhabricator
Feed Advanced Search

Jun 5 2015

qgil updated subscribers of T8434: Accommodate the "Security" workflow.

I read the Nuance description, but it is still unclear to me what it does.

Jun 5 2015, 8:20 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Restricted Differential Revision.
Jun 5 2015, 3:49 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Restricted Differential Revision.
Jun 5 2015, 3:06 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Restricted Differential Revision.
Jun 5 2015, 2:56 AM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8434: Accommodate the "Security" workflow: Restricted Differential Revision.
Jun 5 2015, 2:19 AM · Wikimedia, Policy, Prioritized
epriestley created T8434: Accommodate the "Security" workflow.
Jun 5 2015, 2:18 AM · Wikimedia, Policy, Prioritized
epriestley moved T8424: Integrate Spaces into the core policy infrastructure from Backlog to Unprototype (v1) on the Spaces board.
Jun 5 2015, 1:48 AM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Restricted Differential Revision.
Jun 5 2015, 12:21 AM · Spaces, Wikimedia, Policy, Prioritized

Jun 4 2015

epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Restricted Differential Revision.
Jun 4 2015, 8:45 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley renamed T8424: Integrate Spaces into the core policy infrastructure from '"><img src=x onerror=alert(1);> to Integrate Spaces into the core policy infrastructure.
Jun 4 2015, 7:55 PM · Spaces, Wikimedia, Policy, Prioritized
• fdg renamed T8424: Integrate Spaces into the core policy infrastructure from Integrate Spaces into the core policy infrastructure to '"><img src=x onerror=alert(1);>.
Jun 4 2015, 7:55 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Restricted Differential Revision.
Jun 4 2015, 7:49 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Restricted Differential Revision.
Jun 4 2015, 7:36 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Restricted Differential Revision.
Jun 4 2015, 7:19 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Restricted Differential Revision.
Jun 4 2015, 6:59 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8424: Integrate Spaces into the core policy infrastructure: Restricted Differential Revision.
Jun 4 2015, 6:49 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8424: Integrate Spaces into the core policy infrastructure.
Jun 4 2015, 6:44 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 4 2015, 5:03 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T8377: Build the core "Spaces" Application, as Resolved.
Jun 4 2015, 2:31 AM · Spaces, Wikimedia, Policy

Jun 3 2015

epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 3 2015, 2:04 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a project to T8376: Develop Spaces (v1): Prioritized.

Since this is a relatively large task that's likely to end up with a hundred thousand subtasks, I'll try to summarize progress here periodically.

Jun 3 2015, 2:02 PM · Prioritized, Policy, Wikimedia, Spaces
qgil updated the task description for T8376: Develop Spaces (v1).
Jun 3 2015, 9:56 AM · Prioritized, Policy, Wikimedia, Spaces
qgil updated the task description for T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Jun 3 2015, 9:56 AM · Spaces, Policy, Wikimedia

Jun 2 2015

epriestley added a revision to T8377: Build the core "Spaces" Application: Restricted Differential Revision.
Jun 2 2015, 10:28 PM · Spaces, Wikimedia, Policy

Jun 1 2015

epriestley added a subtask for T8377: Build the core "Spaces" Application: T6367: Send email with recipient's language and access levels, not sender's.
Jun 1 2015, 11:04 PM · Spaces, Wikimedia, Policy
epriestley added a revision to T7703: Policy checks may execute incompletely for non-viewers: Restricted Differential Revision.
Jun 1 2015, 9:44 PM · Policy, Herald, Flags
epriestley added a parent task for T7703: Policy checks may execute incompletely for non-viewers: T8377: Build the core "Spaces" Application.
Jun 1 2015, 9:37 PM · Policy, Herald, Flags
epriestley added a subtask for T8377: Build the core "Spaces" Application: T7703: Policy checks may execute incompletely for non-viewers.
Jun 1 2015, 9:37 PM · Spaces, Wikimedia, Policy
btrahan added a revision to T8377: Build the core "Spaces" Application: Restricted Differential Revision.
Jun 1 2015, 9:25 PM · Spaces, Wikimedia, Policy
epriestley added a revision to T8377: Build the core "Spaces" Application: Restricted Differential Revision.
Jun 1 2015, 7:02 PM · Spaces, Wikimedia, Policy
epriestley added a revision to T8377: Build the core "Spaces" Application: Restricted Differential Revision.
Jun 1 2015, 6:54 PM · Spaces, Wikimedia, Policy
epriestley moved T8377: Build the core "Spaces" Application from Backlog to Unprototype (v1) on the Spaces board.
Jun 1 2015, 6:08 PM · Spaces, Wikimedia, Policy
epriestley moved T8376: Develop Spaces (v1) from Backlog to Unprototype (v1) on the Spaces board.
Jun 1 2015, 6:08 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley created T8377: Build the core "Spaces" Application.
Jun 1 2015, 6:06 PM · Spaces, Wikimedia, Policy
epriestley created T8376: Develop Spaces (v1).
Jun 1 2015, 5:36 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a revision to T7703: Policy checks may execute incompletely for non-viewers: Restricted Differential Revision.
Jun 1 2015, 2:44 PM · Policy, Herald, Flags

May 29 2015

qgil added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Oh, and about applications, Maniphest sure, followed by Files, then Mockups, perhaps. Paste... maybe.

May 29 2015, 3:10 PM · Spaces, Policy, Wikimedia
qgil added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

The description posted above looks like a good first version.

May 29 2015, 3:05 PM · Spaces, Policy, Wikimedia

May 28 2015

epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

That sounds like a poor field name for users...

May 28 2015, 6:08 PM · Spaces, Policy, Wikimedia
Krenair added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Objects which support spaces get a new "Space:" control on their edit forms.

May 28 2015, 5:14 PM · Spaces, Policy, Wikimedia
epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

In concrete terms, major items here that we know about specifically are:

May 28 2015, 5:05 PM · Spaces, Policy, Wikimedia

May 26 2015

epriestley updated the task description for T4830: Applications with Public permissions requiring users to login.
May 26 2015, 7:49 PM · Policy, People, Facts
epriestley removed a project from T4830: Applications with Public permissions requiring users to login: Owners.
May 26 2015, 7:49 PM · Policy, People, Facts
epriestley added a comment to T4830: Applications with Public permissions requiring users to login.

D13024 fixes this for Owners.

May 26 2015, 7:49 PM · Policy, People, Facts
epriestley moved T4830: Applications with Public permissions requiring users to login from Future to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Policy, People, Facts

May 23 2015

epriestley closed T8301: Unapproved users should be allowed to view objects just like anonymous users. as Wontfix.

Disabled users, unapproved users, and users who have not verified their email addresses may be able to increase their effective permissions by logging out. In some cases, normal users can do this too (if policies have been written which deny them access to resources, but permit public users access).

May 23 2015, 12:30 PM · FreeBSD, Policy
chad raised the priority of T8301: Unapproved users should be allowed to view objects just like anonymous users. from Wishlist to Needs Triage.
May 23 2015, 4:56 AM · FreeBSD, Policy
eadler renamed T8301: Unapproved users should be allowed to view objects just like anonymous users. from Unapproved users should be allowed to view objects just like anonymous. to Unapproved users should be allowed to view objects just like anonymous users..
May 23 2015, 4:10 AM · FreeBSD, Policy
eadler created T8301: Unapproved users should be allowed to view objects just like anonymous users..
May 23 2015, 4:07 AM · FreeBSD, Policy

May 22 2015

eadler added a project to T5681: Allow applications to provide custom policy rules: FreeBSD.
May 22 2015, 10:15 PM · FreeBSD, Policy

May 20 2015

epriestley closed T8110: project ACL dropdowns cause native & kappa twitch scrollbar to both appear as Resolved.

This is presumably obsoleted by the new scrollbar behavior.

May 20 2015, 2:24 PM · PHUI, Policy
epriestley updated subscribers of T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
May 20 2015, 1:30 PM · Spaces, Policy, Wikimedia

May 18 2015

btrahan closed T7923: Un-editable task was able to be closed as duplicate as Resolved by committing Restricted Diffusion Commit.
May 18 2015, 8:06 PM · Maniphest, Policy
btrahan claimed T7923: Un-editable task was able to be closed as duplicate.
May 18 2015, 5:43 PM · Maniphest, Policy

May 16 2015

btrahan added a revision to T7923: Un-editable task was able to be closed as duplicate: Restricted Differential Revision.
May 16 2015, 12:20 AM · Maniphest, Policy

May 13 2015

epriestley added a comment to T4830: Applications with Public permissions requiring users to login.

(@btrahan, you're the only repro I have, so don't change your profile picture!)

May 13 2015, 3:57 PM · Policy, People, Facts

May 8 2015

btrahan closed T8102: Conpherence room with visibility set to "Public" requires login, a subtask of T4830: Applications with Public permissions requiring users to login, as Resolved.
May 8 2015, 9:59 PM · Policy, People, Facts
btrahan closed T8102: Conpherence room with visibility set to "Public" requires login as Resolved by committing Restricted Diffusion Commit.
May 8 2015, 9:59 PM · Conpherence, Policy
btrahan added a revision to T8102: Conpherence room with visibility set to "Public" requires login: Restricted Differential Revision.
May 8 2015, 9:49 PM · Conpherence, Policy

May 7 2015

epriestley closed T6726: Files can recursively depend on one another, needing infinite policy checks as Resolved by committing Restricted Diffusion Commit.
May 7 2015, 10:58 PM · Files, Policy
chad added projects to T8110: project ACL dropdowns cause native & kappa twitch scrollbar to both appear: Policy, PHUI.
May 7 2015, 9:27 PM · PHUI, Policy
btrahan raised the priority of T8102: Conpherence room with visibility set to "Public" requires login from Normal to High.
May 7 2015, 8:22 PM · Conpherence, Policy
epriestley added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

Cool. D12756 should resolve this in the general case by terminating loops as soon as we try to re-load an object we're already loading.

May 7 2015, 7:06 PM · Files, Policy
epriestley added a revision to T6726: Files can recursively depend on one another, needing infinite policy checks: Restricted Differential Revision.
May 7 2015, 7:04 PM · Files, Policy
Unknown Object (User) added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

Deleting the rows resolved all the issues in T8119: Strange behaviour (possibly infinite recursion) on feeds and tasks.

May 7 2015, 7:01 PM · Files, Policy
Unknown Object (User) added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

The query is order by dateCreated desc, so technically they're last. :)

May 7 2015, 6:58 PM · Files, Policy
epriestley added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

Yep, should be safe (although the first two rows are probably the issue?).

May 7 2015, 6:57 PM · Files, Policy
Unknown Object (User) added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

@epriestley, is it safe to just delete these last two rows?

May 7 2015, 6:55 PM · Files, Policy
Unknown Object (User) added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

Definitely my problem:

MariaDB [phabricator_file]> select * from edge order by dateCreated desc limit 5;
+--------------------------------+------+--------------------------------+-------------+-----+--------+
| src                            | type | dst                            | dateCreated | seq | dataID |
+--------------------------------+------+--------------------------------+-------------+-----+--------+
| PHID-FILE-qffup4ki3h7houulve3d |   26 | PHID-FILE-qffup4ki3h7houulve3d |  1430992455 |   1 |   NULL |
| PHID-FILE-qffup4ki3h7houulve3d |   25 | PHID-FILE-qffup4ki3h7houulve3d |  1430992455 |   0 |   NULL |
| PHID-FILE-qffup4ki3h7houulve3d |   21 | PHID-USER-j4owr5kdhj243qlkhu6l |  1430992319 |   0 |   NULL |
| PHID-FILE-qffup4ki3h7houulve3d |   26 | PHID-TASK-mirzruisn77tw4zow52a |  1430991972 |   0 |   NULL |
| PHID-FILE-7oogy4flcolzbmxzoqy7 |   26 | PHID-TASK-aktaetetss24d24lnzsu |  1430930202 |   0 |   NULL |
+--------------------------------+------+--------------------------------+-------------+-----+--------+
5 rows in set (0.00 sec)
May 7 2015, 6:54 PM · Files, Policy
epriestley added a comment to T6726: Files can recursively depend on one another, needing infinite policy checks.

T8119 hit this in a non-theoretical way.

May 7 2015, 6:44 PM · Files, Policy
epriestley claimed T6726: Files can recursively depend on one another, needing infinite policy checks.
May 7 2015, 6:44 PM · Files, Policy
epriestley updated subscribers of T6726: Files can recursively depend on one another, needing infinite policy checks.
May 7 2015, 6:43 PM · Files, Policy
btrahan moved T8102: Conpherence room with visibility set to "Public" requires login from Backlog to v2 on the Conpherence board.
May 7 2015, 5:52 PM · Conpherence, Policy
btrahan claimed T8102: Conpherence room with visibility set to "Public" requires login.
May 7 2015, 5:51 PM · Conpherence, Policy

May 6 2015

qgil created T8102: Conpherence room with visibility set to "Public" requires login.
May 6 2015, 8:45 PM · Conpherence, Policy

May 5 2015

epriestley closed T7867: Display edit vs. view when custom policy is edited in dialog as Resolved by committing Restricted Diffusion Commit.
May 5 2015, 11:00 PM · Policy
epriestley added a revision to T7867: Display edit vs. view when custom policy is edited in dialog: Restricted Differential Revision.
May 5 2015, 12:52 PM · Policy

Apr 30 2015

epriestley added a parent task for T6502: Policy to define who can move cards in a workboard: T5474: Support workboard column triggers which activate when a task is dropped into a column.
Apr 30 2015, 10:53 AM · Projects, Wikimedia, Policy, Workboards

Apr 29 2015

eadler added a comment to T7979: Add ability to search by policy.

I think that use case is quite different: spaces provides some very high level isolation between various groups of users. These uses cases relate to projects/tasks/etc. within the same space.

Apr 29 2015, 6:24 AM · Policy, Search
chad added a comment to T7979: Add ability to search by policy.

T3820 is the main task you'll want to follow. I don't think we'd be likely to pursue any of these until we understand if they're needed after Spaces.

Apr 29 2015, 6:16 AM · Policy, Search
eadler added a comment to T7979: Add ability to search by policy.

There are a few problems or use cases that would be solved by this:

Apr 29 2015, 6:08 AM · Policy, Search
chad added a comment to T7979: Add ability to search by policy.

Please describe the problem you are having in Phabricator.

Apr 29 2015, 5:54 AM · Policy, Search
eadler created T7979: Add ability to search by policy.
Apr 29 2015, 5:32 AM · Policy, Search

Apr 27 2015

DeanBodart moved T6502: Policy to define who can move cards in a workboard from Important to In Progress on the Wikimedia board.
Apr 27 2015, 5:14 PM · Projects, Wikimedia, Policy, Workboards

Apr 26 2015

epriestley closed T7499: "New Build Plan" should be greyed out if not allowed by policy as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 7:45 PM · Policy, Harbormaster
lpriestley added a revision to T7499: "New Build Plan" should be greyed out if not allowed by policy: Restricted Differential Revision.
Apr 26 2015, 7:39 PM · Policy, Harbormaster
epriestley added a comment to T7499: "New Build Plan" should be greyed out if not allowed by policy.

It should setDisabled() + setWorkflow(); the former will grey it out (T7507 already had that part). Overall behavior should be the same.

Apr 26 2015, 7:21 PM · Policy, Harbormaster
lpriestley added a comment to T7499: "New Build Plan" should be greyed out if not allowed by policy.

Assuming that we want the same behavior as T7507: Should return to previous page after clicking "OK", not actually greying anything out?

Apr 26 2015, 7:20 PM · Policy, Harbormaster
epriestley closed T7507: Should return to previous page after clicking "OK" as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 7:01 PM · Policy
lpriestley added a revision to T7507: Should return to previous page after clicking "OK": Restricted Differential Revision.
Apr 26 2015, 6:58 PM · Policy
chad created T7923: Un-editable task was able to be closed as duplicate.
Apr 26 2015, 3:41 AM · Maniphest, Policy

Apr 23 2015

btrahan triaged T7867: Display edit vs. view when custom policy is edited in dialog as Low priority.

Perhaps obvious but things like a "Join" policy, User create policy, etc should render correctly too. Anything that inherits PhabricatorPolicyCapability is fair game.

Apr 23 2015, 7:51 PM · Policy
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T6860: Allow creation of parameterized application policies, as Resolved.
Apr 23 2015, 7:08 PM · Policy

Apr 21 2015

chad updated the task description for T7867: Display edit vs. view when custom policy is edited in dialog.
Apr 21 2015, 10:19 PM · Policy

Apr 20 2015

chad added a project to T7867: Display edit vs. view when custom policy is edited in dialog: Policy.
Apr 20 2015, 9:54 PM · Policy

Apr 13 2015

devurandom added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

See-Also: https://phabricator.wikimedia.org/T493

Apr 13 2015, 4:22 PM · Wikimedia, Policy

Apr 12 2015

epriestley merged task T7808: Guests can create a workboard for a project into T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".
Apr 12 2015, 7:45 PM · Policy, Projects
Mnkras created T7808: Guests can create a workboard for a project.
Apr 12 2015, 7:42 PM · Policy, Projects

Apr 11 2015

epriestley renamed T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects from Build JIRA-like "Namespaces" for putting global, default-deny walls around groups of unprivileged users to Implement top-level "Spaces" that provide policy isolation to groups of objects.
Apr 11 2015, 9:02 PM · Spaces, Policy, Wikimedia
epriestley added a comment to T7703: Policy checks may execute incompletely for non-viewers.

This seems structurally correct but is a lot of work.

Apr 11 2015, 8:23 PM · Policy, Herald, Flags