Page MenuHomePhabricator
Feed Advanced Search

Sep 5 2014

epriestley renamed T5979: Board drop target position is computed incorrectly after scrolling from Calculation of aggregate scroll offset incorrect on non-OSX OSes to Board drop target position is computed incorrectly after scrolling.
Sep 5 2014, 3:54 PM · Workboards
epriestley added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

Sorry, I got this wrong. The issue reproduces for me. I was fixated on the "ghost" behavior because we changed it recently and D10186 fixed a real bug with it, and it took a while for it to sink in after watching your video.

Sep 5 2014, 3:54 PM · Workboards
epriestley closed T5674: Add the ability to apply permissions on a workboard for rearranging cards, with some people being read only as Resolved.

Assuming T4807 covered the bulk of this issue by stopping accidental priority changes, but yell/reopen if it's still a problem.

Sep 5 2014, 2:26 PM · Workboards, Maniphest
epriestley renamed T5979: Board drop target position is computed incorrectly after scrolling from Calculation of aggregate scroll offset incorrect in Ubuntu to Calculation of aggregate scroll offset incorrect on non-OSX OSes.
Sep 5 2014, 11:58 AM · Workboards
• cpa199 added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

This is not Ubuntu specific, I just tried this on Windows in Chrome and have the exact same issue.

Sep 5 2014, 11:53 AM · Workboards
epriestley renamed T5979: Board drop target position is computed incorrectly after scrolling from Scrolling the page while dragging a task on a workboard causes the new position of the task to be incorrect. to Calculation of aggregate scroll offset incorrect in Ubuntu.
Sep 5 2014, 11:42 AM · Workboards
• cpa199 added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

Here is an mp4, and you'll see the difference compared to your video. I'm dragging up and down in a long list of a single column.

Sep 5 2014, 11:38 AM · Workboards
epriestley added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

Here's what I see locally on Chrome in OSX :

Sep 5 2014, 11:31 AM · Workboards
• cpa199 added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

It's a windows video as that was the quickest way for me to record. It's
actually running in an Ubuntu VM however screen cap in VM seems to just
record a black screen. I'll try and find a working video capture app that
will record mp4 or something and re-upload.

Sep 5 2014, 11:31 AM · Workboards
epriestley added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

Hmm, I don't seem to be able to play that video in any program on my system.

Sep 5 2014, 11:28 AM · Workboards
• cpa199 reopened T5979: Board drop target position is computed incorrectly after scrolling as "Open".

I've reopened it as either there is something that I'm missing or this issue still exists. I'm happy to provide you any more information you need but for me this makes the workboards pretty unusable once they have a realistic amount of work in.

Sep 5 2014, 10:01 AM · Workboards
• cpa199 added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

I have updated to the most recent code, checked I've got the changes by comparing to the diffs linked above, however I can still fully replicate this issue.
I've loaded the javascript for DraggableList.js in my browser and ensured it has the changes you've made (to ensure there is no hidden caching), turned off entirely any browser caching but I still have the issue.
I'm willing to believe I've done something wrong but I'm afraid I'm running out of things that it could be.

Sep 5 2014, 9:58 AM · Workboards

Sep 4 2014

epriestley closed T5993: Allow columns in workboards to be hidden or shown directly from column header menu as Resolved.

Closed by commit rPd8e3f2edf223.

Sep 4 2014, 7:48 PM · Workboards
epriestley closed T5979: Board drop target position is computed incorrectly after scrolling as Resolved.

Closed by commit rPaaa08edb1251.

Sep 4 2014, 7:48 PM · Workboards
epriestley added a revision to T5993: Allow columns in workboards to be hidden or shown directly from column header menu: Restricted Differential Revision.
Sep 4 2014, 6:43 PM · Workboards
• cpa199 added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

I'm going to do another installation from latest source, I suspect I must have made a mistake if you can't reproduce. I'll do it when I get into work tomorrow.

Sep 4 2014, 6:28 PM · Workboards
epriestley claimed T5993: Allow columns in workboards to be hidden or shown directly from column header menu.
Sep 4 2014, 6:25 PM · Workboards
epriestley added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

D10416 fixes the jumpiness when scrolling. I can't reproduce the original issue, per se, exactly as described -- works fine for me in both Firefox and Chrome.

Sep 4 2014, 6:19 PM · Workboards
epriestley added a revision to T5979: Board drop target position is computed incorrectly after scrolling: Restricted Differential Revision.
Sep 4 2014, 6:13 PM · Workboards
epriestley claimed T5979: Board drop target position is computed incorrectly after scrolling.
Sep 4 2014, 6:04 PM · Workboards

Sep 3 2014

chad added a comment to T5475: Maybe make clicking a task on workboards edit it.

Ah sorry, I misunderstood the ticket then when it mentioned editing like Trello. In theory we could swap and make the title pull up edit and then switch the side pencil to maybe a 'document' or something that pulls up the timeline in a dialog.

Sep 3 2014, 11:49 PM · Workboards
epriestley renamed T5475: Maybe make clicking a task on workboards edit it from Make clicking a task on workboards edit it to Maybe make clicking a task on workboards edit it.
Sep 3 2014, 11:44 PM · Workboards
epriestley reopened T5475: Maybe make clicking a task on workboards edit it as "Open".

(I want to at least try this and see how it feels, it also interacts with T5523 if we want to add a per-task context menu.)

Sep 3 2014, 11:44 PM · Workboards
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

It could definitely be clearer. I think unifying the tag UI a bit may help.

Sep 3 2014, 8:48 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
qgil added a comment to T6027: Way to edit which column a task is in from the task itself.

Ooops! I had missed that. Was it a link at the beginning? Never mind. :)

Sep 3 2014, 8:44 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

There is a direct link from the task page to the related workboards (the column name):

Sep 3 2014, 8:29 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
qgil added a comment to T6027: Way to edit which column a task is in from the task itself.

A direct link from the task page to the related workboards would save all this complexity and would reduce the jumps needed from 2 to 1. That would be good enough for me.

Sep 3 2014, 8:26 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

Particularly, neither of the "Change Columns" UIs actually satisfy the original request here.

Sep 3 2014, 7:45 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

Or replace the "Edit" link with a contextual menu (maybe T5475) and implement a "Move To..." action which has you select a column and optionally make other common changes, like adding a comment. Some discussion in T5523.

Sep 3 2014, 7:43 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

For the original ask it seems T5474 with a "leave a comment" trigger also gets the job done.

Sep 3 2014, 7:42 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

Yeah, I think it has to either look like this (a "Change Columns" dialog):

Sep 3 2014, 7:39 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T5475: Maybe make clicking a task on workboards edit it.

I don't imagine click-to-edit-the-title-inline, my thinking was more like the entire card becomes the edit button. Right now, you have to click a fairly tiny icon on the right hand side, and there's no real reason we couldn't let you click anywhere on the card, with some caveats.

Sep 3 2014, 7:29 PM · Workboards
btrahan added a comment to T6027: Way to edit which column a task is in from the task itself.

...so is this even something we should build? The feature as described sounds wildly complicated and we haven't even described the very specific UI piece you need to move a task between MULTIPLE columns at once. I guess in the "Action" box this would be like the "Action" is "Change Columns" and when you select it you get a three-ish column thing where on the left is project, middle is current column and on the right is the column you want to move it to with placeholder text like "no change"?

Sep 3 2014, 7:23 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

T6027 discusses adding a column-move interface, which might change the column a task is in on several boards at once. This has some implications for the transaction record and other pieces of this feature.

Sep 3 2014, 6:31 PM · Workboards (v3), Restricted Project
cburroughs added a comment to T5240: Dragging items (cards, panels) could be better in Workboards.

I presume per column scrolling would change this behavior, but right now if there is a single long list I end up with double vertical scrollbars and can't use pagedown/down-arrow etc until I click somewhere.

Sep 3 2014, 5:59 PM · Projects (v3), Workboards
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

A task can be on a bunch of workboards, so if this is a link that pops a dialog, it has to list all the boards it's on -- more "Change Columns" (although that doesn't sound great to me) than "Move to Column".

Sep 3 2014, 5:24 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
chad added a comment to T6027: Way to edit which column a task is in from the task itself.

Yes, we need a way to move a task to a column from "not in a workboard" view, this can be actions, edit task, or both.

Sep 3 2014, 4:29 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
chad closed T5475: Maybe make clicking a task on workboards edit it as Wontfix.

I think this is safe to close. I don't see much gained in being able to easily edit the title, when there a dozen other fields to possibly edit. The current state with edit icon seems to work reasonably well.

Sep 3 2014, 4:25 PM · Workboards
btrahan raised the priority of T6027: Way to edit which column a task is in from the task itself from Low to Needs Triage.

(Putting this back to Needs Triage. I want to make sure any "triaged" task is actionable.)

Sep 3 2014, 4:21 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
btrahan added a comment to T6027: Way to edit which column a task is in from the task itself.

So how would this UI work? There's a new "Action" called "Move To Column" or something? Apologies if this is a dumb question.

Sep 3 2014, 4:18 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
chad triaged T6027: Way to edit which column a task is in from the task itself as Low priority.
Sep 3 2014, 4:16 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
qgil added a comment to T6027: Way to edit which column a task is in from the task itself.

I also have to say that it's not convenient having to leave a task in order access a workboard when you know already to which column you want the task to go. A minor thing, though.

Sep 3 2014, 3:44 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
cburroughs created T6027: Way to edit which column a task is in from the task itself.
Sep 3 2014, 3:40 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest

Sep 2 2014

chad triaged T5979: Board drop target position is computed incorrectly after scrolling as Normal priority.

I can sorta reproduce this, if you grab a card, and use the scroll wheel only, the position does not recalculate until the mouse moves. Once you mouse move, the position updates.

Sep 2 2014, 5:30 PM · Workboards
chad triaged T5993: Allow columns in workboards to be hidden or shown directly from column header menu as Low priority.
Sep 2 2014, 5:28 PM · Workboards

Aug 27 2014

epriestley added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

Okay, I'll see if I can reproduce this. Maybe I didn't test D10186 properly.

Aug 27 2014, 3:47 PM · Workboards
• cpa199 added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

I've just done a pull on all 3 projects (of course shutting down apache and phd daemons prior to doing this) and I did get some updates, however it unfortunately didn't fix the issue and I didn't originally install it more than a week ago which looks like it was after this fix.
I will restart the entire server when I can just to make doubly sure I've not missed something but currently it looks in my case like it is still happening.

Aug 27 2014, 3:45 PM · Workboards
epriestley added a comment to T5979: Board drop target position is computed incorrectly after scrolling.

Are you up to date? D10186 was supposed to fix this.

Aug 27 2014, 3:37 PM · Workboards
• cpa199 created T5979: Board drop target position is computed incorrectly after scrolling.
Aug 27 2014, 3:26 PM · Workboards

Aug 22 2014

epriestley closed T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything", a subtask of T5100: Show work board column names as part of task basic information in query results and reference link popups, as Resolved.
Aug 22 2014, 8:28 PM · Hovercards, Maniphest, Workboards
epriestley closed T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything" as Resolved.

This seems to be working OK. I'm going to close this out; you can find some followups here:

Aug 22 2014, 8:28 PM · Workboards, Maniphest
epriestley closed T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything", a subtask of T5793: Add support for personal workboards, as Resolved.
Aug 22 2014, 8:28 PM · User Delight, Wikimedia, Workboards
epriestley added a comment to T5674: Add the ability to apply permissions on a workboard for rearranging cards, with some people being read only.

Is this still a problem after T4807, where the default behavior no longer involves priorities changing by surprise?

Aug 22 2014, 7:25 PM · Workboards, Maniphest

Aug 20 2014

swisspol added a comment to T4863: Allow Workboard Cards to be customized for display.

I've heard a few requests at our company in the recent days now that we do more "serious" project management, to have cards in workboards display the secondary projects. Any chance to get this rather soon? It's already behaving like this in Maniphest. People love workboards otherwise!

Aug 20 2014, 11:44 PM · Projects, Workboards, Wikimedia

Aug 15 2014

epriestley closed T5885: Optional limits to Workboard columns (number of cards) as Resolved.

Closed by commit rP300910f462a3.

Aug 15 2014, 6:16 PM · Workboards
epriestley added a revision to T5885: Optional limits to Workboard columns (number of cards): Restricted Differential Revision.
Aug 15 2014, 5:47 PM · Workboards
epriestley added a revision to T5885: Optional limits to Workboard columns (number of cards): Restricted Differential Revision.
Aug 15 2014, 5:11 PM · Workboards
epriestley added a revision to T4427: Add formal task points: Restricted Differential Revision.
Aug 15 2014, 4:17 PM · Wikimedia, Workboards, Maniphest

Aug 14 2014

chad triaged T5885: Optional limits to Workboard columns (number of cards) as Wishlist priority.
Aug 14 2014, 8:33 PM · Workboards
epriestley added a comment to T5885: Optional limits to Workboard columns (number of cards).

Cool, I think we can add this pretty easily after T4427 gets done.

Aug 14 2014, 7:19 PM · Workboards
greggrossmeier added a comment to T5885: Optional limits to Workboard columns (number of cards).

Soft (with associated "you did something bad!" red ;) ), would be good enough for me.

Aug 14 2014, 7:14 PM · Workboards
epriestley added a comment to T5885: Optional limits to Workboard columns (number of cards).

T4427 discusses displaying a count, where the count is derived either by counting tasks or summing some "points" field on the tasks.

Aug 14 2014, 7:10 PM · Workboards
epriestley added a subtask for T5885: Optional limits to Workboard columns (number of cards): T4427: Add formal task points.
Aug 14 2014, 7:08 PM · Workboards
greggrossmeier created T5885: Optional limits to Workboard columns (number of cards).
Aug 14 2014, 6:48 PM · Workboards